| Message ID | 20221214203124.564537-1-bhupesh.sharma@linaro.org |
|---|---|
| Headers | show |
| Series | arm64: dts: sm6115: Add USB SS qmp phy node and perform some cleanups | expand |
On 14/12/2022 21:31, Bhupesh Sharma wrote: > Add USB superspeed qmp phy node to dtsi. > Make sure that the oneplus board dts (which includes the > sm4250.dtsi) continues to work as intended. > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > .../boot/dts/qcom/sm4250-oneplus-billie2.dts | 3 ++ > arch/arm64/boot/dts/qcom/sm6115.dtsi | 38 ++++++++++++++++++- > 2 files changed, 39 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts b/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts > index 3f39f25e0721e..4f0d65574448b 100644 > --- a/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts > +++ b/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts > @@ -232,6 +232,9 @@ &usb { > &usb_dwc3 { > maximum-speed = "high-speed"; > dr_mode = "peripheral"; > + > + phys = <&usb_hsphy>; > + phy-names = "usb2-phy"; > }; > > &usb_hsphy { > diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi > index e4ce135264f3d..15f311dcd289f 100644 > --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi > @@ -579,6 +579,40 @@ usb_hsphy: phy@1613000 { > status = "disabled"; > }; > > + usb_qmpphy: phy@1615000 { > + compatible = "qcom,sm6115-qmp-usb3-phy"; > + reg = <0x01615000 0x200>; > + clocks = <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>, > + <&gcc GCC_USB3_PRIM_CLKREF_CLK>, > + <&gcc GCC_AHB2PHY_USB_CLK>; > + clock-names = "com_aux", > + "ref", > + "cfg_ahb"; > + resets = <&gcc GCC_USB3_PHY_PRIM_SP0_BCR>, > + <&gcc GCC_USB3PHY_PHY_PRIM_SP0_BCR>; > + reset-names = "phy", "phy_phy"; > + status = "disabled"; > + #clock-cells = <1>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + usb_ssphy: phy@1615200 { > + reg = <0x01615200 0x200>, > + <0x01615400 0x200>, > + <0x01615c00 0x400>, > + <0x01615600 0x200>, > + <0x01615800 0x200>, > + <0x01615a00 0x100>; > + #phy-cells = <0>; > + #clock-cells = <1>; > + clocks = <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>; > + clock-names = "pipe0"; > + clock-output-names = "usb3_phy_pipe_clk_src"; > + }; > + }; > + > + Still two blank lines. Best regards, Krzysztof
On Thu, 15 Dec 2022 at 13:49, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 14/12/2022 21:31, Bhupesh Sharma wrote: > > Add USB superspeed qmp phy node to dtsi. > > Make sure that the oneplus board dts (which includes the > > sm4250.dtsi) continues to work as intended. > > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > .../boot/dts/qcom/sm4250-oneplus-billie2.dts | 3 ++ > > arch/arm64/boot/dts/qcom/sm6115.dtsi | 38 ++++++++++++++++++- > > 2 files changed, 39 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts b/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts > > index 3f39f25e0721e..4f0d65574448b 100644 > > --- a/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts > > +++ b/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts > > @@ -232,6 +232,9 @@ &usb { > > &usb_dwc3 { > > maximum-speed = "high-speed"; > > dr_mode = "peripheral"; > > + > > + phys = <&usb_hsphy>; > > + phy-names = "usb2-phy"; > > }; > > > > &usb_hsphy { > > diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi > > index e4ce135264f3d..15f311dcd289f 100644 > > --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi > > @@ -579,6 +579,40 @@ usb_hsphy: phy@1613000 { > > status = "disabled"; > > }; > > > > + usb_qmpphy: phy@1615000 { > > + compatible = "qcom,sm6115-qmp-usb3-phy"; > > + reg = <0x01615000 0x200>; > > + clocks = <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>, > > + <&gcc GCC_USB3_PRIM_CLKREF_CLK>, > > + <&gcc GCC_AHB2PHY_USB_CLK>; > > + clock-names = "com_aux", > > + "ref", > > + "cfg_ahb"; > > + resets = <&gcc GCC_USB3_PHY_PRIM_SP0_BCR>, > > + <&gcc GCC_USB3PHY_PHY_PRIM_SP0_BCR>; > > + reset-names = "phy", "phy_phy"; > > + status = "disabled"; > > + #clock-cells = <1>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + > > + usb_ssphy: phy@1615200 { > > + reg = <0x01615200 0x200>, > > + <0x01615400 0x200>, > > + <0x01615c00 0x400>, > > + <0x01615600 0x200>, > > + <0x01615800 0x200>, > > + <0x01615a00 0x100>; > > + #phy-cells = <0>; > > + #clock-cells = <1>; > > + clocks = <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>; > > + clock-names = "pipe0"; > > + clock-output-names = "usb3_phy_pipe_clk_src"; > > + }; > > + }; > > + > > + > > Still two blank lines. Ok, I have sent a fixed v3. Please help review. Thanks, Bhupesh
Changes since v1: ----------------- - v1 can be seen here: https://lore.kernel.org/linux-arm-msm/20221213123823.455731-1-bhupesh.sharma@linaro.org/ - Addressed the review comments from Konrad and Krzysztof regarding the USB HS and SS Phy usage in sm4250 oneplus board dts ([PATCH 3/3]). - Collected R-B received from Konrad on v1 patches [1/3] and [2/3]. This series adds USB SS qmp phy node for Qualcomm SM6115 / SM4250 SoC dtsi and also performs some related cleanups for USB nodes. Note that this series is rebased on linux-next/master and is also dependent on the corresponding dt-bindings and driver series sent via [1]. [1]. https://lore.kernel.org/linux-arm-msm/20221213122843.454845-1-bhupesh.sharma@linaro.org/ Bhupesh Sharma (3): arm64: dts: qcom: sm6115: Cleanup USB node's label arm64: dts: qcom: sm6115: Move USB node's 'maximum-speed' and 'dr_mode' properties to dts arm64: dts: qcom: sm6115: Add USB SS qmp phy node .../boot/dts/qcom/sm4250-oneplus-billie2.dts | 12 ++++- arch/arm64/boot/dts/qcom/sm6115.dtsi | 46 ++++++++++++++++--- 2 files changed, 49 insertions(+), 9 deletions(-)