| Message ID | 20230118125936.3456716-2-a-verma1@ti.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | PCI: add 4x lane support for pci-j721e controllers | expand |
On 18/01/2023 13:59, Achal Verma wrote: > From: Matt Ranostay <mranostay@ti.com> > > Add num-lanes schema checks based on compatible string on available lanes > for that platform. > > Signed-off-by: Matt Ranostay <mranostay@ti.com> > Signed-off-by: Achal Verma <a-verma1@ti.com> > --- > .../bindings/pci/ti,j721e-pci-ep.yaml | 28 +++++++++++++++++-- > .../bindings/pci/ti,j721e-pci-host.yaml | 28 +++++++++++++++++-- > 2 files changed, 50 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml > index 10e6eabdff53..403cd3ef1177 100644 > --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml > +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml > @@ -10,9 +10,6 @@ title: TI J721E PCI EP (PCIe Wrapper) > maintainers: > - Kishon Vijay Abraham I <kishon@ti.com> > > -allOf: > - - $ref: "cdns-pcie-ep.yaml#" > - > properties: > compatible: > oneOf: > @@ -65,6 +62,31 @@ properties: > items: > - const: link_state > > +allOf: > + - $ref: cdns-pcie-ep.yaml# > + - if: > + properties: > + compatible: > + enum: > + - ti,am64-pcie-ep > + then: > + properties: > + num-lanes: > + minimum: 1 > + maximum: 1 > + > + - if: > + properties: > + compatible: > + enum: > + - ti,j7200-pcie-ep > + - ti,j721e-pcie-ep > + then: > + properties: > + num-lanes: > + minimum: 1 > + maximum: 2 > + > required: > - compatible > - reg > diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml > index b0513b197d08..7bd78cfca845 100644 > --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml > +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml > @@ -10,9 +10,6 @@ title: TI J721E PCI Host (PCIe Wrapper) > maintainers: > - Kishon Vijay Abraham I <kishon@ti.com> > > -allOf: > - - $ref: "cdns-pcie-host.yaml#" > - > properties: > compatible: > oneOf: > @@ -98,6 +95,31 @@ properties: > interrupts: > maxItems: 1 > > +allOf: > + - $ref: cdns-pcie-host.yaml# > + - if: > + properties: > + compatible: > + enum: > + - ti,am64-pcie-host > + then: > + properties: > + num-lanes: > + minimum: 1 > + maximum: 1 Why not what I asked for? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml index 10e6eabdff53..403cd3ef1177 100644 --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml @@ -10,9 +10,6 @@ title: TI J721E PCI EP (PCIe Wrapper) maintainers: - Kishon Vijay Abraham I <kishon@ti.com> -allOf: - - $ref: "cdns-pcie-ep.yaml#" - properties: compatible: oneOf: @@ -65,6 +62,31 @@ properties: items: - const: link_state +allOf: + - $ref: cdns-pcie-ep.yaml# + - if: + properties: + compatible: + enum: + - ti,am64-pcie-ep + then: + properties: + num-lanes: + minimum: 1 + maximum: 1 + + - if: + properties: + compatible: + enum: + - ti,j7200-pcie-ep + - ti,j721e-pcie-ep + then: + properties: + num-lanes: + minimum: 1 + maximum: 2 + required: - compatible - reg diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml index b0513b197d08..7bd78cfca845 100644 --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml @@ -10,9 +10,6 @@ title: TI J721E PCI Host (PCIe Wrapper) maintainers: - Kishon Vijay Abraham I <kishon@ti.com> -allOf: - - $ref: "cdns-pcie-host.yaml#" - properties: compatible: oneOf: @@ -98,6 +95,31 @@ properties: interrupts: maxItems: 1 +allOf: + - $ref: cdns-pcie-host.yaml# + - if: + properties: + compatible: + enum: + - ti,am64-pcie-host + then: + properties: + num-lanes: + minimum: 1 + maximum: 1 + + - if: + properties: + compatible: + enum: + - ti,j7200-pcie-host + - ti,j721e-pcie-host + then: + properties: + num-lanes: + minimum: 1 + maximum: 2 + required: - compatible - reg