diff mbox series

[10/10] accel/tcg: remove unused includes

Message ID 20230320101035.2214196-11-alex.bennee@linaro.org
State New
Headers show
Series accel/tcg: refactor the cpu-exec loop | expand

Commit Message

Alex Bennée March 20, 2023, 10:10 a.m. UTC
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 accel/tcg/cpu-exec.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Richard Henderson March 20, 2023, 4:30 p.m. UTC | #1
On 3/20/23 03:10, Alex Bennée wrote:
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> ---
>   accel/tcg/cpu-exec.c | 4 ----
>   1 file changed, 4 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
Alessandro Di Federico March 21, 2023, 4:07 p.m. UTC | #2
Did we ever try include-what-you-use on QEMU?

    https://github.com/include-what-you-use/include-what-you-use

I guess it doesn't play well with the tons of different configurations
we have, but in my experience even without auto-applying its
suggestions it can be beneficial to catch low hanging fruits.

Reviewed-by: Alessandro Di Federico <ale@rev.ng>
diff mbox series

Patch

diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index 56be7956e7..90e327c3bb 100644
--- a/accel/tcg/cpu-exec.c
+++ b/accel/tcg/cpu-exec.c
@@ -19,20 +19,16 @@ 
 
 #include "qemu/osdep.h"
 #include "qemu/qemu-print.h"
-#include "qapi/error.h"
-#include "qapi/type-helpers.h"
 #include "hw/core/tcg-cpu-ops.h"
 #include "hw/core/sysemu-cpu-ops.h"
 #include "trace.h"
 #include "disas/disas.h"
-#include "exec/exec-all.h"
 #include "tcg/tcg.h"
 #include "qemu/atomic.h"
 #include "qemu/rcu.h"
 #include "exec/log.h"
 #include "qemu/main-loop.h"
 #include "sysemu/cpus.h"
-#include "exec/cpu-all.h"
 #include "sysemu/cpu-timers.h"
 #include "exec/replay-core.h"
 #include "sysemu/tcg.h"