| Message ID | 20230407-pm7250b-sid-v1-0-fc648478cc25@fairphone.com |
|---|---|
| Headers | show |
| Series | Make SID for PM7250B configurable (and a small fixup) | expand |
On Fri Apr 7, 2023 at 10:27 AM CEST, Krzysztof Kozlowski wrote: > On 07/04/2023 09:45, Luca Weiss wrote: > > Like other Qualcomm PMICs the PM7250B can be used on different addresses > > on the SPMI bus. Use similar defines like the PMK8350 to make this > > possible. > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > --- > > arch/arm64/boot/dts/qcom/pm7250b.dtsi | 23 ++++++++++++++++------- > > 1 file changed, 16 insertions(+), 7 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dts/qcom/pm7250b.dtsi > > index daa6f1d30efa..eeb476edc79a 100644 > > --- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi > > +++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi > > @@ -7,6 +7,15 @@ > > #include <dt-bindings/interrupt-controller/irq.h> > > #include <dt-bindings/spmi/spmi.h> > > > > +/* This PMIC can be configured to be at different SIDs */ > > +#ifndef PM7250B_SID > > + #define PM7250B_SID 2 > > Drop indentation, although anyway I am against this. Please don't bring > new patterns of this at least till we settle previous discussion. > > https://lore.kernel.org/linux-arm-msm/46658cbb-fff5-e98b-fdad-88fa683a9c75@linaro.org/ Ok I'll wait for that to conclude then. Let's only consider patch 1/2 from this series then for now. Regards Luca > > > Best regards, > Krzysztof
On Fri, 07 Apr 2023 09:45:43 +0200, Luca Weiss wrote: > Like other Qualcomm PMICs the PM7250B can be used on different addresses > on the SPMI bus. Use similar defines like the PMK8350 to make this > possible. > > Applied, thanks! [1/2] arm64: dts: qcom: pm7250b: add missing spmi-vadc include commit: 83022f6484b11a60dbf9a95a88c7ef8e59c4b19c [2/2] arm64: dts: qcom: pm7250b: make SID configurable (no commit info) Best regards,
Like other Qualcomm PMICs the PM7250B can be used on different addresses on the SPMI bus. Use similar defines like the PMK8350 to make this possible. Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- Luca Weiss (2): arm64: dts: qcom: pm7250b: add missing spmi-vadc include arm64: dts: qcom: pm7250b: make SID configurable arch/arm64/boot/dts/qcom/pm7250b.dtsi | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) --- base-commit: 7e364e56293bb98cae1b55fd835f5991c4e96e7d change-id: 20230407-pm7250b-sid-68e37a58244e Best regards,