| Message ID | 20230502131200.2551513-3-rui.silva@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | corstone1000: fwu metadata and GPT | expand |
On 5/2/23 15:11, Rui Miguel Silva wrote: > Move header to include to allow external code > to get the internal bdev structures to access > block device operations. > > as at it, just add the UCLASS_NVMXIP string > so we get the correct output in partitions > listing. > > Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> > --- > {drivers/mtd/nvmxip => include}/nvmxip.h | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename {drivers/mtd/nvmxip => include}/nvmxip.h (100%) > > diff --git a/drivers/mtd/nvmxip/nvmxip.h b/include/nvmxip.h > similarity index 100% > rename from drivers/mtd/nvmxip/nvmxip.h > rename to include/nvmxip.h We expect the code to compile after each single patch. Otherwise bisecting will not work. You cannot move an include without adjusting all references, e.g. test/dm/nvmxip.c:20:#include "../../drivers/mtd/nvmxip/nvmxip.h" Best regards Heinrich
Hi Heinrich, Thanks for the review. Heinrich Schuchardt <xypron.glpk@gmx.de> writes: > On 5/2/23 15:11, Rui Miguel Silva wrote: >> Move header to include to allow external code >> to get the internal bdev structures to access >> block device operations. >> >> as at it, just add the UCLASS_NVMXIP string >> so we get the correct output in partitions >> listing. >> >> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> >> --- >> {drivers/mtd/nvmxip => include}/nvmxip.h | 0 >> 1 file changed, 0 insertions(+), 0 deletions(-) >> rename {drivers/mtd/nvmxip => include}/nvmxip.h (100%) >> >> diff --git a/drivers/mtd/nvmxip/nvmxip.h b/include/nvmxip.h >> similarity index 100% >> rename from drivers/mtd/nvmxip/nvmxip.h >> rename to include/nvmxip.h > > We expect the code to compile after each single patch. Otherwise > bisecting will not work. > > You cannot move an include without adjusting all references, e.g. > test/dm/nvmxip.c:20:#include "../../drivers/mtd/nvmxip/nvmxip.h" Hrrr, thanks for noticing this. I will fix it in v2. Cheers, Rui > > Best regards > > Heinrich
diff --git a/drivers/mtd/nvmxip/nvmxip.h b/include/nvmxip.h
similarity index 100%
rename from drivers/mtd/nvmxip/nvmxip.h
rename to include/nvmxip.h
Move header to include to allow external code to get the internal bdev structures to access block device operations. as at it, just add the UCLASS_NVMXIP string so we get the correct output in partitions listing. Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> --- {drivers/mtd/nvmxip => include}/nvmxip.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename {drivers/mtd/nvmxip => include}/nvmxip.h (100%)