mbox series

[v4,00/18] selftests/nolibc: allow run with minimal kernel config

Message ID cover.1688750763.git.falcon@tinylab.org
Headers show
Series selftests/nolibc: allow run with minimal kernel config | expand

Message

Zhangjin Wu July 7, 2023, 6:21 p.m. UTC
Hi, Willy

This v4 mainly uses the argv0 suggested by you, at the same time, a new
run-libc-test target is added for glibc and musl, and the RB_ flags are
added for nolibc to allow compile nolibc-test.c without <linux/reboot.h>
for glibc, musl and nolibc (mainly for musl-gcc, without -I
/path/to/sysroot). 

This patchset is based on the 20230705-nolibc-series2 branch of nolibc
repo [2], it must be applied after our v6 __sysret series [3] (argv0
exported there) and Thomas' chmod_net removal patchset [4] (the new
chmod_argv0 is added at the same line of chmod_net, will conflict).

This patchset assumes the chmod_net removal patchset will be applied at
first, if not, the chmod_argv0 added alphabetically will not be applied.
Since our new chmod_argv0 is exactly added to replace chmod_net, so,
Willy, is it ok for you to at least apply the chmod_net removal patch
[5] before this patchset?

    selftests/nolibc: drop test chmod_net

This patchset is tested together with the v6 __sysret series [3]:

               arch/board | result
              ------------|------------
          arm/vexpress-a9 | 142 test(s) passed, 1 skipped, 0 failed.
                 arm/virt | 142 test(s) passed, 1 skipped, 0 failed.
             aarch64/virt | 142 test(s) passed, 1 skipped, 0 failed.
              ppc/g3beige | not supported
              ppc/ppce500 | not supported
                  i386/pc | 142 test(s) passed, 1 skipped, 0 failed.
                x86_64/pc | 142 test(s) passed, 1 skipped, 0 failed.
             mipsel/malta | 142 test(s) passed, 1 skipped, 0 failed.
         loongarch64/virt | 142 test(s) passed, 1 skipped, 0 failed.
             riscv64/virt | 142 test(s) passed, 1 skipped, 0 failed.
             riscv32/virt | 0 test(s) passed, 0 skipped, 0 failed.
    s390x/s390-ccw-virtio | 142 test(s) passed, 1 skipped, 0 failed.

If use tinyconfig + basic console options (means disable all of the
other options, include procfs, shmem, tmpfs, net and memfd_create, to
save test time, only randomly choose 4 archs):


    ...

    LOG: testing report for loongarch64/virt:

    15 chmod_self                                                   [SKIPPED]
    16 chown_self                                                   [SKIPPED]
    40 link_cross                                                   [SKIPPED]
    0 -fstackprotector not supported                                [SKIPPED]

    139 test(s) passed, 4 skipped, 0 failed.
    See all results in /labs/linux-lab/logging/nolibc/loongarch64-virt-nolibc-test.log

    LOG: testing summary:

          arch/board | result
         ------------|------------
     arm/vexpress-a9 | 139 test(s) passed, 4 skipped, 0 failed.
           x86_64/pc | 139 test(s) passed, 4 skipped, 0 failed.
        mipsel/malta | 139 test(s) passed, 4 skipped, 0 failed.
    loongarch64/virt | 139 test(s) passed, 4 skipped, 0 failed.

Changes from v3 --> v4:

* selftests/nolibc: stat_fault: silence NULL argument warning with glibc
  selftests/nolibc: gettid: restore for glibc and musl
  selftests/nolibc: add _LARGEFILE64_SOURCE for musl
  selftests/nolibc: fix up int_fast16/32_t test cases for musl
  selftests/nolibc: fix up kernel parameters support
  selftests/nolibc: link_cross: use /proc/self/cmdline
  tools/nolibc: add rmdir() support
  selftests/nolibc: add a new rmdir() test case
  selftests/nolibc: fix up failures when CONFIG_PROC_FS=n
  selftests/nolibc: prepare /tmp for tmpfs or ramfs
  selftests/nolibc: vfprintf: remove MEMFD_CREATE dependency

    No change.

* selftests/nolibc: add run-libc-test target

    New run and report for glibc or musl. for musl, we can simply issue:

    $ make run-libc-test CC=/path/to/musl-install/bin/musl-gcc

* tools/nolibc: types.h: add RB_ flags for reboot()
  selftests/nolibc: prefer <sys/reboot.h> to <linux/reboot.h>

    Required by musl to compile nolibc-test.c without -I/path/to/sysroot

* selftests/nolibc: chdir_root: restore current path after test

    restore current path to prevent breakage of using relative path

* selftests/nolibc: stat_timestamps: remove procfs dependency
  selftests/nolibc: chroot_exe: remove procfs dependency
  selftests/nolibc: add chmod_argv0 test

    use argv0 instead of '/init' as before.

Best regards,
Zhangjin
---
[1]: https://lore.kernel.org/lkml/cover.1688134399.git.falcon@tinylab.org/
[2]: https://git.kernel.org/pub/scm/linux/kernel/git/wtarreau/nolibc.git
[3]: https://lore.kernel.org/lkml/cover.1688739492.git.falcon@tinylab.org/
[4]: https://lore.kernel.org/lkml/20230624-proc-net-setattr-v1-0-73176812adee@weissschuh.net/
[5]: https://lore.kernel.org/lkml/20230624-proc-net-setattr-v1-1-73176812adee@weissschuh.net/

Zhangjin Wu (18):
  selftests/nolibc: add run-libc-test target
  selftests/nolibc: stat_fault: silence NULL argument warning with glibc
  selftests/nolibc: gettid: restore for glibc and musl
  selftests/nolibc: add _LARGEFILE64_SOURCE for musl
  selftests/nolibc: fix up int_fast16/32_t test cases for musl
  tools/nolibc: types.h: add RB_ flags for reboot()
  selftests/nolibc: prefer <sys/reboot.h> to <linux/reboot.h>
  selftests/nolibc: fix up kernel parameters support
  selftests/nolibc: link_cross: use /proc/self/cmdline
  tools/nolibc: add rmdir() support
  selftests/nolibc: add a new rmdir() test case
  selftests/nolibc: fix up failures when CONFIG_PROC_FS=n
  selftests/nolibc: prepare /tmp for tmpfs or ramfs
  selftests/nolibc: vfprintf: remove MEMFD_CREATE dependency
  selftests/nolibc: chdir_root: restore current path after test
  selftests/nolibc: stat_timestamps: remove procfs dependency
  selftests/nolibc: chroot_exe: remove procfs dependency
  selftests/nolibc: add chmod_argv0 test

 tools/include/nolibc/sys.h                   | 23 ++++-
 tools/include/nolibc/types.h                 | 12 ++-
 tools/testing/selftests/nolibc/Makefile      |  4 +
 tools/testing/selftests/nolibc/nolibc-test.c | 88 +++++++++++++++-----
 4 files changed, 104 insertions(+), 23 deletions(-)

Comments

Willy Tarreau July 9, 2023, 9:41 a.m. UTC | #1
Hi Zhangjin,

On Sat, Jul 08, 2023 at 02:21:20AM +0800, Zhangjin Wu wrote:
> This patchset assumes the chmod_net removal patchset will be applied at
> first, if not, the chmod_argv0 added alphabetically will not be applied.
> Since our new chmod_argv0 is exactly added to replace chmod_net, so,
> Willy, is it ok for you to at least apply the chmod_net removal patch
> [5] before this patchset?

Sure, and thanks for the reminder, I had missed it in the middle of
the flood.

(...)
>     LOG: testing summary:
> 
>           arch/board | result
>          ------------|------------
>      arm/vexpress-a9 | 139 test(s) passed, 4 skipped, 0 failed.
>            x86_64/pc | 139 test(s) passed, 4 skipped, 0 failed.
>         mipsel/malta | 139 test(s) passed, 4 skipped, 0 failed.
>     loongarch64/virt | 139 test(s) passed, 4 skipped, 0 failed.

Great, I like this, thank you! That was precisely the purpose of the
"skipped" initially, not to be too strictly bound to a specific config.
Now it's indeed even more flexible and that's better.

Series queued as well, thank you!
Willy
Willy Tarreau July 9, 2023, 10:02 a.m. UTC | #2
Zhangjin,

for your convenience, I've queued your pending series and Thomas's patches
in the following order here: 20230709-nolibc-ser2-tom-syscall-configv4

  series2, thomas' chmod_net and ioperm patches, your new syscall series,
  and your tiny config version 4 series.

Thomas and Zhangjin, do not hesitate to let me know if I missed anything.
The two series I left aside for now are still just under discussion
(output reformating and reorganisation of the arch include files).

We're getting closer to having something done now!

Thanks!
Willy