| Message ID | 20230711-startek_display-v1-0-163917bed385@baylibre.com |
|---|---|
| Headers | show |
| Series | Add startek-kd070fhfid015 display support | expand |
On 11/07/2023 17:36, Alexandre Mergnat wrote: > The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution > of 1024 x 600 pixels. > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > .../display/panel/startek,kd070fhfid015.yaml | 51 ++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml b/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml > new file mode 100644 > index 000000000000..857658e002fd > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/startek,kd070fhfid015.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Startek Electronic Technology Co. kd070fhfid015 7 inch TFT LCD panel > + > +maintainers: > + - Alexandre Mergnat <amergnat@baylibre.com> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: startek,kd070fhfid015 > + > + dcdc-gpios: true
Hi Krzysztof, Thanks for your review On 12/07/2023 07:32, Krzysztof Kozlowski wrote: > On 11/07/2023 17:36, Alexandre Mergnat wrote: >> The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution snip >> + >> + dcdc-gpios: true > > From where does this come? Which schema defines it? It's a miss. I will fix it and reset-gpios too by adding a maxItems and a description. >> + >> + height-mm: >> + const: 151 >> + >> + iovcc-supply: >> + description: Reference to the regulator powering the panel IO pins. >> + >> + reg: >> + maxItems: 1 >> + description: DSI virtual channel >> + >> + reset-gpios: true >> + >> + port: true >> + >> + power-supply: true >> + >> + width-mm: >> + const: 95 >> + >> +additionalProperties: false >> + >> +required: >> + - compatible >> + - dcdc-gpios >> + - iovcc-supply >> + - reg >> + - reset-gpios >> + - port >> + - power-supply > > Missing example. I will add it.
On 12/07/2023 10:01, Alexandre Mergnat wrote: > Hi Krzysztof, > > Thanks for your review > > On 12/07/2023 07:32, Krzysztof Kozlowski wrote: >> On 11/07/2023 17:36, Alexandre Mergnat wrote: >>> The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution > > snip > >>> + >>> + dcdc-gpios: true >> >> From where does this come? Which schema defines it? > > It's a miss. I will fix it and reset-gpios too by adding a maxItems and > a description. reset-gpios come from panel-common, so they are fine. Best regards, Krzysztof
Add the support of the Startek KD070FHFID015 panel. It's a 7-inch TFT LCD display with a resolution of 1024 x 600 pixels. This serie come from a bigger one [1]. Then I addressed the previous comments for the related commits here. Changes in v1: - Fix typos in the driver. - Merge 2 regulators in one bulk variable in the driver. - Remove backlight enable/disable from the driver because it's already managed by the backlight core. - Move hardcoded values from function to the generic structure in the driver. - Remove unnecessary function (stk_panel_del). - Replace some functions by macro to increase the readability. - Link to parent serie: [1] [1]: https://lore.kernel.org/all/20230220-display-v1-0-45cbc68e188b@baylibre.com/ Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> --- Alexandre Mergnat (2): dt-bindings: display: panel: add startek kd070fhfid015 support arm64: defconfig: enable STARTEK KD070FHFID015 panel Guillaume La Roque (1): drm/panel: Support for startek-kd070fhfid015 MIPI-DSI panel .../display/panel/startek,kd070fhfid015.yaml | 51 +++ arch/arm64/configs/defconfig | 1 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-startek-kd070fhfid015.c | 434 +++++++++++++++++++++ 5 files changed, 498 insertions(+) --- base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 change-id: 20230711-startek_display-958d265f6baa Best regards,