| Message ID | 20230809191054.2197963-1-bmasney@redhat.com |
|---|---|
| Headers | show |
| Series | scsi: ufs: convert probe to use dev_err_probe() | expand |
On 8/9/2023 12:10 PM, Brian Masney wrote: > Convert ufshcd_pltfrm_init() over to use dev_err_probe() to avoid > the following log message on bootup due to an -EPROBE_DEFER return > code: > > ufshcd-qcom 1d84000.ufs: Initialization failed > > Signed-off-by: Brian Masney <bmasney@redhat.com> > --- > No changes since v1 > > drivers/ufs/host/ufshcd-pltfrm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ufs/host/ufshcd-pltfrm.c b/drivers/ufs/host/ufshcd-pltfrm.c > index 0b7430033047..f2c50b78efbf 100644 > --- a/drivers/ufs/host/ufshcd-pltfrm.c > +++ b/drivers/ufs/host/ufshcd-pltfrm.c > @@ -373,7 +373,7 @@ int ufshcd_pltfrm_init(struct platform_device *pdev, > > err = ufshcd_init(hba, mmio_base, irq); > if (err) { > - dev_err(dev, "Initialization failed\n"); > + dev_err_probe(dev, err, "Initialization failed\n"); Hi Brian, Can you pls add the error code to the print? > goto dealloc_host; > } >
The following two log messages are shown on bootup due to an -EPROBE_DEFER when booting on a Qualcomm sa8775p development board: ufshcd-qcom 1d84000.ufs: ufshcd_variant_hba_init: variant qcom init failed err -517 ufshcd-qcom 1d84000.ufs: Initialization failed This patch series converts the relevant two probe functions over to use dev_err_probe() so that these messages are not shown on bootup. Changes since v1 https://lore.kernel.org/lkml/20230808142650.1713432-1-bmasney@redhat.com/ - Dropped code cleanup Brian Masney (2): scsi: ufs: core: convert to dev_err_probe() in hba_init scsi: ufs: host: convert to dev_err_probe() in pltfrm_init drivers/ufs/core/ufshcd.c | 5 +++-- drivers/ufs/host/ufshcd-pltfrm.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-)