| Message ID | 20230831051945.515476-1-alexhenrie24@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | scsi: ppa: Fix accidentally reversed conditions for 16-bit and 32-bit EPP | expand |
Alex, > The conditions were correct in the ppa_in function but not in the > ppa_out function. Applied to 6.6/scsi-staging, thanks!
On Wed, 30 Aug 2023 23:19:42 -0600, Alex Henrie wrote: > The conditions were correct in the ppa_in function but not in the > ppa_out function. > > Applied to 6.6/scsi-fixes, thanks! [1/1] scsi: ppa: Fix accidentally reversed conditions for 16-bit and 32-bit EPP https://git.kernel.org/mkp/scsi/c/31a0865bf593
diff --git a/drivers/scsi/ppa.c b/drivers/scsi/ppa.c index 19f0b93fa3d8..d592ee9170c1 100644 --- a/drivers/scsi/ppa.c +++ b/drivers/scsi/ppa.c @@ -307,9 +307,9 @@ static int ppa_out(ppa_struct *dev, char *buffer, int len) case PPA_EPP_8: epp_reset(ppb); w_ctr(ppb, 0x4); - if (dev->mode == PPA_EPP_32 && !(((long) buffer | len) & 0x01)) + if (dev->mode == PPA_EPP_32 && !(((long) buffer | len) & 0x03)) outsl(ppb + 4, buffer, len >> 2); - else if (dev->mode == PPA_EPP_16 && !(((long) buffer | len) & 0x03)) + else if (dev->mode == PPA_EPP_16 && !(((long) buffer | len) & 0x01)) outsw(ppb + 4, buffer, len >> 1); else outsb(ppb + 4, buffer, len);
The conditions were correct in the ppa_in function but not in the ppa_out function. Fixes: 68a4f84a17c1 ("scsi: ppa: Add a module parameter for the transfer mode") Signed-off-by: Alex Henrie <alexhenrie24@gmail.com> --- drivers/scsi/ppa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)