| Message ID | 20231201093633.2551497-7-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | final fixes for 8.2 | expand |
On 1/12/23 10:36, Alex Bennée wrote: > We inadvertently built the LE target for BE tests. > > Fixes: 78ebc00b06 (gitlab: shuffle some targets and reduce avocado noise) > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > .gitlab-ci.d/buildtest.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Oops. Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On 01/12/2023 10.36, Alex Bennée wrote: > We inadvertently built the LE target for BE tests. > > Fixes: 78ebc00b06 (gitlab: shuffle some targets and reduce avocado noise) > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > .gitlab-ci.d/buildtest.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml > index 7f9af83b10..62b5379a5e 100644 > --- a/.gitlab-ci.d/buildtest.yml > +++ b/.gitlab-ci.d/buildtest.yml > @@ -41,7 +41,7 @@ build-system-ubuntu: > variables: > IMAGE: ubuntu2204 > CONFIGURE_ARGS: --enable-docs > - TARGETS: alpha-softmmu microblazeel-softmmu mips64el-softmmu > + TARGETS: alpha-softmmu microblaze-softmmu mips64el-softmmu > MAKE_CHECK_ARGS: check-build > > check-system-ubuntu: We've got microblazeel-softmmu here and microblaze-softmmu in the build-system-fedora job. So please don't change the ubuntu job here, otherwise we're building the same target twice instead. Thomas
Thomas Huth <thuth@redhat.com> writes: > On 01/12/2023 10.36, Alex Bennée wrote: >> We inadvertently built the LE target for BE tests. >> Fixes: 78ebc00b06 (gitlab: shuffle some targets and reduce avocado >> noise) >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >> --- >> .gitlab-ci.d/buildtest.yml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml >> index 7f9af83b10..62b5379a5e 100644 >> --- a/.gitlab-ci.d/buildtest.yml >> +++ b/.gitlab-ci.d/buildtest.yml >> @@ -41,7 +41,7 @@ build-system-ubuntu: >> variables: >> IMAGE: ubuntu2204 >> CONFIGURE_ARGS: --enable-docs >> - TARGETS: alpha-softmmu microblazeel-softmmu mips64el-softmmu >> + TARGETS: alpha-softmmu microblaze-softmmu mips64el-softmmu >> MAKE_CHECK_ARGS: check-build >> check-system-ubuntu: > > We've got microblazeel-softmmu here and microblaze-softmmu in the > build-system-fedora job. So please don't change the ubuntu job here, > otherwise we're building the same target twice instead. Hmm - what would be really useful is an actual microblazeel test image so we can test what we build.
On 04/12/2023 13.40, Alex Bennée wrote: > Thomas Huth <thuth@redhat.com> writes: > >> On 01/12/2023 10.36, Alex Bennée wrote: >>> We inadvertently built the LE target for BE tests. >>> Fixes: 78ebc00b06 (gitlab: shuffle some targets and reduce avocado >>> noise) >>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >>> --- >>> .gitlab-ci.d/buildtest.yml | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml >>> index 7f9af83b10..62b5379a5e 100644 >>> --- a/.gitlab-ci.d/buildtest.yml >>> +++ b/.gitlab-ci.d/buildtest.yml >>> @@ -41,7 +41,7 @@ build-system-ubuntu: >>> variables: >>> IMAGE: ubuntu2204 >>> CONFIGURE_ARGS: --enable-docs >>> - TARGETS: alpha-softmmu microblazeel-softmmu mips64el-softmmu >>> + TARGETS: alpha-softmmu microblaze-softmmu mips64el-softmmu >>> MAKE_CHECK_ARGS: check-build >>> check-system-ubuntu: >> >> We've got microblazeel-softmmu here and microblaze-softmmu in the >> build-system-fedora job. So please don't change the ubuntu job here, >> otherwise we're building the same target twice instead. > > Hmm - what would be really useful is an actual microblazeel test image > so we can test what we build. We've got at least a small test in tests/qtest/boot-serial-test.c, so we know that at least some instructions can be executed via TCG. Thomas
On 12/4/23 13:43, Thomas Huth wrote: > On 04/12/2023 13.40, Alex Bennée wrote: >> Thomas Huth <thuth@redhat.com> writes: >> >>> On 01/12/2023 10.36, Alex Bennée wrote: >>>> We inadvertently built the LE target for BE tests. >>>> Fixes: 78ebc00b06 (gitlab: shuffle some targets and reduce avocado >>>> noise) >>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >>>> --- >>>> .gitlab-ci.d/buildtest.yml | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml >>>> index 7f9af83b10..62b5379a5e 100644 >>>> --- a/.gitlab-ci.d/buildtest.yml >>>> +++ b/.gitlab-ci.d/buildtest.yml >>>> @@ -41,7 +41,7 @@ build-system-ubuntu: >>>> variables: >>>> IMAGE: ubuntu2204 >>>> CONFIGURE_ARGS: --enable-docs >>>> - TARGETS: alpha-softmmu microblazeel-softmmu mips64el-softmmu >>>> + TARGETS: alpha-softmmu microblaze-softmmu mips64el-softmmu >>>> MAKE_CHECK_ARGS: check-build >>>> check-system-ubuntu: >>> >>> We've got microblazeel-softmmu here and microblaze-softmmu in the >>> build-system-fedora job. So please don't change the ubuntu job here, >>> otherwise we're building the same target twice instead. >> >> Hmm - what would be really useful is an actual microblazeel test image >> so we can test what we build. > > We've got at least a small test in tests/qtest/boot-serial-test.c, so we know that at least some instructions can be executed via TCG. There are 2 configs under buildroot, qemu_microblazebe_mmu_defconfig and qemu_microblazeel_mmu_defconfig, we could possibly use. C.
On 04/12/2023 13.48, Cédric Le Goater wrote: > On 12/4/23 13:43, Thomas Huth wrote: >> On 04/12/2023 13.40, Alex Bennée wrote: >>> Thomas Huth <thuth@redhat.com> writes: >>> >>>> On 01/12/2023 10.36, Alex Bennée wrote: >>>>> We inadvertently built the LE target for BE tests. >>>>> Fixes: 78ebc00b06 (gitlab: shuffle some targets and reduce avocado >>>>> noise) >>>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >>>>> --- >>>>> .gitlab-ci.d/buildtest.yml | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml >>>>> index 7f9af83b10..62b5379a5e 100644 >>>>> --- a/.gitlab-ci.d/buildtest.yml >>>>> +++ b/.gitlab-ci.d/buildtest.yml >>>>> @@ -41,7 +41,7 @@ build-system-ubuntu: >>>>> variables: >>>>> IMAGE: ubuntu2204 >>>>> CONFIGURE_ARGS: --enable-docs >>>>> - TARGETS: alpha-softmmu microblazeel-softmmu mips64el-softmmu >>>>> + TARGETS: alpha-softmmu microblaze-softmmu mips64el-softmmu >>>>> MAKE_CHECK_ARGS: check-build >>>>> check-system-ubuntu: >>>> >>>> We've got microblazeel-softmmu here and microblaze-softmmu in the >>>> build-system-fedora job. So please don't change the ubuntu job here, >>>> otherwise we're building the same target twice instead. >>> >>> Hmm - what would be really useful is an actual microblazeel test image >>> so we can test what we build. >> >> We've got at least a small test in tests/qtest/boot-serial-test.c, so we >> know that at least some instructions can be executed via TCG. > > There are 2 configs under buildroot, qemu_microblazebe_mmu_defconfig and > qemu_microblazeel_mmu_defconfig, we could possibly use. I already used the big endian config for going shopping for ballerinas (which we already use in one of the avocado tests): http://www.qemu-advent-calendar.org/2018/#day-17 And as I just learnt today, the QEMU advent calendar opens its doors again in 2023: http://www.qemu-advent-calendar.org/2023/ Let's see, maybe we can have a nice surprise for microblazeel this time... Thomas
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 7f9af83b10..62b5379a5e 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -41,7 +41,7 @@ build-system-ubuntu: variables: IMAGE: ubuntu2204 CONFIGURE_ARGS: --enable-docs - TARGETS: alpha-softmmu microblazeel-softmmu mips64el-softmmu + TARGETS: alpha-softmmu microblaze-softmmu mips64el-softmmu MAKE_CHECK_ARGS: check-build check-system-ubuntu:
We inadvertently built the LE target for BE tests. Fixes: 78ebc00b06 (gitlab: shuffle some targets and reduce avocado noise) Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- .gitlab-ci.d/buildtest.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)