mbox series

[net-next,0/2] net: phy: qcom: qca808x: fixup qca808x LED

Message ID 20240201134602.11085-1-ansuelsmth@gmail.com
Headers show
Series net: phy: qcom: qca808x: fixup qca808x LED | expand

Message

Christian Marangi Feb. 1, 2024, 1:45 p.m. UTC 
This is a bit embarassing and totally my fault so sorry for that!

While reworking the patch to phy_modify API, it was done a logic
error and made the brightness_set function broken. It wasn't
notice in last revisions test as the testing method was to verify
if hw control was correctly working.

Noticing this problem also made me notice an additional problem
with the polarity.

The introduced patch made the polarity configurable but I forgot
to add the required code to enable Active High by default.
(the PHY sets active low by default)

This wasn't notice with hw control testing as the LED blink on
traffic and polarity problem are not notice.

It might be worth discussing if needed a change in implementation
where the polarity function is always called but I think it's
better this way where specific PHY apply fixup with the help
of priv struct and on the config_init phase.

Christian Marangi (2):
  net: phy: qcom: qca808x: fix logic error in LED brightness set
  net: phy: qcom: qca808x: default to LED active High if not set

 drivers/net/phy/qcom/qca808x.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Feb. 3, 2024, 1 p.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu,  1 Feb 2024 14:45:59 +0100 you wrote:
> This is a bit embarassing and totally my fault so sorry for that!
> 
> While reworking the patch to phy_modify API, it was done a logic
> error and made the brightness_set function broken. It wasn't
> notice in last revisions test as the testing method was to verify
> if hw control was correctly working.
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] net: phy: qcom: qca808x: fix logic error in LED brightness set
    https://git.kernel.org/netdev/net-next/c/f2ec98566775
  - [net-next,2/2] net: phy: qcom: qca808x: default to LED active High if not set
    https://git.kernel.org/netdev/net-next/c/f203c8c77c76

You are awesome, thank you!