| Message ID | 20240202-pm4125-typec-v2-0-12771d85700d@linaro.org |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: qrb2210-rb1: enable Type-C support | expand |
On 02/02/2024 00:55, Dmitry Baryshkov wrote: > Plug in USB-C related bits and pieces to enable USB role switching and > USB-C orientation handling for the Qualcomm RB1 board. > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On Fri, 02 Feb 2024 01:55:07 +0200, Dmitry Baryshkov wrote: > Reuse Type-C support implemented for the PMI632 PMIC (found on Qualcomm > Robotics RB2 platform) and implement Type-C handling for the Qualcomm > Robotics RB1 platform. > > Dependencies: [1] > > [1] https://lore.kernel.org/linux-arm-msm/20240130-pmi632-typec-v3-0-b05fe44f0a51@linaro.org/ > > [...] Applied, thanks! [3/4] arm64: dts: qcom: pm4125: define USB-C related blocks commit: 46ea59235c4f00bbca6955cf05d7cc0fccde7a64 [4/4] arm64: dts: qcom: qrb2210-rb1: enable USB-C port handling (no commit info) Best regards,
On Tue, 20 Feb 2024 at 19:57, Bjorn Andersson <andersson@kernel.org> wrote: > > > On Fri, 02 Feb 2024 01:55:07 +0200, Dmitry Baryshkov wrote: > > Reuse Type-C support implemented for the PMI632 PMIC (found on Qualcomm > > Robotics RB2 platform) and implement Type-C handling for the Qualcomm > > Robotics RB1 platform. > > > > Dependencies: [1] > > > > [1] https://lore.kernel.org/linux-arm-msm/20240130-pmi632-typec-v3-0-b05fe44f0a51@linaro.org/ > > > > [...] > > Applied, thanks! > > [3/4] arm64: dts: qcom: pm4125: define USB-C related blocks > commit: 46ea59235c4f00bbca6955cf05d7cc0fccde7a64 > [4/4] arm64: dts: qcom: qrb2210-rb1: enable USB-C port handling > (no commit info) This looks worryingly.
On Fri, 2 Feb 2024 at 01:55, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > Reuse Type-C support implemented for the PMI632 PMIC (found on Qualcomm > Robotics RB2 platform) and implement Type-C handling for the Qualcomm > Robotics RB1 platform. > > Dependencies: [1] > > [1] https://lore.kernel.org/linux-arm-msm/20240130-pmi632-typec-v3-0-b05fe44f0a51@linaro.org/ > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Changes in v2: > - Removed unnecessary conditional expansion, covered by existing compat > string (Krzysztof) > - Link to v1: https://lore.kernel.org/r/20240130-pm4125-typec-v1-0-e8d0097e2991@linaro.org > > --- > Dmitry Baryshkov (4): > dt-bindings: regulator: qcom,usb-vbus-regulator: add support for PM4125 > dt-bindings: usb: qcom,pmic-typec: add support for the PM4125 block > arm64: dts: qcom: pm4125: define USB-C related blocks > arm64: dts: qcom: qrb2210-rb1: enable USB-C port handling Mark, Greg, granted that the dependency has landed, could you please pick up patches 1 and 2 correspondingly.
On Wed, Feb 21, 2024 at 12:40:32AM +0200, Dmitry Baryshkov wrote: > > Dmitry Baryshkov (4): > > dt-bindings: regulator: qcom,usb-vbus-regulator: add support for PM4125 > > dt-bindings: usb: qcom,pmic-typec: add support for the PM4125 block > > arm64: dts: qcom: pm4125: define USB-C related blocks > > arm64: dts: qcom: qrb2210-rb1: enable USB-C port handling > Mark, Greg, granted that the dependency has landed, could you please > pick up patches 1 and 2 correspondingly. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing.
On Wed, 21 Feb 2024 at 01:45, Mark Brown <broonie@kernel.org> wrote: > > On Wed, Feb 21, 2024 at 12:40:32AM +0200, Dmitry Baryshkov wrote: > > > Dmitry Baryshkov (4): > > > dt-bindings: regulator: qcom,usb-vbus-regulator: add support for PM4125 > > > dt-bindings: usb: qcom,pmic-typec: add support for the PM4125 block > > > arm64: dts: qcom: pm4125: define USB-C related blocks > > > arm64: dts: qcom: qrb2210-rb1: enable USB-C port handling > > > Mark, Greg, granted that the dependency has landed, could you please > > pick up patches 1 and 2 correspondingly. > > Please submit patches using subject lines reflecting the style for the > subsystem, this makes it easier for people to identify relevant patches. > Look at what existing commits in the area you're changing are doing and > make sure your subject lines visually resemble what they're doing. Ack, excuse me.
Reuse Type-C support implemented for the PMI632 PMIC (found on Qualcomm Robotics RB2 platform) and implement Type-C handling for the Qualcomm Robotics RB1 platform. Dependencies: [1] [1] https://lore.kernel.org/linux-arm-msm/20240130-pmi632-typec-v3-0-b05fe44f0a51@linaro.org/ Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Changes in v2: - Removed unnecessary conditional expansion, covered by existing compat string (Krzysztof) - Link to v1: https://lore.kernel.org/r/20240130-pm4125-typec-v1-0-e8d0097e2991@linaro.org --- Dmitry Baryshkov (4): dt-bindings: regulator: qcom,usb-vbus-regulator: add support for PM4125 dt-bindings: usb: qcom,pmic-typec: add support for the PM4125 block arm64: dts: qcom: pm4125: define USB-C related blocks arm64: dts: qcom: qrb2210-rb1: enable USB-C port handling .../regulator/qcom,usb-vbus-regulator.yaml | 1 + .../devicetree/bindings/usb/qcom,pmic-typec.yaml | 12 +++-- arch/arm64/boot/dts/qcom/pm4125.dtsi | 30 +++++++++++ arch/arm64/boot/dts/qcom/qcm2290.dtsi | 42 +++++++++++++++ arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 60 +++++++++++++++++++--- 5 files changed, 134 insertions(+), 11 deletions(-) --- base-commit: 10fcb85d581e1d7e592a5db0efd45c2954a262b1 change-id: 20240117-pm4125-typec-8800d9c09aec Best regards,