| Message ID | 20240410053712.34747-1-philmd@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | hw/audio/virtio-snd: Remove unused assignment | expand |
On 10/4/24 07:37, Philippe Mathieu-Daudé wrote: > Coverity reported: > > >>> CID 1542933: Code maintainability issues (UNUSED_VALUE) > >>> CID 1542934: Code maintainability issues (UNUSED_VALUE) > >>> Assigning value "NULL" to "stream" here, but that stored > value is overwritten before it can be used. > > Simply remove the unused assignments. > > Resolves: Coverity CID 1542933 > Resolves: Coverity CID 1542934 > Fixes: 731655f87f ("virtio-snd: rewrite invalid tx/rx message handling") > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > hw/audio/virtio-snd.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Per IRC: Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org> Thanks, queued.
diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index 90d9a2796e..c80b58bf5d 100644 --- a/hw/audio/virtio-snd.c +++ b/hw/audio/virtio-snd.c @@ -885,7 +885,9 @@ static void virtio_snd_handle_tx_xfer(VirtIODevice *vdev, VirtQueue *vq) } trace_virtio_snd_handle_tx_xfer(); - for (VirtIOSoundPCMStream *stream = NULL;; stream = NULL) { + for (;;) { + VirtIOSoundPCMStream *stream; + elem = virtqueue_pop(vq, sizeof(VirtQueueElement)); if (!elem) { break; @@ -964,7 +966,9 @@ static void virtio_snd_handle_rx_xfer(VirtIODevice *vdev, VirtQueue *vq) } trace_virtio_snd_handle_rx_xfer(); - for (VirtIOSoundPCMStream *stream = NULL;; stream = NULL) { + for (;;) { + VirtIOSoundPCMStream *stream; + elem = virtqueue_pop(vq, sizeof(VirtQueueElement)); if (!elem) { break;