mbox series

[0/3] ACPI/ALSA/soundwire: add acpi_get_local_u64_address() helper

Message ID 20240528192936.16180-1-pierre-louis.bossart@linux.intel.com
Headers show
Series ACPI/ALSA/soundwire: add acpi_get_local_u64_address() helper | expand

Message

Pierre-Louis Bossart May 28, 2024, 7:29 p.m. UTC
The acpi_get_local_address() helper assumes a 32-bit ADR is used. If
we want to use this helper for SoundWire/SDCA ASoC codecs, we need an
extension where the native 64-bits are used. This patchset suggests a
new helper, acpi_get_local_address() may be renamed if desired in a
folow-up patch.

The path of least resistance would be to merge this patchset in the
ASoC tree, since I have additional changes for ASoC/SDCA (SoundWire
Device Class) that depend on the new helper.

Pierre-Louis Bossart (3):
  ACPI: utils: introduce acpi_get_local_u64_address()
  soundwire: slave: simplify code with acpi_get_local_u64_address()
  ALSA: hda: intel-sdw-acpi: use acpi_get_local_u64_address()

 drivers/acpi/utils.c       | 22 ++++++++++++++++------
 drivers/soundwire/slave.c  | 13 ++++---------
 include/linux/acpi.h       |  1 +
 sound/hda/intel-sdw-acpi.c |  6 +++---
 4 files changed, 24 insertions(+), 18 deletions(-)

Comments

Andy Shevchenko May 30, 2024, 3:14 p.m. UTC | #1
On Tue, May 28, 2024 at 02:29:32PM -0500, Pierre-Louis Bossart wrote:
> The acpi_get_local_address() helper assumes a 32-bit ADR is used. If
> we want to use this helper for SoundWire/SDCA ASoC codecs, we need an
> extension where the native 64-bits are used. This patchset suggests a
> new helper, acpi_get_local_address() may be renamed if desired in a
> folow-up patch.
> 
> The path of least resistance would be to merge this patchset in the
> ASoC tree, since I have additional changes for ASoC/SDCA (SoundWire
> Device Class) that depend on the new helper.

Perhaps we may rename existing one to _u32 or so.
Anyway, for this series:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Mark Brown June 11, 2024, 10:19 a.m. UTC | #2
On Tue, 28 May 2024 14:29:32 -0500, Pierre-Louis Bossart wrote:
> The acpi_get_local_address() helper assumes a 32-bit ADR is used. If
> we want to use this helper for SoundWire/SDCA ASoC codecs, we need an
> extension where the native 64-bits are used. This patchset suggests a
> new helper, acpi_get_local_address() may be renamed if desired in a
> folow-up patch.
> 
> The path of least resistance would be to merge this patchset in the
> ASoC tree, since I have additional changes for ASoC/SDCA (SoundWire
> Device Class) that depend on the new helper.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ACPI: utils: introduce acpi_get_local_u64_address()
      commit: 0b7e448119428e1dcb854abb5855f66966fb82dc
[2/3] soundwire: slave: simplify code with acpi_get_local_u64_address()
      commit: b6212f9bf489daf9716aed0e8c4dc6a807ce839f
[3/3] ALSA: hda: intel-sdw-acpi: use acpi_get_local_u64_address()
      commit: 9b7dc68eeba04d20f4a1733e791bc71355423612

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark