| Message ID | 20240610063924.51154-1-philmd@linaro.org |
|---|---|
| State | Accepted |
| Commit | 4475a9b0585977dcd46e17da1005e1f4569dbf9c |
| Headers | show |
| Series | monitor: Remove obsolete stubs | expand |
On Mon, Jun 10, 2024 at 08:39:24AM +0200, Philippe Mathieu-Daudé wrote: > hmp_info_roms() was removed in commit dd98234c05 ("qapi: > introduce x-query-roms QMP command"), > > hmp_info_numa() in commit 1b8ae799d8 ("qapi: introduce > x-query-numa QMP command"), > > hmp_info_ramblock() in commit ca411b7c8a ("qapi: introduce > x-query-ramblock QMP command") > > and hmp_info_irq() in commit 91f2fa7045 ("qapi: introduce > x-query-irq QMP command"). > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > Note x-query-roms is used as example in > docs/devel/writing-monitor-commands.rst > but was removed in commit dd98234c05 > ("qapi: introduce x-query-roms QMP command"). > --- > include/hw/loader.h | 1 - > include/monitor/hmp.h | 3 --- > 2 files changed, 4 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel
* Philippe Mathieu-Daudé (philmd@linaro.org) wrote: > hmp_info_roms() was removed in commit dd98234c05 ("qapi: > introduce x-query-roms QMP command"), > > hmp_info_numa() in commit 1b8ae799d8 ("qapi: introduce > x-query-numa QMP command"), > > hmp_info_ramblock() in commit ca411b7c8a ("qapi: introduce > x-query-ramblock QMP command") > > and hmp_info_irq() in commit 91f2fa7045 ("qapi: introduce > x-query-irq QMP command"). > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Dr. David Alan Gilbert <dave@treblig.org> > --- > Note x-query-roms is used as example in > docs/devel/writing-monitor-commands.rst > but was removed in commit dd98234c05 > ("qapi: introduce x-query-roms QMP command"). > --- > include/hw/loader.h | 1 - > include/monitor/hmp.h | 3 --- > 2 files changed, 4 deletions(-) > > diff --git a/include/hw/loader.h b/include/hw/loader.h > index 8685e27334..9844c5e3cf 100644 > --- a/include/hw/loader.h > +++ b/include/hw/loader.h > @@ -338,7 +338,6 @@ void *rom_ptr(hwaddr addr, size_t size); > * rom_ptr(). > */ > void *rom_ptr_for_as(AddressSpace *as, hwaddr addr, size_t size); > -void hmp_info_roms(Monitor *mon, const QDict *qdict); > > #define rom_add_file_fixed(_f, _a, _i) \ > rom_add_file(_f, NULL, _a, _i, false, NULL, NULL) > diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h > index 954f3c83ad..ae116d9804 100644 > --- a/include/monitor/hmp.h > +++ b/include/monitor/hmp.h > @@ -35,7 +35,6 @@ void hmp_info_cpus(Monitor *mon, const QDict *qdict); > void hmp_info_vnc(Monitor *mon, const QDict *qdict); > void hmp_info_spice(Monitor *mon, const QDict *qdict); > void hmp_info_balloon(Monitor *mon, const QDict *qdict); > -void hmp_info_irq(Monitor *mon, const QDict *qdict); > void hmp_info_pic(Monitor *mon, const QDict *qdict); > void hmp_info_pci(Monitor *mon, const QDict *qdict); > void hmp_info_tpm(Monitor *mon, const QDict *qdict); > @@ -102,7 +101,6 @@ void hmp_chardev_send_break(Monitor *mon, const QDict *qdict); > void hmp_object_add(Monitor *mon, const QDict *qdict); > void hmp_object_del(Monitor *mon, const QDict *qdict); > void hmp_info_memdev(Monitor *mon, const QDict *qdict); > -void hmp_info_numa(Monitor *mon, const QDict *qdict); > void hmp_info_memory_devices(Monitor *mon, const QDict *qdict); > void hmp_qom_list(Monitor *mon, const QDict *qdict); > void hmp_qom_get(Monitor *mon, const QDict *qdict); > @@ -141,7 +139,6 @@ void hmp_rocker_ports(Monitor *mon, const QDict *qdict); > void hmp_rocker_of_dpa_flows(Monitor *mon, const QDict *qdict); > void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict *qdict); > void hmp_info_dump(Monitor *mon, const QDict *qdict); > -void hmp_info_ramblock(Monitor *mon, const QDict *qdict); > void hmp_hotpluggable_cpus(Monitor *mon, const QDict *qdict); > void hmp_info_vm_generation_id(Monitor *mon, const QDict *qdict); > void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict); > -- > 2.41.0 >
10.06.2024 09:39, Philippe Mathieu-Daudé wrote: > hmp_info_roms() was removed in commit dd98234c05 ("qapi: > introduce x-query-roms QMP command"), > > hmp_info_numa() in commit 1b8ae799d8 ("qapi: introduce > x-query-numa QMP command"), > > hmp_info_ramblock() in commit ca411b7c8a ("qapi: introduce > x-query-ramblock QMP command") > > and hmp_info_irq() in commit 91f2fa7045 ("qapi: introduce > x-query-irq QMP command"). Applied to qemu-trivial, thanks! /mjt
diff --git a/include/hw/loader.h b/include/hw/loader.h index 8685e27334..9844c5e3cf 100644 --- a/include/hw/loader.h +++ b/include/hw/loader.h @@ -338,7 +338,6 @@ void *rom_ptr(hwaddr addr, size_t size); * rom_ptr(). */ void *rom_ptr_for_as(AddressSpace *as, hwaddr addr, size_t size); -void hmp_info_roms(Monitor *mon, const QDict *qdict); #define rom_add_file_fixed(_f, _a, _i) \ rom_add_file(_f, NULL, _a, _i, false, NULL, NULL) diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h index 954f3c83ad..ae116d9804 100644 --- a/include/monitor/hmp.h +++ b/include/monitor/hmp.h @@ -35,7 +35,6 @@ void hmp_info_cpus(Monitor *mon, const QDict *qdict); void hmp_info_vnc(Monitor *mon, const QDict *qdict); void hmp_info_spice(Monitor *mon, const QDict *qdict); void hmp_info_balloon(Monitor *mon, const QDict *qdict); -void hmp_info_irq(Monitor *mon, const QDict *qdict); void hmp_info_pic(Monitor *mon, const QDict *qdict); void hmp_info_pci(Monitor *mon, const QDict *qdict); void hmp_info_tpm(Monitor *mon, const QDict *qdict); @@ -102,7 +101,6 @@ void hmp_chardev_send_break(Monitor *mon, const QDict *qdict); void hmp_object_add(Monitor *mon, const QDict *qdict); void hmp_object_del(Monitor *mon, const QDict *qdict); void hmp_info_memdev(Monitor *mon, const QDict *qdict); -void hmp_info_numa(Monitor *mon, const QDict *qdict); void hmp_info_memory_devices(Monitor *mon, const QDict *qdict); void hmp_qom_list(Monitor *mon, const QDict *qdict); void hmp_qom_get(Monitor *mon, const QDict *qdict); @@ -141,7 +139,6 @@ void hmp_rocker_ports(Monitor *mon, const QDict *qdict); void hmp_rocker_of_dpa_flows(Monitor *mon, const QDict *qdict); void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict *qdict); void hmp_info_dump(Monitor *mon, const QDict *qdict); -void hmp_info_ramblock(Monitor *mon, const QDict *qdict); void hmp_hotpluggable_cpus(Monitor *mon, const QDict *qdict); void hmp_info_vm_generation_id(Monitor *mon, const QDict *qdict); void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict);
hmp_info_roms() was removed in commit dd98234c05 ("qapi: introduce x-query-roms QMP command"), hmp_info_numa() in commit 1b8ae799d8 ("qapi: introduce x-query-numa QMP command"), hmp_info_ramblock() in commit ca411b7c8a ("qapi: introduce x-query-ramblock QMP command") and hmp_info_irq() in commit 91f2fa7045 ("qapi: introduce x-query-irq QMP command"). Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- Note x-query-roms is used as example in docs/devel/writing-monitor-commands.rst but was removed in commit dd98234c05 ("qapi: introduce x-query-roms QMP command"). --- include/hw/loader.h | 1 - include/monitor/hmp.h | 3 --- 2 files changed, 4 deletions(-)