| Message ID | 20240612-lpass-codec-v25-v4-0-f63d3676dbc4@linaro.org |
|---|---|
| Headers | show |
| Series | ASoC: codecs: lpass: add support for v2.5 rx macro | expand |
On 13/06/2024 13:04, Srinivas Kandagatla wrote: > > > On 13/06/2024 12:00, Krzysztof Kozlowski wrote: >> On 13/06/2024 12:49, Srinivas Kandagatla wrote: >>> LPASS Codec v2.5 has significant changes in the rx register strides. >>> Due to this headset playback on SM8550, SM8650, x1e80100 and all SoCs >>> after SM8450 have only Left working. >>> >>> This patch adjusts the registers to accomdate 2.5 changes. With this >>> fixed now L and R are functional on Headset playback. >> >> I was just about to respond, are you sure this is suitable for sm8450? I >> looked now at registers and sm8450 (which should have codec v2.5) has >> old style register layout. >> > from 2.5 the layout has changed, I have verified it on SM8450, with and > without this patch, This fixes the issue one speaker issue. I tested it now on SM8450 and indeed it fixes missing channel playback via headphones. Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Thu, 13 Jun 2024 11:49:30 +0100, Srinivas Kandagatla wrote: > This patchset adds support to reading codec version and also adds > support for v2.5 codec version in rx macro. > > LPASS 2.5 and up versions have changes in some of the rx blocks which > are required to get headset functional correctly. > > Tested this on SM8450, X13s and x1e80100 crd. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/3] ASoC: codecs: lpass-macro: add helpers to get codec version commit: 378918d5918116b95300dd7f03913a1d0841f223 [2/3] ASoC: codec: lpass-rx-macro: prepare driver to accomdate new codec versions commit: dbacef05898d65f586fb9b90ba367e6bf898d68d [3/3] ASoC: codec: lpass-rx-macro: add support for 2.5 codec version commit: 432e5074f805d0f976c7430af376a0dd07f1c6d7 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
This patchset adds support to reading codec version and also adds support for v2.5 codec version in rx macro. LPASS 2.5 and up versions have changes in some of the rx blocks which are required to get headset functional correctly. Tested this on SM8450, X13s and x1e80100 crd. This changes also fixes issue with sm8450, sm8550, sm8660 and x1e80100. @Neil Armstrong can you pl test it on sm8650 @Krzysztof Kozlowski can you pl test it on sm8550 Thanks, Srini Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- Changes in v3: - moved dev_info to dev_dbg to print codec version. - added explicit cases for codec version checks instead of using range - changed err handling. - Link to v1: https://lore.kernel.org/r/20240612-lpass-codec-v25-v1-0-9f40611a1370@linaro.org --- Srinivas Kandagatla (3): ASoC: codecs: lpass-macro: add helpers to get codec version ASoC: codec: lpass-rx-macro: prepare driver to accomdate new codec versions ASoC: codec: lpass-rx-macro: add support for 2.5 codec version sound/soc/codecs/lpass-macro-common.c | 23 ++ sound/soc/codecs/lpass-macro-common.h | 35 ++ sound/soc/codecs/lpass-rx-macro.c | 595 +++++++++++++++++++++++++--------- sound/soc/codecs/lpass-va-macro.c | 28 ++ 4 files changed, 528 insertions(+), 153 deletions(-) --- base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0 change-id: 20240612-lpass-codec-v25-4e960abd661f Best regards,