| Message ID | 20240706074505.9885-1-qasim.majeed20@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Updating a deprecated use of strcpy in ac.c file. | expand |
On Sat, Jul 6, 2024 at 9:48 AM Muhammad Qasim Abdul Majeed <qasim.majeed20@gmail.com> wrote: > > Replacing strcpy with strscpy. > strcpy is a deprecated function. > It should be removed from the kernel source. > > Link: https://github.com/KSPP/linux/issues/88 > > Signed-off-by: Muhammad Qasim Abdul Majeed <qasim.majeed20@gmail.com> > --- > drivers/acpi/ac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c > index 09a87fa222c7..ad1427a384e4 100644 > --- a/drivers/acpi/ac.c > +++ b/drivers/acpi/ac.c > @@ -213,8 +213,8 @@ static int acpi_ac_probe(struct platform_device *pdev) > return -ENOMEM; > > ac->device = adev; > - strcpy(acpi_device_name(adev), ACPI_AC_DEVICE_NAME); > - strcpy(acpi_device_class(adev), ACPI_AC_CLASS); > + strscpy(acpi_device_name(adev), ACPI_AC_DEVICE_NAME); > + strscpy(acpi_device_class(adev), ACPI_AC_CLASS); > > platform_set_drvdata(pdev, ac); > > -- Please see this commit: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=142acc42a7443f377b1a452ce906dc3adec91f70 and format the subjects and changelogs of all of your ACPI patches that replace strcpy() with strscpy() in analogy with it. Thanks!
diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c index 09a87fa222c7..ad1427a384e4 100644 --- a/drivers/acpi/ac.c +++ b/drivers/acpi/ac.c @@ -213,8 +213,8 @@ static int acpi_ac_probe(struct platform_device *pdev) return -ENOMEM; ac->device = adev; - strcpy(acpi_device_name(adev), ACPI_AC_DEVICE_NAME); - strcpy(acpi_device_class(adev), ACPI_AC_CLASS); + strscpy(acpi_device_name(adev), ACPI_AC_DEVICE_NAME); + strscpy(acpi_device_class(adev), ACPI_AC_CLASS); platform_set_drvdata(pdev, ac);
Replacing strcpy with strscpy. strcpy is a deprecated function. It should be removed from the kernel source. Link: https://github.com/KSPP/linux/issues/88 Signed-off-by: Muhammad Qasim Abdul Majeed <qasim.majeed20@gmail.com> --- drivers/acpi/ac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)