mbox series

[0/3] Add VPU support for RK3128

Message ID 20240523185633.71355-1-knaerzche@gmail.com
Headers show
Series Add VPU support for RK3128 | expand

Message

Alex Bee May 23, 2024, 6:56 p.m. UTC
Similar to most Rockchip SoCs RK312x have hantro G1 based decoder and a
hantro H1 based encoder with attached iommu.

The existing drivers can be used as-is.

Fluster scores:
  - FFmpeg:
    - H.264: 127/135
    - VP8:    59/61
  - GStreamer:
    - H.264: 129/135
    - VP8:    59/61

Alex Bee (3):
  dt-bindings: media: rockchip,vpu: Document RK3128 compatible
  soc: rockchip: grf: Set RK3128's vpu main clock
  ARM: dts: rockchip: Add vpu nodes for RK3128

 .../bindings/media/rockchip-vpu.yaml          |  4 +++-
 arch/arm/boot/dts/rockchip/rk3128.dtsi        | 24 +++++++++++++++++++
 drivers/soc/rockchip/grf.c                    |  2 ++
 3 files changed, 29 insertions(+), 1 deletion(-)

Comments

Heiko Stuebner May 28, 2024, 3:09 p.m. UTC | #1
On Thu, 23 May 2024 20:56:30 +0200, Alex Bee wrote:
> Similar to most Rockchip SoCs RK312x have hantro G1 based decoder and a
> hantro H1 based encoder with attached iommu.
> 
> The existing drivers can be used as-is.
> 
> Fluster scores:
>   - FFmpeg:
>     - H.264: 127/135
>     - VP8:    59/61
>   - GStreamer:
>     - H.264: 129/135
>     - VP8:    59/61
> 
> [...]

Applied, thanks!

[2/3] soc: rockchip: grf: Set RK3128's vpu main clock
      commit: b465223129f951d110e633a305085bd8430d7df0

Best regards,
Heiko Stuebner Aug. 1, 2024, 10:36 a.m. UTC | #2
Hey,

Am Dienstag, 28. Mai 2024, 10:37:47 CEST schrieb Sebastian Fricke:
> On 28.05.2024 10:19, Heiko Stübner wrote:
> >Am Donnerstag, 23. Mai 2024, 20:56:31 CEST schrieb Alex Bee:
> >> The integration for this SoC is similar to RK3066/RK3188.
> >>
> >> Document it's compatible.
> >>
> >> Signed-off-by: Alex Bee <knaerzche@gmail.com>
> >
> >Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> >
> >Media people, can you apply this patch alone from the series?
> 
> Yes, will do got this on my list already :).

as I'm going through my list of "waiting for ..." patches,
is this still on the radar?

As far as I can tell, it didn't make it into 6.11-rc1, but 6.12 would be
nice :-)


Thanks a lot
Heiko



> >> ---
> >>  Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 4 +++-
> >>  1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
> >> index c57e1f488895..d1b47b14ca57 100644
> >> --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
> >> +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
> >> @@ -26,7 +26,9 @@ properties:
> >>            - rockchip,rk3568-vpu
> >>            - rockchip,rk3588-av1-vpu
> >>        - items:
> >> -          - const: rockchip,rk3188-vpu
> >> +          - enum:
> >> +              - rockchip,rk3128-vpu
> >> +              - rockchip,rk3188-vpu
> >>            - const: rockchip,rk3066-vpu
> >>        - items:
> >>            - const: rockchip,rk3228-vpu
> >>
> >
> >
> >
> >
> >
>
Alex Bee Aug. 4, 2024, 4:42 p.m. UTC | #3
Hi Heiko

Am 28.05.24 um 17:09 schrieb Heiko Stuebner:
> On Thu, 23 May 2024 20:56:30 +0200, Alex Bee wrote:
>> Similar to most Rockchip SoCs RK312x have hantro G1 based decoder and a
>> hantro H1 based encoder with attached iommu.
>>
>> The existing drivers can be used as-is.
>>
>> Fluster scores:
>>    - FFmpeg:
>>      - H.264: 127/135
>>      - VP8:    59/61
>>    - GStreamer:
>>      - H.264: 129/135
>>      - VP8:    59/61
>>
>> [...]
> Applied, thanks!
>
> [2/3] soc: rockchip: grf: Set RK3128's vpu main clock
>        commit: b465223129f951d110e633a305085bd8430d7df0
I just noticed this patch didn't make it in 6.11-rc1. While it's not really
important for this patch as the media mainainters didn't manage to apply
the vpu bindings patch for 6.11 anyways, it looks like all commits of your
v6.11-armsoc/drivers aren't merged. I still haven't fully understand how
the SoC tree *really* works, but I couldn't find a PR for this branch [0].

Alex

[0]
https://patchwork.kernel.org/project/linux-soc/list/?submitter=24481&state=*
> Best regards,