| Message ID | 20240812134752.28031-1-quic_vnagar@quicinc.com |
|---|---|
| State | Accepted |
| Commit | d628455ab3c22bf633935f5d09451530c44c4ba3 |
| Headers | show |
| Series | clk: qcom: videocc-sm8550: Use HW_CTRL_TRIGGER flag for video GDSC's | expand |
On 12/08/2024 15:47, Vedang Nagar wrote: > The video driver will be using the newly introduced > dev_pm_genpd_set_hwmode() API to switch the video GDSC > to HW/SW control modes at runtime. > Hence use HW_CTRL_TRIGGER flag instead of HW_CTRL for > video GDSC's. > > Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com> > --- > drivers/clk/qcom/videocc-sm8550.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/qcom/videocc-sm8550.c b/drivers/clk/qcom/videocc-sm8550.c > index 97d150b132a6..7c25a50cfa97 100644 > --- a/drivers/clk/qcom/videocc-sm8550.c > +++ b/drivers/clk/qcom/videocc-sm8550.c > @@ -449,7 +449,7 @@ static struct gdsc video_cc_mvs0_gdsc = { > }, > .pwrsts = PWRSTS_OFF_ON, > .parent = &video_cc_mvs0c_gdsc.pd, > - .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE | HW_CTRL, > + .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE | HW_CTRL_TRIGGER, > }; > > static struct gdsc video_cc_mvs1c_gdsc = { > @@ -474,7 +474,7 @@ static struct gdsc video_cc_mvs1_gdsc = { > }, > .pwrsts = PWRSTS_OFF_ON, > .parent = &video_cc_mvs1c_gdsc.pd, > - .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE | HW_CTRL, > + .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE | HW_CTRL_TRIGGER, > }; > > static struct clk_regmap *video_cc_sm8550_clocks[] = { Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On Mon, 12 Aug 2024 19:17:52 +0530, Vedang Nagar wrote: > The video driver will be using the newly introduced > dev_pm_genpd_set_hwmode() API to switch the video GDSC > to HW/SW control modes at runtime. > Hence use HW_CTRL_TRIGGER flag instead of HW_CTRL for > video GDSC's. > > > [...] Applied, thanks! [1/1] clk: qcom: videocc-sm8550: Use HW_CTRL_TRIGGER flag for video GDSC's commit: d628455ab3c22bf633935f5d09451530c44c4ba3 Best regards,
diff --git a/drivers/clk/qcom/videocc-sm8550.c b/drivers/clk/qcom/videocc-sm8550.c index 97d150b132a6..7c25a50cfa97 100644 --- a/drivers/clk/qcom/videocc-sm8550.c +++ b/drivers/clk/qcom/videocc-sm8550.c @@ -449,7 +449,7 @@ static struct gdsc video_cc_mvs0_gdsc = { }, .pwrsts = PWRSTS_OFF_ON, .parent = &video_cc_mvs0c_gdsc.pd, - .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE | HW_CTRL, + .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE | HW_CTRL_TRIGGER, }; static struct gdsc video_cc_mvs1c_gdsc = { @@ -474,7 +474,7 @@ static struct gdsc video_cc_mvs1_gdsc = { }, .pwrsts = PWRSTS_OFF_ON, .parent = &video_cc_mvs1c_gdsc.pd, - .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE | HW_CTRL, + .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE | HW_CTRL_TRIGGER, }; static struct clk_regmap *video_cc_sm8550_clocks[] = {
The video driver will be using the newly introduced dev_pm_genpd_set_hwmode() API to switch the video GDSC to HW/SW control modes at runtime. Hence use HW_CTRL_TRIGGER flag instead of HW_CTRL for video GDSC's. Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com> --- drivers/clk/qcom/videocc-sm8550.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)