mbox series

[v2,0/3] tests/unit: Slightly expand FIFO8 tests

Message ID 20240906132909.78886-1-philmd@linaro.org
Headers show
Series tests/unit: Slightly expand FIFO8 tests | expand

Message

Philippe Mathieu-Daudé Sept. 6, 2024, 1:29 p.m. UTC
Since v1:
- Correctly place patch hunks in corresponding patch

Mostly add documentation while reviewing them.

Based-on: <20240828122258.928947-1-mark.cave-ayland@ilande.co.uk>

Philippe Mathieu-Daudé (3):
  tests/unit: Strengthen FIFO8 tests
  tests/unit: Expand test_fifo8_peek_buf_wrap() coverage
  tests/unit: Comment FIFO8 tests

 tests/unit/test-fifo.c | 209 +++++++++++++++++++++++++++++++++++++++--
 1 file changed, 201 insertions(+), 8 deletions(-)

Comments

Mark Cave-Ayland Sept. 6, 2024, 9:11 p.m. UTC | #1
On 06/09/2024 14:29, Philippe Mathieu-Daudé wrote:

> Since v1:
> - Correctly place patch hunks in corresponding patch
> 
> Mostly add documentation while reviewing them.
> 
> Based-on: <20240828122258.928947-1-mark.cave-ayland@ilande.co.uk>
> 
> Philippe Mathieu-Daudé (3):
>    tests/unit: Strengthen FIFO8 tests
>    tests/unit: Expand test_fifo8_peek_buf_wrap() coverage
>    tests/unit: Comment FIFO8 tests
> 
>   tests/unit/test-fifo.c | 209 +++++++++++++++++++++++++++++++++++++++--
>   1 file changed, 201 insertions(+), 8 deletions(-)

This is great! Thanks for taking the time to review the Fifo8 patches in enough 
detail to be able to produce the ASCII art :)


ATB,

Mark.
Philippe Mathieu-Daudé Sept. 7, 2024, 5:17 a.m. UTC | #2
On 6/9/24 23:11, Mark Cave-Ayland wrote:

>> Philippe Mathieu-Daudé (3):
>>    tests/unit: Strengthen FIFO8 tests
>>    tests/unit: Expand test_fifo8_peek_buf_wrap() coverage
>>    tests/unit: Comment FIFO8 tests
>>
>>   tests/unit/test-fifo.c | 209 +++++++++++++++++++++++++++++++++++++++--
>>   1 file changed, 201 insertions(+), 8 deletions(-)
> 
> This is great! Thanks for taking the time to review the Fifo8 patches in 
> enough detail to be able to produce the ASCII art :)

Series queued, thanks!