mbox series

[v2,0/5] tmp105: Improvements and fixes

Message ID 20240906154911.86803-1-philmd@linaro.org
Headers show
Series tmp105: Improvements and fixes | expand

Message

Philippe Mathieu-Daudé Sept. 6, 2024, 3:49 p.m. UTC 
Respin of Guenter fixes with:
- Use registerfields API
- Clear OS bit in WRITE path

Supersedes: <20240906132912.3826089-1-linux@roeck-us.net>

Guenter Roeck (2):
  hw/sensor/tmp105: Coding style fixes
  hw/sensor/tmp105: Lower 4 bit of limit registers are always 0

Philippe Mathieu-Daudé (3):
  hw/sensor/tmp105: Use registerfields API
  hw/sensor/tmp105: Pass 'oneshot' argument to tmp105_alarm_update()
  hw/sensor/tmp105: OS (one-shot) bit in config register always returns
    0

 hw/sensor/tmp105.c | 66 ++++++++++++++++++++++++++--------------------
 1 file changed, 37 insertions(+), 29 deletions(-)

Comments

Philippe Mathieu-Daudé Sept. 9, 2024, 1:27 p.m. UTC | #1 
Hi Cédric,

On 6/9/24 17:49, Philippe Mathieu-Daudé wrote:
> Respin of Guenter fixes with:
> - Use registerfields API
> - Clear OS bit in WRITE path

Since our mails crossed (you reviewed v1 while I was
posting v2), do you mind having another look at this
v2? At least patch #4 isn't yet reviewed.

Thanks,

Phil.

> Supersedes: <20240906132912.3826089-1-linux@roeck-us.net>
> 
> Guenter Roeck (2):
>    hw/sensor/tmp105: Coding style fixes
>    hw/sensor/tmp105: Lower 4 bit of limit registers are always 0
> 
> Philippe Mathieu-Daudé (3):
>    hw/sensor/tmp105: Use registerfields API
>    hw/sensor/tmp105: Pass 'oneshot' argument to tmp105_alarm_update()
>    hw/sensor/tmp105: OS (one-shot) bit in config register always returns
>      0
> 
>   hw/sensor/tmp105.c | 66 ++++++++++++++++++++++++++--------------------
>   1 file changed, 37 insertions(+), 29 deletions(-)
>
Philippe Mathieu-Daudé Sept. 12, 2024, 6:50 a.m. UTC | #2 
On 6/9/24 17:49, Philippe Mathieu-Daudé wrote:
> Respin of Guenter fixes with:
> - Use registerfields API
> - Clear OS bit in WRITE path
> 
> Supersedes: <20240906132912.3826089-1-linux@roeck-us.net>
> 
> Guenter Roeck (2):
>    hw/sensor/tmp105: Coding style fixes
>    hw/sensor/tmp105: Lower 4 bit of limit registers are always 0
> 
> Philippe Mathieu-Daudé (3):
>    hw/sensor/tmp105: Use registerfields API
>    hw/sensor/tmp105: Pass 'oneshot' argument to tmp105_alarm_update()
>    hw/sensor/tmp105: OS (one-shot) bit in config register always returns
>      0

Series queued, thanks!