Message ID | 20240917215728.50342-1-dg@cowlark.com |
---|---|
State | New |
Headers | show |
Series | [v2,1/2] media: add support for the D3DFMT_R5G6B5 pixmap type | expand |
Hi David The CI is still a bit unhappy :) On Tue, 17 Sept 2024 at 23:57, David Given <dg@cowlark.com> wrote: > > This media format is used by the NXP Semiconductors 1fc9:009b chipset, > used by the Kaiweets KTI-W02 infrared camera. > You are missing a Signed-off-by: tag here. git will create it for you if you use "git commit -s" WARNING: ./0001-media-add-support-for-the-D3DFMT_R5G6B5-pixmap-type.patch: Missing author David Given <dg@cowlark.com> Signed-off-by https://gitlab.freedesktop.org/linux-media/users/patchwork/-/jobs/63726387 > --- > drivers/media/common/uvc.c | 4 ++++ > include/linux/usb/uvc.h | 3 +++ > 2 files changed, 7 insertions(+) > > diff --git a/drivers/media/common/uvc.c b/drivers/media/common/uvc.c > index c54c2268f..c12d58932 100644 > --- a/drivers/media/common/uvc.c > +++ b/drivers/media/common/uvc.c > @@ -96,6 +96,10 @@ static const struct uvc_format_desc uvc_fmts[] = { > .guid = UVC_GUID_FORMAT_RGBP, > .fcc = V4L2_PIX_FMT_RGB565, > }, > + { > + .guid = UVC_GUID_FORMAT_D3DFMT_R5G6B5, > + .fcc = V4L2_PIX_FMT_RGB565, > + }, > { > .guid = UVC_GUID_FORMAT_BGR3, > .fcc = V4L2_PIX_FMT_BGR24, > diff --git a/include/linux/usb/uvc.h b/include/linux/usb/uvc.h > index 88d96095b..01c3b2f45 100644 > --- a/include/linux/usb/uvc.h > +++ b/include/linux/usb/uvc.h > @@ -140,6 +140,9 @@ > #define UVC_GUID_FORMAT_D3DFMT_L8 \ > {0x32, 0x00, 0x00, 0x00, 0x00, 0x00, 0x10, 0x00, \ > 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} > +#define UVC_GUID_FORMAT_D3DFMT_R5G6B5 \ > + {0x7b, 0xeb, 0x36, 0xe4, 0x4f, 0x52, 0xce, 0x11, \ > + 0x9f, 0x53, 0x00, 0x20, 0xaf, 0x0b, 0xa7, 0x70} > #define UVC_GUID_FORMAT_KSMEDIA_L8_IR \ > {0x32, 0x00, 0x00, 0x00, 0x02, 0x00, 0x10, 0x00, \ > 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} > -- > 2.45.2 > >
Hi David On Wed, 18 Sept 2024 at 20:08, David Given <dg@cowlark.com> wrote: > > On Wed, 18 Sept 2024 at 06:07, Ricardo Ribalda <ribalda@chromium.org> wrote: > [...] > > ERROR: trailing whitespace > > 38#213: FILE: drivers/media/usb/uvc/uvc_driver.c:2431: > > 39+ * $ > > Fixed. > > > You can run checkpatch on your patches before sending them to test them locally. > > > > ./scripts/checkpatch --strict -g HEAD > > I actually had, and it said they were fine! Turns out I'd put the > Signed-off-by in the wrong place, and checkpatch clearly just looks > for its presence while the linter on the CI server is stricter. (I'm > not a git user, and am having to do a lot of this stuff manually.) > > The last time I touched the Linux kernel was in the late 1990s. There > wasn't any process back then. np :) thanks for the new version. It can be annoying I know :S
diff --git a/drivers/media/common/uvc.c b/drivers/media/common/uvc.c index c54c2268f..c12d58932 100644 --- a/drivers/media/common/uvc.c +++ b/drivers/media/common/uvc.c @@ -96,6 +96,10 @@ static const struct uvc_format_desc uvc_fmts[] = { .guid = UVC_GUID_FORMAT_RGBP, .fcc = V4L2_PIX_FMT_RGB565, }, + { + .guid = UVC_GUID_FORMAT_D3DFMT_R5G6B5, + .fcc = V4L2_PIX_FMT_RGB565, + }, { .guid = UVC_GUID_FORMAT_BGR3, .fcc = V4L2_PIX_FMT_BGR24, diff --git a/include/linux/usb/uvc.h b/include/linux/usb/uvc.h index 88d96095b..01c3b2f45 100644 --- a/include/linux/usb/uvc.h +++ b/include/linux/usb/uvc.h @@ -140,6 +140,9 @@ #define UVC_GUID_FORMAT_D3DFMT_L8 \ {0x32, 0x00, 0x00, 0x00, 0x00, 0x00, 0x10, 0x00, \ 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} +#define UVC_GUID_FORMAT_D3DFMT_R5G6B5 \ + {0x7b, 0xeb, 0x36, 0xe4, 0x4f, 0x52, 0xce, 0x11, \ + 0x9f, 0x53, 0x00, 0x20, 0xaf, 0x0b, 0xa7, 0x70} #define UVC_GUID_FORMAT_KSMEDIA_L8_IR \ {0x32, 0x00, 0x00, 0x00, 0x02, 0x00, 0x10, 0x00, \ 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}