| Message ID | e9b15613a81129ceecb07ec51f71bbe75425ad2e.1728558223.git.daniel@makrotopia.org |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next,v2,1/5] dt-bindings: leds: add 'active-high' property | expand |
On Thu, Oct 10, 2024 at 01:54:19PM +0100, Daniel Golle wrote: > In addition to 'active-low' and 'inactive-high-impedance' also > support 'active-high' property for PHY LED pin configuration. > As only either 'active-high' or 'active-low' can be set at the > same time, WARN and return an error in case both are set. > > Signed-off-by: Daniel Golle <daniel@makrotopia.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Thu, 10 Oct 2024 13:53:36 +0100 Daniel Golle wrote: > Other than described in commit c94d1783136e ("dt-bindings: net: phy: > Make LED active-low property common") the absence of the 'active-low' > property means not to touch the polarity settings which are inherited > from reset defaults, the bootloader or bootstrap configuration. Hence, > in order to override a LED pin being active-high in case of the default, > bootloader or bootstrap setting being active-low an additional property > 'active-high' is required. Document that property and make it mutually > exclusive to the existing 'active-low' property. Daniel, please make sure you provide a cover letter for any submissions longer than 2 patches. If nothing else it gives the maintainers a quick overview of which files you're touching. This submission is okay but please correct going forward. Let's wait a bit longer for Lee to ack / take the first patch and then I presume we take the rest.
On Thu, 10 Oct 2024 13:53:36 +0100, Daniel Golle wrote: > Other than described in commit c94d1783136e ("dt-bindings: net: phy: > Make LED active-low property common") the absence of the 'active-low' > property means not to touch the polarity settings which are inherited > from reset defaults, the bootloader or bootstrap configuration. Hence, > in order to override a LED pin being active-high in case of the default, > bootloader or bootstrap setting being active-low an additional property > 'active-high' is required. Document that property and make it mutually > exclusive to the existing 'active-low' property. > > [...] Applied, thanks! [1/5] dt-bindings: leds: add 'active-high' property commit: fcaade450ea25e0162ee4a28ac0c7b911fa25674 -- Lee Jones [李琼斯]
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Thu, 10 Oct 2024 13:53:36 +0100 you wrote: > Other than described in commit c94d1783136e ("dt-bindings: net: phy: > Make LED active-low property common") the absence of the 'active-low' > property means not to touch the polarity settings which are inherited > from reset defaults, the bootloader or bootstrap configuration. Hence, > in order to override a LED pin being active-high in case of the default, > bootloader or bootstrap setting being active-low an additional property > 'active-high' is required. Document that property and make it mutually > exclusive to the existing 'active-low' property. > > [...] Here is the summary with links: - [net-next,v2,1/5] dt-bindings: leds: add 'active-high' property (no matching commit) - [net-next,v2,2/5] net: phy: support 'active-high' property for PHY LEDs https://git.kernel.org/netdev/net-next/c/a274465cc3be - [net-next,v2,3/5] net: phy: aquantia: correctly describe LED polarity override https://git.kernel.org/netdev/net-next/c/9d55e68b19f2 - [net-next,v2,4/5] net: phy: mxl-gpy: correctly describe LED polarity https://git.kernel.org/netdev/net-next/c/eb89c79c1b8f - [net-next,v2,5/5] net: phy: intel-xway: add support for PHY LEDs https://git.kernel.org/netdev/net-next/c/1758af47b98c You are awesome, thank you!
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml index bf9a101e4d42..7c3cd7b7412e 100644 --- a/Documentation/devicetree/bindings/leds/common.yaml +++ b/Documentation/devicetree/bindings/leds/common.yaml @@ -202,6 +202,12 @@ properties: #trigger-source-cells property in the source node. $ref: /schemas/types.yaml#/definitions/phandle-array + active-high: + type: boolean + description: + Makes LED active high. To turn the LED ON, line needs to be + set to high voltage instead of low. + active-low: type: boolean description: @@ -225,6 +231,14 @@ properties: Maximum timeout in microseconds after which the flash LED is turned off. Required for flash LED nodes with configurable timeout. +allOf: + - if: + required: + - active-low + then: + properties: + active-high: false + additionalProperties: true examples:
Other than described in commit c94d1783136e ("dt-bindings: net: phy: Make LED active-low property common") the absence of the 'active-low' property means not to touch the polarity settings which are inherited from reset defaults, the bootloader or bootstrap configuration. Hence, in order to override a LED pin being active-high in case of the default, bootloader or bootstrap setting being active-low an additional property 'active-high' is required. Document that property and make it mutually exclusive to the existing 'active-low' property. Signed-off-by: Daniel Golle <daniel@makrotopia.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- v2: fix commit sha truncation in commit message Documentation/devicetree/bindings/leds/common.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+)