mbox series

[v2,0/3] media: mt9p031: Drop legacy platform data

Message ID 20241028204443.22426-1-laurent.pinchart@ideasonboard.com
Headers show
Series media: mt9p031: Drop legacy platform data | expand

Message

Laurent Pinchart Oct. 28, 2024, 8:44 p.m. UTC 
Hello,

This small series drops support for legacy platform data from the mt9p031
driver. Patch 1/3 removes support for platform data as it has not been
used for a long time, and patch 2/3 follows by dropping the then
unneeded I2C device ID table. Patch 3/3 is new in this version and
switches from the OF API to the fwnode API, making the driver usable on
non-OF platforms.

I can't easily test the series at the moment. Would anyone know of an
MT9P031 camera module available off-the-shelf with a Raspberry
Pi-compatible connector ?

Tarang, would you be able to test the series ? I would like to make sure
patch 3/3 doesn't break anything.

Laurent Pinchart (3):
  media: i2c: mt9p031: Drop support for legacy platform data
  media: i2c: mt9p031: Drop I2C device ID table
  media: i2c: mt9p031: Switch from OF to fwnode API

 MAINTAINERS                 |  1 -
 drivers/media/i2c/mt9p031.c | 82 +++++++++++++++----------------------
 include/media/i2c/mt9p031.h | 18 --------
 3 files changed, 32 insertions(+), 69 deletions(-)
 delete mode 100644 include/media/i2c/mt9p031.h


base-commit: d020ca11a816a99f87f2d186e137a9fb2341adb3

Comments

Laurent Pinchart Oct. 28, 2024, 9:42 p.m. UTC | #1 
On Mon, Oct 28, 2024 at 01:50:18PM -0700, Patchwork Integration wrote:
> Dear Laurent Pinchart:
> 
> Thanks for your patches! Unfortunately media-ci has not been able to
> test them.
> 
> Make sure that the whole series <20241028204443.22426-2-laurent.pinchart@ideasonboard.com> is
> available at lore. And that it can be cherry-picked on top the "next"
> branch of "https://gitlab.freedesktop.org/linux-media/media-committers.git".
> 
> Best regards, and Happy Hacking!
> Media CI robot out on behalf of the linux-media community.
> 
> ---
> Check the latest rules for contributing your patches at:
> https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
> 
> If you believe that the CI is wrong, kindly open an issue at
> https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
> to this message.

The series is based on top of the next branch.

$ git switch -c tmp fdo/next
branch 'tmp' set up to track 'fdo/next'.
Switched to a new branch 'tmp'
$ b4 shazam 20241028204443.22426-2-laurent.pinchart@ideasonboard.com
Grabbing thread from lore.kernel.org/all/20241028204443.22426-2-laurent.pinchart@ideasonboard.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 4 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Analyzing 7 code-review messages
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH v2 1/3] media: i2c: mt9p031: Drop support for legacy platform data
  ✓ [PATCH v2 2/3] media: i2c: mt9p031: Drop I2C device ID table
  ✓ [PATCH v2 3/3] media: i2c: mt9p031: Switch from OF to fwnode API
  ---
  ✓ Signed: DKIM/ideasonboard.com
---
Total patches: 3
---
NOTE: some trailers ignored due to from/email mismatches:
    ! Trailer: Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
     Msg From: Tarang Raval <tarang.raval@siliconsignals.io>
NOTE: Rerun with -S to apply them anyway
---
 Base: using specified base-commit d020ca11a816a99f87f2d186e137a9fb2341adb3
Applying: media: i2c: mt9p031: Drop support for legacy platform data
Applying: media: i2c: mt9p031: Drop I2C device ID table
Applying: media: i2c: mt9p031: Switch from OF to fwnode API


The trailer warning is weird, I don't see any message in the thread from
Tarang, I wonder if it could be a bug in b4. The "Analyzing 7
code-review messages" message hints at that.
Tarang Raval Oct. 29, 2024, 4:31 a.m. UTC | #2 
Hi Laurent,

>This small series drops support for legacy platform data from the mt9p031
>driver. Patch 1/3 removes support for platform data as it has not been
>used for a long time, and patch 2/3 follows by dropping the then
>unneeded I2C device ID table. Patch 3/3 is new in this version and
>switches from the OF API to the fwnode API, making the driver usable on
>non-OF platforms.
>
>I can't easily test the series at the moment. Would anyone know of an
>MT9P031 camera module available off-the-shelf with a Raspberry
>Pi-compatible connector ?
>
>Tarang, would you be able to test the series ? I would like to make sure
>patch 3/3 doesn't break anything.

Sorry, I have no MT9P031 camera availability

Best Regards,
Tarang
Ricardo Ribalda Oct. 29, 2024, 6:17 a.m. UTC | #3 
Hi Laurent

b4 failed to fetch the messages.

Seems like an one-of error.

Thanks for the report!

Oct 28 20:50:04
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]: Grabbing thread from
lore.kernel.org/all/20241028204443.22426-1-laurent.pinchart@ideasonboard.com/t.mbox.gz
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]: Checking for newer revisions
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]: Grabbing search results from lore.kernel.org
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]: Server returned an error: 500
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]: Analyzing 4 messages in the thread
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]: Looking for additional code-review trailers on
lore.kernel.org
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]: Traceback (most recent call last):
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:   File
"/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 704,
in urlopen
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:     httplib_response = self._make_request(
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:                        ^^^^^^^^^^^^^^^^^^^
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:   File
"/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 387,
in _make_request
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:     self._validate_conn(conn)
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:   File
"/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 1045,
in _validate_conn
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:     conn.connect()
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:   File
"/usr/lib/python3/dist-packages/urllib3/connection.py", line 414, in
connect
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:     self.sock = ssl_wrap_socket(
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:                 ^^^^^^^^^^^^^^^^
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:   File
"/usr/lib/python3/dist-packages/urllib3/util/ssl_.py", line 449, in
ssl_wrap_socket
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:     ssl_sock = _ssl_wrap_socket_impl(
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:                ^^^^^^^^^^^^^^^^^^^^^^
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:   File
"/usr/lib/python3/dist-packages/urllib3/util/ssl_.py", line 493, in
_ssl_wrap_socket_impl
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:     return ssl_context.wrap_socket(sock,
server_hostname=server_hostname)
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:   File "/usr/lib/python3.11/ssl.py", line 517, in
wrap_socket
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:     return self.sslsocket_class._create(
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:   File "/usr/lib/python3.11/ssl.py", line 1108, in
_create
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:     self.do_handshake()
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:   File "/usr/lib/python3.11/ssl.py", line 1379, in
do_handshake
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:     self._sslobj.do_handshake()
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]: ssl.SSLZeroReturnError: TLS/SSL connection has been
closed (EOF) (_ssl.c:992)
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]: During handling of the above exception, another
exception occurred:
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]: Traceback (most recent call last):
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:   File
"/usr/lib/python3/dist-packages/requests/adapters.py", line 489, in
send
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:     resp = conn.urlopen(
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:            ^^^^^^^^^^^^^
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:   File
"/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 788,
in urlopen
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:     retries = retries.increment(
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:               ^^^^^^^^^^^^^^^^^^
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:   File
"/usr/lib/python3/dist-packages/urllib3/util/retry.py", line 592, in
increment
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:     raise MaxRetryError(_pool, url, error or
ResponseError(cause))
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]: urllib3.exceptions.MaxRetryError:
HTTPSConnectionPool(host='lore.kernel.org', port=443): Max retries
exceeded with url: /all/?x=m&q=patchid%3A2ab53db6ea91>
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]: During handling of the above exception, another
exception occurred:
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]: Traceback (most recent call last):
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:   File "/usr/bin/b4", line 8, in <module>
Oct 28 20:50:16
gitlab-scheduler.us-central1-a.c.linux-media-ci.internal
python3[304466]:     sys.exit(cmd())


On Mon, 28 Oct 2024 at 22:43, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> On Mon, Oct 28, 2024 at 01:50:18PM -0700, Patchwork Integration wrote:
> > Dear Laurent Pinchart:
> >
> > Thanks for your patches! Unfortunately media-ci has not been able to
> > test them.
> >
> > Make sure that the whole series <20241028204443.22426-2-laurent.pinchart@ideasonboard.com> is
> > available at lore. And that it can be cherry-picked on top the "next"
> > branch of "https://gitlab.freedesktop.org/linux-media/media-committers.git".
> >
> > Best regards, and Happy Hacking!
> > Media CI robot out on behalf of the linux-media community.
> >
> > ---
> > Check the latest rules for contributing your patches at:
> > https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
> >
> > If you believe that the CI is wrong, kindly open an issue at
> > https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
> > to this message.
>
> The series is based on top of the next branch.
>
> $ git switch -c tmp fdo/next
> branch 'tmp' set up to track 'fdo/next'.
> Switched to a new branch 'tmp'
> $ b4 shazam 20241028204443.22426-2-laurent.pinchart@ideasonboard.com
> Grabbing thread from lore.kernel.org/all/20241028204443.22426-2-laurent.pinchart@ideasonboard.com/t.mbox.gz
> Checking for newer revisions
> Grabbing search results from lore.kernel.org
> Analyzing 4 messages in the thread
> Looking for additional code-review trailers on lore.kernel.org
> Analyzing 7 code-review messages
> Checking attestation on all messages, may take a moment...
> ---
>   ✓ [PATCH v2 1/3] media: i2c: mt9p031: Drop support for legacy platform data
>   ✓ [PATCH v2 2/3] media: i2c: mt9p031: Drop I2C device ID table
>   ✓ [PATCH v2 3/3] media: i2c: mt9p031: Switch from OF to fwnode API
>   ---
>   ✓ Signed: DKIM/ideasonboard.com
> ---
> Total patches: 3
> ---
> NOTE: some trailers ignored due to from/email mismatches:
>     ! Trailer: Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>      Msg From: Tarang Raval <tarang.raval@siliconsignals.io>
> NOTE: Rerun with -S to apply them anyway
> ---
>  Base: using specified base-commit d020ca11a816a99f87f2d186e137a9fb2341adb3
> Applying: media: i2c: mt9p031: Drop support for legacy platform data
> Applying: media: i2c: mt9p031: Drop I2C device ID table
> Applying: media: i2c: mt9p031: Switch from OF to fwnode API
>
>
> The trailer warning is weird, I don't see any message in the thread from
> Tarang, I wonder if it could be a bug in b4. The "Analyzing 7
> code-review messages" message hints at that.
>
> --
> Regards,
>
> Laurent Pinchart



--
Ricardo Ribalda