mbox series

[v5,0/4] net: stmmac: dwc-qos: Add FSD EQoS support

Message ID 20250128102558.22459-1-swathi.ks@samsung.com
Headers show
Series net: stmmac: dwc-qos: Add FSD EQoS support | expand

Message

Swathi K S Jan. 28, 2025, 10:25 a.m. UTC 
FSD platform has two instances of EQoS IP, one is in FSYS0 block and
another one is in PERIC block. This patch series add required DT binding,
DT file modifications and platform driver specific changes for the same.

Changes since v4:
1. Avoided switching between internal and external clocks for every open/
close.
2. Addressed the review comments on DT bindings

Here is the link to v4 patches for reference:
https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=&submitter=211782&state=&q=&archive=true&delegate=

Swathi K S (4):
  dt-bindings: net: Add FSD EQoS device tree bindings
  net: stmmac: dwc-qos: Add FSD EQoS support
  arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC
  arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC

 .../devicetree/bindings/net/snps,dwmac.yaml   |   5 +-
 .../bindings/net/tesla,fsd-ethqos.yaml        |  91 ++++++++++++++
 arch/arm64/boot/dts/tesla/fsd-evb.dts         |  18 +++
 arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi    | 112 ++++++++++++++++++
 arch/arm64/boot/dts/tesla/fsd.dtsi            |  47 ++++++++
 .../stmicro/stmmac/dwmac-dwc-qos-eth.c        |  74 ++++++++++++
 6 files changed, 345 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml

Comments

Russell King (Oracle) Jan. 28, 2025, 2:59 p.m. UTC | #1 
On Tue, Jan 28, 2025 at 03:55:56PM +0530, Swathi K S wrote:
> +struct fsd_eqos_plat_data {
> +	struct clk_bulk_data *clks;
> +	int num_clks;
> +	struct device *dev;

You only write to this, so it serves no purpose in this patch. Please
remove.

Thanks.
Swathi K S Jan. 29, 2025, 9:20 a.m. UTC | #2 
> -----Original Message-----
> From: Russell King (Oracle) <linux@armlinux.org.uk>
> Sent: 28 January 2025 20:30
> To: Swathi K S <swathi.ks@samsung.com>
> Cc: krzk@kernel.org; robh@kernel.org; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> conor+dt@kernel.org; richardcochran@gmail.com;
> mcoquelin.stm32@gmail.com; andrew@lunn.ch; alim.akhtar@samsung.com;
> linux-fsd@tesla.com; netdev@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com;
> linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org;
> alexandre.torgue@foss.st.com; peppe.cavallaro@st.com;
> joabreu@synopsys.com; rcsekar@samsung.com; ssiddha@tesla.com;
> jayati.sahu@samsung.com; pankaj.dubey@samsung.com;
> ravi.patel@samsung.com; gost.dev@samsung.com
> Subject: Re: [PATCH v5 2/4] net: stmmac: dwc-qos: Add FSD EQoS support
> 
> On Tue, Jan 28, 2025 at 03:55:56PM +0530, Swathi K S wrote:
> > +struct fsd_eqos_plat_data {
> > +	struct clk_bulk_data *clks;
> > +	int num_clks;
> > +	struct device *dev;
> 
> You only write to this, so it serves no purpose in this patch. Please
remove.

Hi Russell, 
Thanks for reviewing.
Will remove  struct device *dev from struct fsd_eqos_plat_data

-Swathi

> 
> Thanks.
> 
> --
> RMK's Patch system: https://protect2.fireeye.com/v1/url?k=8378c0b8-
> e2f3d582-83794bf7-74fe4860008a-3788c416dc857e61&q=1&e=4d22ed29-
> 449b-46e6-90ba-
> 9b1470e01ecb&u=https%3A%2F%2Fwww.armlinux.org.uk%2Fdeveloper%2F
> patches%2F
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Krzysztof Kozlowski Feb. 4, 2025, 8:40 a.m. UTC | #3 
On 28/01/2025 11:25, Swathi K S wrote:
> FSD platform has two instances of EQoS IP, one is in FSYS0 block and
> another one is in PERIC block. This patch series add required DT binding,
> DT file modifications and platform driver specific changes for the same.
> 
> Changes since v4:
> 1. Avoided switching between internal and external clocks for every open/
> close.
> 2. Addressed the review comments on DT bindings
> 
> Here is the link to v4 patches for reference:
> https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=&submitter=211782&state=&q=&archive=true&delegate=
> 
> Swathi K S (4):
>   dt-bindings: net: Add FSD EQoS device tree bindings
>   net: stmmac: dwc-qos: Add FSD EQoS support
>   arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC
>   arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC

In next versions, please split DTS from net and send it separately with
*lore* link to the posting of bindings.

Best regards,
Krzysztof