| Message ID | 20250404221225.1596324-1-edliaw@google.com |
|---|---|
| State | New |
| Headers | show |
| Series | selftests/futex: futex_waitv wouldblock test should fail | expand |
On Fri, Apr 04 2025 at 22:12, Edward Liaw wrote: > Testcase should fail if -EWOULDBLOCK is not returned when expected value > differs from actual value from the waiter. > > Fixes: 9d57f7c79748920636f8293d2f01192d702fe390 ("selftests: futex: Test sys_futex_waitv() wouldblock") > Signed-off-by: Edward Liaw <edliaw@google.com> Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Thank you Edward, Em 04/04/2025 19:12, Edward Liaw escreveu: > Testcase should fail if -EWOULDBLOCK is not returned when expected value > differs from actual value from the waiter. > > Fixes: 9d57f7c79748920636f8293d2f01192d702fe390 ("selftests: futex: Test sys_futex_waitv() wouldblock") > Signed-off-by: Edward Liaw <edliaw@google.com> Reviewed-by: André Almeida <andrealmeid@igalia.com>
On 4/8/25 08:21, André Almeida wrote: > Thank you Edward, > > Em 04/04/2025 19:12, Edward Liaw escreveu: >> Testcase should fail if -EWOULDBLOCK is not returned when expected value >> differs from actual value from the waiter. >> >> Fixes: 9d57f7c79748920636f8293d2f01192d702fe390 ("selftests: futex: Test sys_futex_waitv() wouldblock") >> Signed-off-by: Edward Liaw <edliaw@google.com> > > Reviewed-by: André Almeida <andrealmeid@igalia.com> > Thank you. Applied for Linux 6.15-rc2 https://web.git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=fixes thanks, -- Shuah
diff --git a/tools/testing/selftests/futex/functional/futex_wait_wouldblock.c b/tools/testing/selftests/futex/functional/futex_wait_wouldblock.c index 7d7a6a06cdb7..2d8230da9064 100644 --- a/tools/testing/selftests/futex/functional/futex_wait_wouldblock.c +++ b/tools/testing/selftests/futex/functional/futex_wait_wouldblock.c @@ -98,7 +98,7 @@ int main(int argc, char *argv[]) info("Calling futex_waitv on f1: %u @ %p with val=%u\n", f1, &f1, f1+1); res = futex_waitv(&waitv, 1, 0, &to, CLOCK_MONOTONIC); if (!res || errno != EWOULDBLOCK) { - ksft_test_result_pass("futex_waitv returned: %d %s\n", + ksft_test_result_fail("futex_waitv returned: %d %s\n", res ? errno : res, res ? strerror(errno) : ""); ret = RET_FAIL;
Testcase should fail if -EWOULDBLOCK is not returned when expected value differs from actual value from the waiter. Fixes: 9d57f7c79748920636f8293d2f01192d702fe390 ("selftests: futex: Test sys_futex_waitv() wouldblock") Signed-off-by: Edward Liaw <edliaw@google.com> --- .../testing/selftests/futex/functional/futex_wait_wouldblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)