[v2,07/11] media: ccs-pll: Print missing PLL flags

Message ID	20250417065354.311617-8-sakari.ailus@linux.intel.com
State	New
Headers	show Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F3D421931E for <linux-media@vger.kernel.org>; Thu, 17 Apr 2025 06:54:17 +0000 (UTC) Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo From: Sakari Ailus <sakari.ailus@linux.intel.com> To: linux-media@vger.kernel.org Cc: laurent.pinchart@ideasonboard.com, dongcheng.yan@intel.com Subject: [PATCH v2 07/11] media: ccs-pll: Print missing PLL flags Date: Thu, 17 Apr 2025 09:53:50 +0300 Message-Id: <20250417065354.311617-8-sakari.ailus@linux.intel.com> In-Reply-To: <20250417065354.311617-1-sakari.ailus@linux.intel.com> References: <20250417065354.311617-1-sakari.ailus@linux.intel.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	CCS PLL fixes and improvements \| expand [v2,00/11] CCS PLL fixes and improvements [v2,01/11] media: ccs-pll: Start OP pre-PLL multiplier search from correct value [v2,02/11] media: ccs-pll: Start VT pre-PLL multiplier search from correct value [v2,03/11] media: ccs-pll: Check for too high VT PLL multiplier in dual PLL case [v2,04/11] media: ccs-pll: Correctly the upper limit of maximum op_pre_pll_clk_div [v2,05/11] media: ccs-pll: Print a debug message on too high VT PLL OP clock [v2,06/11] media: ccs-pll: Drop LINK_DECOUPLED flag [v2,07/11] media: ccs-pll: Print missing PLL flags [v2,08/11] media: ccs-pll: Add a flag for even PLL multipliers [v2,09/11] media: ccs-pll: Better validate VT PLL branch [v2,10/11] media: ccs-pll: Print PLL calculator flags in the beginning [v2,11/11] media: ccs-pll: Document the CCS PLL flags

Message ID

20250417065354.311617-8-sakari.ailus@linux.intel.com

State

New

Headers

Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com,
	dongcheng.yan@intel.com
Subject: [PATCH v2 07/11] media: ccs-pll: Print missing PLL flags
Date: Thu, 17 Apr 2025 09:53:50 +0300
Message-Id: <20250417065354.311617-8-sakari.ailus@linux.intel.com>
In-Reply-To: <20250417065354.311617-1-sakari.ailus@linux.intel.com>
References: <20250417065354.311617-1-sakari.ailus@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

CCS PLL fixes and improvements | expand

Printing the OP_PIX_CLOCK_PER_LANE and NO_OP_CLOCKS CCS PLL flags were missing, add them now. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/media/i2c/ccs-pll.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Laurent Pinchart April 21, 2025, 8:05 p.m. UTC | #1

Hi Sakari,

Thank you for the patch.

On Thu, Apr 17, 2025 at 09:53:50AM +0300, Sakari Ailus wrote:
> Printing the OP_PIX_CLOCK_PER_LANE and NO_OP_CLOCKS CCS PLL flags were

s/were/is/

> missing, add them now.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/i2c/ccs-pll.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ccs-pll.c b/drivers/media/i2c/ccs-pll.c
> index 16eb09462c8b..ebbc5e323244 100644
> --- a/drivers/media/i2c/ccs-pll.c
> +++ b/drivers/media/i2c/ccs-pll.c
> @@ -124,7 +124,9 @@ static void print_pll(struct device *dev, const struct ccs_pll *pll)
>  	dev_dbg(dev, "pixel rate on CSI-2 bus:\t%u\n",
>  		pll->pixel_rate_csi);
>  
> -	dev_dbg(dev, "flags%s%s%s%s%s%s%s%s\n",
> +	dev_dbg(dev, "flags%s%s%s%s%s%s%s%s%s%s\n",
> +		pll->flags & PLL_FL(OP_PIX_CLOCK_PER_LANE) ? " op-pix-clock-per-lane" : "",
> +		pll->flags & PLL_FL(NO_OP_CLOCKS) ? " no-op-clocks" : "",
>  		pll->flags & PLL_FL(LANE_SPEED_MODEL) ? " lane-speed" : "",
>  		pll->flags & PLL_FL(EXT_IP_PLL_DIVIDER) ?
>  		" ext-ip-pll-divider" : "",

diff --git a/drivers/media/i2c/ccs-pll.c b/drivers/media/i2c/ccs-pll.c
index 16eb09462c8b..ebbc5e323244 100644
--- a/drivers/media/i2c/ccs-pll.c
+++ b/drivers/media/i2c/ccs-pll.c
@@ -124,7 +124,9 @@  static void print_pll(struct device *dev, const struct ccs_pll *pll)
 	dev_dbg(dev, "pixel rate on CSI-2 bus:\t%u\n",
 		pll->pixel_rate_csi);
 
-	dev_dbg(dev, "flags%s%s%s%s%s%s%s%s\n",
+	dev_dbg(dev, "flags%s%s%s%s%s%s%s%s%s%s\n",
+		pll->flags & PLL_FL(OP_PIX_CLOCK_PER_LANE) ? " op-pix-clock-per-lane" : "",
+		pll->flags & PLL_FL(NO_OP_CLOCKS) ? " no-op-clocks" : "",
 		pll->flags & PLL_FL(LANE_SPEED_MODEL) ? " lane-speed" : "",
 		pll->flags & PLL_FL(EXT_IP_PLL_DIVIDER) ?
 		" ext-ip-pll-divider" : "",

[v2,07/11] media: ccs-pll: Print missing PLL flags

Commit Message

Comments

Patch