| Message ID | 20250418-qcs8300_iris-v2-1-1e01385b90e9@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | media: qcom: iris: add support for QCS8300 | expand |
On Fri, 18 Apr 2025 11:58:39 +0530, Vikash Garodia wrote: > Document the IRIS video decoder and encoder accelerator found in the > QCS8300 platform. QCS8300 is a downscaled version of SM8550, thereby > have different(lower) capabilities when compared to SM8550. > > This patch depends on patch 20250225-topic-sm8x50-iris-v10-a219b8a8b477 > > Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com> > --- > Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/fsl/fsl,ls1028a-reset.yaml: maintainers:0: 'Frank Li' does not match '@' from schema $id: http://devicetree.org/meta-schemas/base.yaml# doc reference errors (make refcheckdocs): Documentation/userspace-api/netlink/netlink-raw.rst: :doc:`rt_link<../../networking/netlink_spec/rt_link>` Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/leds/backlight/ti,lp8864.yaml Documentation/userspace-api/netlink/netlink-raw.rst: :doc:`rt_link<../../networking/netlink_spec/rt_link>` MAINTAINERS: Documentation/devicetree/bindings/leds/backlight/ti,lp8864.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250418-qcs8300_iris-v2-1-1e01385b90e9@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Fri, Apr 18, 2025 at 11:58:39AM +0530, Vikash Garodia wrote: > Document the IRIS video decoder and encoder accelerator found in the > QCS8300 platform. QCS8300 is a downscaled version of SM8550, thereby > have different(lower) capabilities when compared to SM8550. > > This patch depends on patch 20250225-topic-sm8x50-iris-v10-a219b8a8b477 An incomplete message-id is not useful. It also should go below the '---' so it is not recorded in git forever. > > Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com> > --- > Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml > index f567f84bd60d439b151bb1407855ba73582c3b83..3dee25e99204169c6c80f7db4bad62775aaa59b5 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml > @@ -24,6 +24,7 @@ properties: > - enum: > - qcom,sm8550-iris > - qcom,sm8650-iris > + - qcom,qcs8300-iris > > power-domains: > maxItems: 4 > > -- > 2.34.1 >
On 4/21/2025 5:20 PM, Rob Herring wrote: > On Fri, Apr 18, 2025 at 11:58:39AM +0530, Vikash Garodia wrote: >> Document the IRIS video decoder and encoder accelerator found in the >> QCS8300 platform. QCS8300 is a downscaled version of SM8550, thereby >> have different(lower) capabilities when compared to SM8550. >> >> This patch depends on patch 20250225-topic-sm8x50-iris-v10-a219b8a8b477 > > An incomplete message-id is not useful. It also should go below the > '---' so it is not recorded in git forever. Ok, i can add the lore link to the dependent patch. Does your bot picks the dependent patch and run the checkers ? The cover letter calls out the dependent change-id #, i am assuming the bot checks for dependencies, if it does, in the binding patch, and not the cover letter ? Regards, Vikash > >> >> Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com> >> --- >> Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml >> index f567f84bd60d439b151bb1407855ba73582c3b83..3dee25e99204169c6c80f7db4bad62775aaa59b5 100644 >> --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml >> +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml >> @@ -24,6 +24,7 @@ properties: >> - enum: >> - qcom,sm8550-iris >> - qcom,sm8650-iris >> + - qcom,qcs8300-iris >> >> power-domains: >> maxItems: 4 >> >> -- >> 2.34.1 >>
On 4/18/2025 3:52 PM, Bryan O'Donoghue wrote: > On 18/04/2025 07:28, Vikash Garodia wrote: >> Document the IRIS video decoder and encoder accelerator found in the > > Document the IRIS video "encoder/decoder" or "transcoder" > > >> QCS8300 platform. QCS8300 is a downscaled version of SM8550, thereby > > is a down-scaled version of the SM8550. > > QCS8300 has a fewer capabilities compared to SM8550. Ack. > > Note: It might be nice to give a brief overview of what the differences are > since you mention them or instead of making it a diff of 8550 just to state what > the QCS8300 can do. The reason to compare it with 8550 is that the patch adds the delta ontop of 8550. All other structures, it still uses from 8550. Regards, Vikash > >> have different(lower) capabilities when compared to SM8550. >> >> This patch depends on patch 20250225-topic-sm8x50-iris-v10-a219b8a8b477 >> >> Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com> >> --- >> Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml >> b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml >> index >> f567f84bd60d439b151bb1407855ba73582c3b83..3dee25e99204169c6c80f7db4bad62775aaa59b5 100644 >> --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml >> +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml >> @@ -24,6 +24,7 @@ properties: >> - enum: >> - qcom,sm8550-iris >> - qcom,sm8650-iris >> + - qcom,qcs8300-iris >> power-domains: >> maxItems: 4 >> > Otherwise looks good an applies, please update your commit long and add: > > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml index f567f84bd60d439b151bb1407855ba73582c3b83..3dee25e99204169c6c80f7db4bad62775aaa59b5 100644 --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml @@ -24,6 +24,7 @@ properties: - enum: - qcom,sm8550-iris - qcom,sm8650-iris + - qcom,qcs8300-iris power-domains: maxItems: 4
Document the IRIS video decoder and encoder accelerator found in the QCS8300 platform. QCS8300 is a downscaled version of SM8550, thereby have different(lower) capabilities when compared to SM8550. This patch depends on patch 20250225-topic-sm8x50-iris-v10-a219b8a8b477 Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com> --- Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml | 1 + 1 file changed, 1 insertion(+)