mbox series

[0/3] ngene: Replace semaphores with mutexes

Message ID 1496916298-5909-1-git-send-email-binoy.jayan@linaro.org
Headers show
Series ngene: Replace semaphores with mutexes | expand

Message

Binoy Jayan June 8, 2017, 10:04 a.m. UTC 
These are a set of patches which removes semaphores from ngene.
These are part of a bigger effort to eliminate unwanted semaphores
from the linux kernel.

Binoy Jayan (3):
  media: ngene: Replace semaphore cmd_mutex with mutex
  media: ngene: Replace semaphore stream_mutex with mutex
  media: ngene: Replace semaphore i2c_switch_mutex with mutex

 drivers/media/pci/ngene/ngene-core.c | 28 ++++++++++++++--------------
 drivers/media/pci/ngene/ngene-i2c.c  |  6 +++---
 drivers/media/pci/ngene/ngene.h      |  6 +++---
 3 files changed, 20 insertions(+), 20 deletions(-)

-- 
Binoy Jayan

Comments

Arnd Bergmann June 8, 2017, 3:19 p.m. UTC | #1 
On Thu, Jun 8, 2017 at 12:04 PM, Binoy Jayan <binoy.jayan@linaro.org> wrote:
> The semaphore 'stream_mutex' is used as a simple mutex, so

> it should be written as one. Semaphores are going away in the future.

>

> Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org>

> ---


Looks correct, though I wonder whether it would be nicer to move the
mutex_lock/unlock() to the caller to avoid repeating the unlock() five
times.

Either way,

Reviewed-by: Arnd Bergmann <arnd@arndb.de>