mbox series

[0/9] mmc: core: Some trivial re-factoring and cleanups

Message ID 1496928465-25004-1-git-send-email-ulf.hansson@linaro.org
Headers show
Series mmc: core: Some trivial re-factoring and cleanups | expand

Message

Ulf Hansson June 8, 2017, 1:27 p.m. UTC
I have collected some cleanups along the road on the mmc core, now I thought it
was time to post them. None of these changes causes any functional changes, but
the goal is rather to just make the code more readable and avoid open coding.


Ulf Hansson (9):
  mmc: core: Don't export some eMMC specific functions from core.c
  mmc: core: Move mmc bkops functions from core.c to mmc_ops.c
  mmc: core: Move mmc_interrupt_hpi() from core.c to mmc_ops.c
  mmc: core: Move mmc_flush_cache() from core.c to mmc_ops.c
  mmc: core: Make mmc_can_reset() static
  mmc: core: Remove redundant code in mmc_send_cid()
  mmc: core: Re-factor code for sending CID
  mmc: core: Drop mmc_all_send_cid() and use mmc_send_cxd_native()
    instead
  mmc: core: Clarify code for sending CSD

 drivers/mmc/core/core.c    | 207 -------------------------------------
 drivers/mmc/core/mmc.c     |   8 +-
 drivers/mmc/core/mmc_ops.c | 250 +++++++++++++++++++++++++++++++++++++++------
 drivers/mmc/core/mmc_ops.h |   3 -
 drivers/mmc/core/sd.c      |   6 +-
 5 files changed, 221 insertions(+), 253 deletions(-)

-- 
2.7.4

Comments

Shawn Lin June 16, 2017, 12:49 a.m. UTC | #1
Hi Ulf,

On 2017/6/8 21:27, Ulf Hansson wrote:
> I have collected some cleanups along the road on the mmc core, now I thought it

> was time to post them. None of these changes causes any functional changes, but

> the goal is rather to just make the code more readable and avoid open coding.

> 

> 

> Ulf Hansson (9):

>    mmc: core: Don't export some eMMC specific functions from core.c

>    mmc: core: Move mmc bkops functions from core.c to mmc_ops.c

>    mmc: core: Move mmc_interrupt_hpi() from core.c to mmc_ops.c

>    mmc: core: Move mmc_flush_cache() from core.c to mmc_ops.c

>    mmc: core: Make mmc_can_reset() static

>    mmc: core: Remove redundant code in mmc_send_cid()

>    mmc: core: Re-factor code for sending CID

>    mmc: core: Drop mmc_all_send_cid() and use mmc_send_cxd_native()

>      instead

>    mmc: core: Clarify code for sending CSD


Looks good to me, so

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>


> 

>   drivers/mmc/core/core.c    | 207 -------------------------------------

>   drivers/mmc/core/mmc.c     |   8 +-

>   drivers/mmc/core/mmc_ops.c | 250 +++++++++++++++++++++++++++++++++++++++------

>   drivers/mmc/core/mmc_ops.h |   3 -

>   drivers/mmc/core/sd.c      |   6 +-

>   5 files changed, 221 insertions(+), 253 deletions(-)

> 


--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html