| Message ID | 1500021225-4118-1-git-send-email-peter.maydell@linaro.org |
|---|---|
| Headers | show |
| Series | Fix NetBSD build (don't build ivshmem tools) | expand |
Ping for review? It would be nice to get the NetBSD host into the build-test rotation... thanks -- PMM On 14 July 2017 at 09:33, Peter Maydell <peter.maydell@linaro.org> wrote: > This patchset fixes the build on NetBSD by making sure we only > build the ivshmem-client and ivshmem-server tools if the host OS > actually supports ivshmem. (Previously we were only gating building > of the within-QEMU ivshmem PCI device.) > > Most of this patchset is the work of Kamil Rytarowski; I just > split it up into easily-reviewable patches and fixed a few bugs. > > Tested on Linux, on NetBSD, and on Linux with a '--disable-linux-user > --disable-system' config (which was the one that was failing with > our previous attempt to fix this bug). > > NB: we still have some things we need to fix to be able to put > NetBSD into the build-test set. The next issue is that 'make check' > fails with > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} gtester -k --verbose -m=quick tests/check-qdict > sh: arith: syntax error: "RANDOM % 255 + 1" > > likely because we're using a bashism there. > > thanks > -- PMM > > Kamil Rytarowski (2): > configure: Use an explicit CONFIG_IVSHMEM rather than CONFIG_EVENTFD > configure: Don't build ivshmem tools unless CONFIG_IVSHMEM is set > > Peter Maydell (1): > configure: Rename CONFIG_IVSHMEM to CONFIG_IVSHMEM_DEVICE > > configure | 11 +++++++++++ > Makefile | 2 ++ > Makefile.objs | 4 ++-- > hw/misc/Makefile.objs | 2 +- > tests/Makefile.include | 4 ++-- > default-configs/pci.mak | 2 +- > 6 files changed, 19 insertions(+), 6 deletions(-)
Peter Maydell <peter.maydell@linaro.org> writes: > This patchset fixes the build on NetBSD by making sure we only > build the ivshmem-client and ivshmem-server tools if the host OS > actually supports ivshmem. (Previously we were only gating building > of the within-QEMU ivshmem PCI device.) > > Most of this patchset is the work of Kamil Rytarowski; I just > split it up into easily-reviewable patches and fixed a few bugs. > > Tested on Linux, on NetBSD, and on Linux with a '--disable-linux-user > --disable-system' config (which was the one that was failing with > our previous attempt to fix this bug). > > NB: we still have some things we need to fix to be able to put > NetBSD into the build-test set. The next issue is that 'make check' > fails with > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} gtester -k --verbose -m=quick tests/check-qdict > sh: arith: syntax error: "RANDOM % 255 + 1" > > likely because we're using a bashism there. Regardless of my inability to find CONFIG_IVSHMEM confusing (see PATCH 1), series Reviewed-by: Markus Armbruster <armbru@redhat.com>
On 20 July 2017 at 12:20, Markus Armbruster <armbru@redhat.com> wrote: > Regardless of my inability to find CONFIG_IVSHMEM confusing (see PATCH > 1), series > Reviewed-by: Markus Armbruster <armbru@redhat.com> Thanks; patchset applied to master. -- PMM
On 20.07.2017 17:35, Peter Maydell wrote: > On 20 July 2017 at 12:20, Markus Armbruster <armbru@redhat.com> wrote: >> Regardless of my inability to find CONFIG_IVSHMEM confusing (see PATCH >> 1), series >> Reviewed-by: Markus Armbruster <armbru@redhat.com> > > Thanks; patchset applied to master. > > -- PMM > Thank you for this!
This patchset fixes the build on NetBSD by making sure we only build the ivshmem-client and ivshmem-server tools if the host OS actually supports ivshmem. (Previously we were only gating building of the within-QEMU ivshmem PCI device.) Most of this patchset is the work of Kamil Rytarowski; I just split it up into easily-reviewable patches and fixed a few bugs. Tested on Linux, on NetBSD, and on Linux with a '--disable-linux-user --disable-system' config (which was the one that was failing with our previous attempt to fix this bug). NB: we still have some things we need to fix to be able to put NetBSD into the build-test set. The next issue is that 'make check' fails with MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} gtester -k --verbose -m=quick tests/check-qdict sh: arith: syntax error: "RANDOM % 255 + 1" likely because we're using a bashism there. thanks -- PMM Kamil Rytarowski (2): configure: Use an explicit CONFIG_IVSHMEM rather than CONFIG_EVENTFD configure: Don't build ivshmem tools unless CONFIG_IVSHMEM is set Peter Maydell (1): configure: Rename CONFIG_IVSHMEM to CONFIG_IVSHMEM_DEVICE configure | 11 +++++++++++ Makefile | 2 ++ Makefile.objs | 4 ++-- hw/misc/Makefile.objs | 2 +- tests/Makefile.include | 4 ++-- default-configs/pci.mak | 2 +- 6 files changed, 19 insertions(+), 6 deletions(-) -- 2.7.4