From patchwork Wed Aug 2 10:12:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 109201 Delivered-To: patch@linaro.org Received: by 10.140.101.6 with SMTP id t6csp2590458qge; Wed, 2 Aug 2017 03:12:51 -0700 (PDT) X-Received: by 10.84.210.205 with SMTP id a71mr24334626pli.201.1501668771101; Wed, 02 Aug 2017 03:12:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501668771; cv=none; d=google.com; s=arc-20160816; b=XYvOprcCeeIuAvfYU8g3extkkA5B2wt/lu/t0Y5wFU3caKX9SGo8SxK4PyIAK5qpN5 PlHkEBbl0+k+rDzEUQCE9J12XXu5VMJq5u3lvtrtxNHY13CvChTPrGRbkGkwzXVsK2hS 6Gc7XSmtfD/HL92LNZFyz1w3lpwht9aKYftzkvng39dOJ2yBawMjI964BaPmqzPqLreF I8upJoWtAJ9ZglNQEjEFa+58wCuNi/oDhcl7LUzZeFL2JCeAxJzxmqomaccZNy3qJK9H wOXkGWylVR27tZfJvXJzMRQGUO2DW14ZtnxGHh/BvgoBSaeVj6x618litPoaCA5IDWmO PjEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=5o6mJo3F+UbKOpTAqOYvo7+yaVqsbYuVc7KvW/jKSRU=; b=G5cWxbOIiEZ6Bl2CnbcuKNbtfb07+yAW8sxw6UHZopqAhBJJ87Lajqebmj/OagyTQz gTQgECQhvXlce9Th9i77P4+XEHus8Kbfz/8PPI2Cl2HnoMGjAyTe92Yc0KmDPG8AQO8i 9SBNZtKvRDED+iUmajZ9NVCLifzdpZz26xncVtsgsimd0Ya/P24+9A2RtYVW6/33DlnQ m6AMOGxBB1+i4h3Z7yHI2fWgytyRxEp8sNyRKh9kHiLVdz+63SKsrH31jnU0GUVosUrk MHibI2ijY5c8ev5ZbyR7b45NpeDC+AiToNs95GVoRnayI+QwQQISWgeXNE1/iz+j5eCg ywqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.b=KtTkUqjc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b68si1489061pgc.331.2017.08.02.03.12.50; Wed, 02 Aug 2017 03:12:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.b=KtTkUqjc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752712AbdHBKMr (ORCPT + 25 others); Wed, 2 Aug 2017 06:12:47 -0400 Received: from mail-pg0-f46.google.com ([74.125.83.46]:35631 "EHLO mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751991AbdHBKMp (ORCPT ); Wed, 2 Aug 2017 06:12:45 -0400 Received: by mail-pg0-f46.google.com with SMTP id v189so19395832pgd.2 for ; Wed, 02 Aug 2017 03:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=5o6mJo3F+UbKOpTAqOYvo7+yaVqsbYuVc7KvW/jKSRU=; b=KtTkUqjc/MctinLihoJLuq4fU4kd3dExW4y/cvWHL6L3G/troNUVSIKOzhhozVZTTY 4jN2KLlKJO5sIAv6wC2Slh7fhd0Q6IgLeVSryJ/8CYztyw8u7UbDgxTOQUHds3rUUIqS //j01Vt46ij8dCD+uPfkbQ5U2opL2tWfEsO1k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5o6mJo3F+UbKOpTAqOYvo7+yaVqsbYuVc7KvW/jKSRU=; b=VVlp77vcDf9b21+8RFeuLmPmTHqjlcFLUzoUTa05FVgTJ38fSWLViRrXlmF3uCMzLT dqyIhsfQhlqgHC1AbOg6KrxYz1uyLusMzy6l++EWjW5awXByhvo8npqmQBzs2zkxBzbK 8ypIY6eo6aVwMtEUtQzNkSkv8hn5MVB42dnBmTP/iBps9oNlJeZvLU4vFJv2la74qR2p GS4oCUN/TF0mmHi1pQJ4FiX9fRGTnnDrPDZ8QBb1+aTgzQN69BSw0gaJQjUsOXBWlVA6 fj/0zB76gBW5oO+8pTEIBJjXzqli2lZ09lRpST8kYw6okg37PtpnxO3ElmsGpV7gFSIH zH7A== X-Gm-Message-State: AIVw110vLztlnlQkBoZmIDLXh+TtJu0aNk99kt8rGnE7nPv2zRtCFngp REa6yBW8/JVCzZG8 X-Received: by 10.98.209.83 with SMTP id t19mr22403846pfl.311.1501668765098; Wed, 02 Aug 2017 03:12:45 -0700 (PDT) Received: from localhost ([122.171.108.183]) by smtp.gmail.com with ESMTPSA id b3sm67210707pfc.162.2017.08.02.03.12.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Aug 2017 03:12:43 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki , ulf.hansson@linaro.org, Kevin Hilman Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , Stephen Boyd , Nishanth Menon , robh+dt@kernel.org, lina.iyer@linaro.org, rnayak@codeaurora.org, sudeep.holla@arm.com, linux-kernel@vger.kernel.org, Len Brown , Pavel Machek , Andy Gross , David Brown Subject: [PATCH V9 0/7] PM / Domains: Performance state support Date: Wed, 2 Aug 2017 15:42:31 +0530 Message-Id: X-Mailer: git-send-email 2.13.0.71.gd7076ec9c9cb Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ulf/Kevin, These are the changes since V8: - Renamed genpd callbacks and internal routines. - dev_pm_genpd_has_performance_state() simplified a lot and doesn't check master hierarchy now. Rather a new patch (2/7) is added to take care of that and WARN if no master has set genpd_set_performance_state() callback. - Update is propagated to the masters even if the genpd's callback is already called. - Exit _genpd_reeval_performance_state() early if no state change is required and it gets an additional argument (new state of the device/subdomain). - Taken care of genpd on/off cases. - s/parent/master everywhere in comments and logs. - Better explanations in logs, comments etc. - All the other patches (3-7/7) are same as V8. (Just minor update in 5/7 to use the updated callback names). -------------------------8<------------------------- Some platforms have the capability to configure the performance state of their power domains. The process of configuring the performance state is pretty much platform dependent and we may need to work with a wide range of configurables. For some platforms, like Qcom, it can be a positive integer value alone, while in other cases it can be voltage levels, etc. The power-domain framework until now was only designed for the idle state management of the device and this needs to change in order to reuse the power-domain framework for active state management of the devices. The first two patches updates the genpd framework to supply new APIs to support active state management and the third patch uses them from the OPP core. Rest of the patches [4-4/4] are included just to show how user drivers would end up using the new APIs and these patches aren't there to get merged and are marked clearly like that. The ideal way is still to get the relation between device and domain states via the DT instead of platform code, but that can be done incrementally later once we have some users for it upstream. This is currently tested by: - /me by hacking the kernel a bit with virtual power-domains for the ARM 64 hikey platform. I have also tested the complex cases where the device's parent power domain doesn't have set_performance_state() callback set, but parents of that domains have it. Lockdep configs were enabled for these tests. - Rajendra Nayak, on msm8996 platform (Qcom) with MMC controller. Thanks Rajendra for helping me testing this out. Pushed here as well: https://git.linaro.org/people/viresh.kumar/linux.git/log/?h=opp/genpd-performance-state Rebased on: pm/linux-next (have some OPP dependencies there) V7->V8: - Ulf helped a lot in reviewing V7 and pointed out couple of issues, specially in locking while dealing with a hierarchy of power domains. - All those locking issues are sorted out now, even for the complex cases. - genpd_lookup_dev() is used in pm_genpd_has_performance_state() to make sure we have a valid genpd available for the device. - Validation of performance state callbacks isn't done anymore in pm_genpd_init() as it gets called very early and the binding of subdomains to their parent domains happens later. This is handled in pm_genpd_has_performance_state() now, which is called from user drivers. - User driver changes (not to be merged) are included for the first time here, to demonstrate how changes would look finally. V6->V7: - Almost a rewrite, only two patches against 9 in earlier version. - No bindings updated now and domain's performance state aren't passed via DT for now (until we know how users are going to use it). - We also skipped the QoS framework completely and new APIs are provided directly by genpd. V5->V6: - Use freq/voltage in OPP table as it is for power domain and don't create "domain-performance-level" property - Create new "power-domain-opp" property for the devices. - Take care of domain providers that provide multiple domains and extend "operating-points-v2" property to contain a list of phandles - Update code according to those bindings. V4->V5: - Only 3 patches were resent and 2 of them are Acked from Ulf. V3->V4: - Use OPP table for genpd devices as well. - Add struct device to genpd, in order to reuse OPP infrastructure. - Based over: https://marc.info/?l=linux-kernel&m=148972988002317&w=2 - Fixed examples in DT document to have voltage in target,min,max order. V2->V3: - Based over latest pm/linux-next - Bindings and code are merged together - Lots of updates in bindings - the performance-states node is present within the power-domain now, instead of its phandle. - performance-level property is replaced by "reg". - domain-performance-state property of the consumers contain an integer value now instead of phandle. - Lots of updates to the code as well - Patch "PM / QOS: Add default case to the switch" is merged with other patches and the code is changed a bit as well. - Don't pass 'type' to dev_pm_qos_add_notifier(), rather handle all notifiers with a single list. A new patch is added for that. - The OPP framework patch can be applied now and has proper SoB from me. - Dropped "PM / domain: Save/restore performance state at runtime suspend/resume". - Drop all WARN(). - Tested-by Rajendra nayak. V1->V2: - Based over latest pm/linux-next - It is mostly a resend of what is sent earlier as this series hasn't got any reviews so far and Rafael suggested that its better I resend it. - Only the 4/6 patch got an update, which was shared earlier as reply to V1 as well. It has got several fixes for taking care of power domain hierarchy, etc. -- viresh Rajendra Nayak (4): soc: qcom: rpmpd: Add a powerdomain driver to model cx/mx powerdomains soc: qcom: rpmpd: Add support for get/set performance state mmc: sdhci-msm: Adapt the driver to use OPPs to set clocks/performance state remoteproc: qcom: q6v5: Vote for proxy powerdomain performance state Viresh Kumar (3): PM / Domains: Add support to select performance-state of domains PM / Domains: Catch missing genpd_set_performance_state() in masters PM / OPP: Support updating performance state of device's power domains .../devicetree/bindings/power/qcom,rpmpd.txt | 10 + arch/arm64/boot/dts/qcom/msm8996.dtsi | 39 ++ drivers/base/power/domain.c | 298 ++++++++++++++- drivers/base/power/opp/core.c | 48 ++- drivers/base/power/opp/opp.h | 2 + drivers/clk/qcom/gcc-msm8996.c | 8 +- drivers/mmc/host/sdhci-msm.c | 39 +- drivers/remoteproc/qcom_q6v5_pil.c | 20 +- drivers/soc/qcom/Kconfig | 9 + drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/rpmpd.c | 412 +++++++++++++++++++++ include/linux/pm_domain.h | 23 ++ 12 files changed, 885 insertions(+), 24 deletions(-) create mode 100644 Documentation/devicetree/bindings/power/qcom,rpmpd.txt create mode 100644 drivers/soc/qcom/rpmpd.c -- 2.13.0.71.gd7076ec9c9cb