mbox series

[v2,0/2] Qualcomm SMEM cached item support

Message ID 20170814214922.18061-1-bjorn.andersson@linaro.org
Headers show
Series Qualcomm SMEM cached item support | expand

Message

Bjorn Andersson Aug. 14, 2017, 9:49 p.m. UTC 
When writing the SMEM implementation no public kernel had a consumer specifying
the "cached" flag, so I ommitted this part of the implementation. On MSM8996
this has changed, where we have one user of this - namely the GLINK RX FIFO.

The remote is supposedly scanning both lists for the GLINK descriptors and TX
FIFO, so we don't need to support allocating from this list at this point. This
has been confirmed in initial testing (by booting the ADSP)

Bjorn Andersson (2):
  soc: qcom: smem: Rename "uncached" accessors
  soc: qcom: smem: Support getting cached entries

 drivers/soc/qcom/smem.c | 93 ++++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 73 insertions(+), 20 deletions(-)

-- 
2.12.0

Comments

Bjorn Andersson Sept. 15, 2017, 10:36 p.m. UTC | #1 
On Fri 15 Sep 12:19 PDT 2017, Stephen Boyd wrote:

> On 08/14, Bjorn Andersson wrote:

> > In preparation for adding accessors for "cached" entries rename the

> > "uncached" accessors to. Also rename "first" cached entry to "last", as

> 

> s/to/too? or to "uncached"?

> 


Doesn't it make more sense if we ju just make it: rename the "uncached"
accessors? I.e just drop the "to".

> > the cached list grows backwards.

> > 

> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> 

> 

> Otherwise,

> 

> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

> 


Thanks,
Bjorn