[0/6] Sync and consolidate Linux-derived printk, BUILD_BUG, BUG, WARN, etc.

Message ID 1505303106-9780-1-git-send-email-yamada.masahiro@socionext.com
Headers show
Series
  • Sync and consolidate Linux-derived printk, BUILD_BUG, BUG, WARN, etc.
Related show

Message

Masahiro Yamada Sept. 13, 2017, 11:45 a.m.
buildman is 60% done, and no regression so far.

I will report the full-stat when buildman is complete.



Masahiro Yamada (6):
  printk: collect printk stuff into <linux/printk.h>
  treewide: replace with error() with pr_err()
  common.h: remove error()
  vsprintf.h: include <linux/types.h>
  bug.h: sync BUILD_BUG stuff with Linux 4.13
  bug.h: move runtime BUG/WARN macros into <linux/bug.h>

 arch/arm/mach-omap2/am33xx/board.c             |  2 +-
 arch/arm/mach-omap2/utils.c                    |  4 +-
 arch/arm/mach-rockchip/rk3188-board-spl.c      |  2 +-
 arch/arm/mach-rockchip/rk3188-board.c          |  2 +-
 arch/arm/mach-rockchip/rk3368-board-spl.c      |  4 +-
 arch/arm/mach-rockchip/rk3399/sdram_rk3399.c   |  2 +-
 arch/arm/mach-socfpga/reset_manager_arria10.c  |  2 +-
 arch/arm/mach-tegra/ivc.c                      |  8 +--
 arch/arm/mach-tegra/tegra124/xusb-padctl.c     |  2 +-
 arch/arm/mach-tegra/tegra186/nvtboot_mem.c     |  4 +-
 arch/arm/mach-tegra/tegra20/clock.c            |  6 +-
 arch/arm/mach-tegra/tegra210/xusb-padctl.c     |  2 +-
 arch/arm/mach-tegra/tegra30/clock.c            |  6 +-
 arch/arm/mach-tegra/xusb-padctl-common.c       | 22 +++---
 arch/arm/mach-uniphier/dram_init.c             |  3 -
 arch/arm/mach-uniphier/init.h                  |  5 --
 arch/x86/cpu/tangier/sdram.c                   |  6 +-
 board/nvidia/jetson-tk1/jetson-tk1.c           |  6 +-
 board/samsung/common/exynos5-dt.c              |  2 +-
 board/samsung/common/misc.c                    |  2 +-
 board/samsung/goni/goni.c                      |  4 +-
 board/samsung/odroid/odroid.c                  | 12 ++--
 cmd/fastboot.c                                 |  2 +-
 cmd/nvedit.c                                   |  6 +-
 cmd/regulator.c                                |  2 +-
 cmd/thordown.c                                 |  6 +-
 cmd/tpm_test.c                                 |  6 +-
 cmd/usb_gadget_sdp.c                           |  4 +-
 cmd/usb_mass_storage.c                         |  6 +-
 common/dfu.c                                   |  6 +-
 common/fb_mmc.c                                | 36 +++++-----
 common/fb_nand.c                               | 12 ++--
 common/spl/spl_dfu.c                           |  4 +-
 common/spl/spl_sdp.c                           |  4 +-
 common/update.c                                |  2 +-
 disk/part_efi.c                                | 10 +--
 drivers/adc/adc-uclass.c                       |  6 +-
 drivers/adc/exynos-adc.c                       |  6 +-
 drivers/adc/sandbox.c                          |  6 +-
 drivers/ata/dwc_ahci.c                         |  6 +-
 drivers/bios_emulator/include/x86emu/x86emui.h |  3 -
 drivers/clk/clk_boston.c                       |  4 +-
 drivers/clk/clk_stm32f7.c                      |  2 +-
 drivers/clk/rockchip/clk_rk3368.c              |  8 +--
 drivers/clk/rockchip/clk_rk3399.c              |  6 +-
 drivers/clk/rockchip/clk_rv1108.c              |  2 +-
 drivers/dfu/dfu.c                              | 14 ++--
 drivers/dfu/dfu_mmc.c                          | 18 ++---
 drivers/dfu/dfu_ram.c                          |  8 +--
 drivers/dfu/dfu_tftp.c                         |  4 +-
 drivers/dma/dma-uclass.c                       |  2 +-
 drivers/dma/lpc32xx_dma.c                      |  8 +--
 drivers/dma/ti-edma3.c                         |  2 +-
 drivers/i2c/i2c-gpio.c                         |  2 +-
 drivers/i2c/omap24xx_i2c.c                     |  2 +-
 drivers/i2c/stm32f7_i2c.c                      | 16 ++---
 drivers/i2c/tegra_i2c.c                        |  4 +-
 drivers/misc/tegra186_bpmp.c                   | 28 ++++----
 drivers/mmc/exynos_dw_mmc.c                    |  2 +-
 drivers/mmc/hi6220_dw_mmc.c                    |  2 +-
 drivers/mmc/xenon_sdhci.c                      |  4 +-
 drivers/mtd/nand/lpc32xx_nand_mlc.c            |  6 +-
 drivers/mtd/nand/pxa3xx_nand.c                 |  2 +-
 drivers/net/bcm-sf2-eth-gmac.c                 | 14 ++--
 drivers/net/bcm-sf2-eth.c                      | 18 ++---
 drivers/net/cpsw-common.c                      |  8 +--
 drivers/net/cpsw.c                             |  8 +--
 drivers/net/dwc_eth_qos.c                      | 92 +++++++++++++-------------
 drivers/net/ep93xx_eth.c                       | 16 ++---
 drivers/net/keystone_net.c                     | 14 ++--
 drivers/pci/pci_tegra.c                        | 50 +++++++-------
 drivers/pci/pcie_xilinx.c                      |  2 +-
 drivers/phy/marvell/comphy_cp110.c             | 40 +++++------
 drivers/phy/ti-pipe3-phy.c                     | 12 ++--
 drivers/pinctrl/mvebu/pinctrl-armada-37xx.c    |  2 +-
 drivers/pinctrl/pinctrl-sti.c                  | 14 ++--
 drivers/pinctrl/pinctrl_stm32.c                |  2 +-
 drivers/power/pmic/as3722.c                    | 12 ++--
 drivers/power/pmic/as3722_gpio.c               | 10 +--
 drivers/power/pmic/i2c_pmic_emul.c             |  6 +-
 drivers/power/pmic/lp873x.c                    |  4 +-
 drivers/power/pmic/lp87565.c                   |  4 +-
 drivers/power/pmic/max77686.c                  |  4 +-
 drivers/power/pmic/max8997.c                   |  4 +-
 drivers/power/pmic/max8998.c                   |  4 +-
 drivers/power/pmic/palmas.c                    |  4 +-
 drivers/power/pmic/pfuze100.c                  |  4 +-
 drivers/power/pmic/s2mps11.c                   |  4 +-
 drivers/power/pmic/s5m8767.c                   |  4 +-
 drivers/power/pmic/sandbox.c                   |  6 +-
 drivers/power/pmic/tps65090.c                  |  4 +-
 drivers/power/regulator/fixed.c                |  2 +-
 drivers/power/regulator/gpio-regulator.c       |  2 +-
 drivers/power/regulator/max77686.c             | 20 +++---
 drivers/power/regulator/sandbox.c              | 18 ++---
 drivers/ram/rockchip/dmc-rk3368.c              | 14 ++--
 drivers/ram/stm32_sdram.c                      |  8 +--
 drivers/reset/sti-reset.c                      | 10 +--
 drivers/spi/atmel_spi.c                        |  2 +-
 drivers/spi/lpc32xx_ssp.c                      |  6 +-
 drivers/sysreset/sysreset_sti.c                |  6 +-
 drivers/sysreset/sysreset_syscon.c             |  4 +-
 drivers/sysreset/sysreset_watchdog.c           |  2 +-
 drivers/tpm/tpm_tis_infineon.c                 |  2 +-
 drivers/usb/common/common.c                    |  2 +-
 drivers/usb/dwc3/linux-compat.h                |  2 -
 drivers/usb/eth/mcs7830.c                      | 12 ++--
 drivers/usb/gadget/at91_udc.c                  |  4 +-
 drivers/usb/gadget/atmel_usba_udc.c            |  6 +-
 drivers/usb/gadget/dwc2_udc_otg.c              |  2 +-
 drivers/usb/gadget/ether.c                     | 42 ++++++------
 drivers/usb/gadget/f_fastboot.c                | 10 +--
 drivers/usb/gadget/f_sdp.c                     | 16 ++---
 drivers/usb/gadget/f_thor.c                    | 26 ++++----
 drivers/usb/host/dwc2.c                        |  2 +-
 drivers/usb/host/ehci-generic.c                | 18 ++---
 drivers/usb/host/ohci-generic.c                | 18 ++---
 drivers/usb/host/xhci-dwc3.c                   |  6 +-
 drivers/usb/host/xhci-rockchip.c               | 12 ++--
 drivers/usb/musb-new/linux-compat.h            |  2 -
 drivers/usb/musb-new/ti-musb.c                 | 12 ++--
 drivers/video/am335x-fb.c                      |  2 +-
 env/common.c                                   |  8 +--
 env/sf.c                                       |  2 +-
 fs/jffs2/jffs2_nand_1pass.c                    |  2 +-
 fs/yaffs2/yaffs_uboot_glue.c                   |  2 +-
 include/common.h                               | 20 +-----
 include/linux/bug.h                            | 77 ++++++++-------------
 include/linux/build_bug.h                      | 84 +++++++++++++++++++++++
 include/linux/compat.h                         | 26 --------
 include/linux/compiler.h                       |  6 +-
 include/linux/mtd/mtd.h                        | 10 +--
 include/linux/printk.h                         | 77 +++++++++++++++++++++
 include/vsprintf.h                             |  1 +
 134 files changed, 719 insertions(+), 639 deletions(-)
 create mode 100644 include/linux/build_bug.h
 create mode 100644 include/linux/printk.h

Comments

Masahiro Yamada Sept. 14, 2017, 2:08 a.m. | #1
2017-09-13 20:45 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> buildman is 60% done, and no regression so far.
>
> I will report the full-stat when buildman is complete.
>
>

Finished buildman test.

No regression from the point of C grammar.

But, image size exceeded its platform limit
for some boards.
(ex. colibri_vf_defconfig)


This is because all pr_*() except pr_debug()
are now enabled.
So, more are more log message strings are compiled now.

Hmm, I need to implement
CONFIG_LOGLEVEL and CONFIG_SPL_LOGLEVEL now
to shut up lower priority log functions
such as pr_info(), pr_notice() ??

I will take a look.


The full-stat of buildman is as follows:




01: ARM: DRA72x: Add support for detection of DRA71x SR 2.1
   aarch64:  +   nanopi_neo2 bananapi_m64 orangepi_prime orangepi_pc2
pine64_plus orangepi_win a64-olinuxino evb-rk3328 nanopi_a64
sopine_baseboard orangepi_zero_plus2
       x86:  +   qemu-x86_64 qemu-x86_efi_payload64 chromebook_link64
       arm:  +   am43xx_hs_evm am57xx_hs_evm imx6qdl_icore_rqs
am335x_hs_evm ethernut5 am43xx_evm imx6qdl_icore_nand
imx6qdl_icore_mmc dra7xx_hs_evm am43xx_evm_usbhost_boot db-88f6720
am335x_evm am57xx_evm dra7xx_evm
     nds32:  +   adp-ag101p adp-ae3xx
+       src, &length)) {
+            ^
+In file included from ../common/spl/spl_fit.c:8:0:
+../include/common.h:627:5: note: expected 'long unsigned int *' but
argument is of type 'size_t * {aka unsigned int *}'
+ int gunzip(void *, int, unsigned char *, unsigned long *);
+     ^~~~~~
+   if (gunzip((void *)load_addr, CONFIG_SYS_BOOTM_LEN,
+       ^
+../include/common.h:627:5: note: expected 'long unsigned int *' but
argument is of type 'size_t *'
+     ^
+../arch/nds32/cpu/n1213/start.S: Assembler messages:
+../arch/nds32/cpu/n1213/start.S:109: Error: unknown pseudo-op: `.relax_hint'
+../arch/nds32/cpu/n1213/start.S:111: Error: unknown pseudo-op: `.relax_hint'
+../arch/nds32/cpu/n1213/start.S:113: Error: unrecognized form of
instruction `add5.pc $gp'
+make[2]: *** [../scripts/Makefile.build:316:
arch/nds32/cpu/n1213/start.o] Error 1
+make[1]: *** [Makefile:1279: arch/nds32/cpu/n1213] Error 2
+make: *** [Makefile:150: sub-make] Error 2
+arch/arm/dts/ethernut5.dtb: Warning (reg_format): "reg" property in
/i2c-gpio-0/pcf8563@50 has invalid length (4 bytes) (#address-cells ==
2, #size-cells == 1)
+arch/arm/dts/ethernut5.dtb: Warning (avoid_default_addr_size):
Relying on default #address-cells value for /i2c-gpio-0/pcf8563@50
+arch/arm/dts/ethernut5.dtb: Warning (avoid_default_addr_size):
Relying on default #size-cells value for /i2c-gpio-0/pcf8563@50
+WARNING: BL31 file bl31.bin NOT found, resulting binary is non-functional
+Please read the section on ARM Trusted Firmware (ATF) in
board/sunxi/README.sunxi64
+<stdout>: Warning (unit_address_vs_reg): Node /images/uboot@1 has a
unit name, but no reg property
+<stdout>: Warning (unit_address_vs_reg): Node /images/atf@1 has a
unit name, but no reg property
+<stdout>: Warning (unit_address_vs_reg): Node /images/fdt@1 has a
unit name, but no reg property
+<stdout>: Warning (unit_address_vs_reg): Node
/configurations/config@1 has a unit name, but no reg property
+<stdout>: Warning (unit_address_vs_reg): Node /images/fdt@2 has a
unit name, but no reg property
+<stdout>: Warning (unit_address_vs_reg): Node
/configurations/config@2 has a unit name, but no reg property
+  writel((unsigned int) ep->dma_buf, &reg->out_endp[ep_num].doepdma);
+         ^
+../arch/arm/include/asm/io.h:146:34: note: in definition of macro 'writel'
+ #define writel(v,c) ({ u32 __v = v; __iowmb(); __arch_putl(__v,c); __v; })
+                                  ^
+   port->priv->mdio_base = (void *)mdio_addr;
+                           ^
+../arch/x86/lib/crt0_x86_64_efi.S: Assembler messages:
+../arch/x86/lib/crt0_x86_64_efi.S:16: Error: bad register name `%rsp'
+../arch/x86/lib/crt0_x86_64_efi.S:17: Error: bad register name `%rcx'
+../arch/x86/lib/crt0_x86_64_efi.S:18: Error: bad register name `%rdx'
+../arch/x86/lib/crt0_x86_64_efi.S:21: Error: bad register name `%rip)'
+../arch/x86/lib/crt0_x86_64_efi.S:22: Error: bad register name `%rip)'
+../arch/x86/lib/crt0_x86_64_efi.S:24: Error: bad register name `%rcx'
+../arch/x86/lib/crt0_x86_64_efi.S:25: Error: bad register name `%rdx'
+../arch/x86/lib/crt0_x86_64_efi.S:26: Error: bad register name `%rcx'
+../arch/x86/lib/crt0_x86_64_efi.S:27: Error: bad register name `%rdx'
+../arch/x86/lib/crt0_x86_64_efi.S:30: Error: bad register name `%rdi'
+../arch/x86/lib/crt0_x86_64_efi.S:31: Error: bad register name `%rsi'
+../arch/x86/lib/crt0_x86_64_efi.S:34: Error: bad register name `%rsp'
+../arch/x86/lib/crt0_x86_64_efi.S:47: Warning: setting incorrect
section attributes for .reloc
+make[2]: *** [../scripts/Makefile.build:316:
arch/x86/lib/crt0_x86_64_efi.o] Error 1
+make[1]: *** [Makefile:1279: arch/x86/lib] Error 2
w+../common/spl/spl_fit.c: In function 'spl_load_fit_image':
w+../common/spl/spl_fit.c:201:12: warning: passing argument 4 of
'gunzip' from incompatible pointer type [-Wincompatible-pointer-types]
w+../common/spl/spl_fit.c:200:7: warning: passing argument 4 of
'gunzip' from incompatible pointer type
w+../drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c: In function 'setdma_rx':
w+../drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c:116:9: warning: cast
from pointer to integer of different size [-Wpointer-to-int-cast]
w+../drivers/net/mvpp2.c: In function 'phy_info_parse':
w+../drivers/net/mvpp2.c:4751:27: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
02: printk: collect printk stuff into <linux/printk.h>
       arm:  +   colibri_vf openrd_base vf610twr_nand openrd_ultimate
vf610twr openrd_client
-../include/common.h:627:5: note: expected 'long unsigned int *' but
argument is of type 'size_t * {aka unsigned int *}'
-../include/common.h:627:5: note: expected 'long unsigned int *' but
argument is of type 'size_t *'
+../include/common.h:623:5: note: expected 'long unsigned int *' but
argument is of type 'size_t * {aka unsigned int *}'
+../include/common.h:623:5: note: expected 'long unsigned int *' but
argument is of type 'size_t *'
+u-boot-nodtb.bin exceeds file size limit:
+  limit:  393216 bytes
+  actual: 434976 bytes
+  excess: 41760 bytes
+make[1]: *** [Makefile:945: u-boot-nodtb.bin] Error 1
+  limit:  524288 bytes
+  actual: 541568 bytes
+  excess: 17280 bytes
+  actual: 435000 bytes
+  excess: 41784 bytes
+  actual: 541520 bytes
+  excess: 17232 bytes
+  actual: 435024 bytes
+  excess: 41808 bytes
+  actual: 543952 bytes
+  excess: 19664 bytes
03: treewide: replace with error() with pr_err()
-  actual: 434976 bytes
-  excess: 41760 bytes
-  actual: 541568 bytes
-  excess: 17280 bytes
-  actual: 435000 bytes
-  excess: 41784 bytes
-  actual: 541520 bytes
-  excess: 17232 bytes
-  actual: 435024 bytes
-  excess: 41808 bytes
-  actual: 543952 bytes
-  excess: 19664 bytes
+  actual: 434624 bytes
+  excess: 41408 bytes
+  actual: 541184 bytes
+  excess: 16896 bytes
+  actual: 434656 bytes
+  excess: 41440 bytes
+  actual: 541136 bytes
+  excess: 16848 bytes
+  actual: 434672 bytes
+  excess: 41456 bytes
+  actual: 542608 bytes
+  excess: 18320 bytes
04: common.h: remove error()
-../include/common.h:623:5: note: expected 'long unsigned int *' but
argument is of type 'size_t * {aka unsigned int *}'
-../include/common.h:623:5: note: expected 'long unsigned int *' but
argument is of type 'size_t *'
+../include/common.h:618:5: note: expected 'long unsigned int *' but
argument is of type 'size_t * {aka unsigned int *}'
+../include/common.h:618:5: note: expected 'long unsigned int *' but
argument is of type 'size_t *'
05: vsprintf.h: include <linux/types.h>
06: bug.h: sync BUILD_BUG stuff with Linux 4.13
07: bug.h: move runtime BUG/WARN macros into <linux/bug.h>
-../include/common.h:618:5: note: expected 'long unsigned int *' but
argument is of type 'size_t * {aka unsigned int *}'
-../include/common.h:618:5: note: expected 'long unsigned int *' but
argument is of type 'size_t *'
-  actual: 434624 bytes
-  excess: 41408 bytes
-  actual: 541184 bytes
-  excess: 16896 bytes
-  actual: 434656 bytes
-  excess: 41440 bytes
-  actual: 541136 bytes
-  excess: 16848 bytes
-  actual: 434672 bytes
-  excess: 41456 bytes
-  actual: 542608 bytes
-  excess: 18320 bytes
+../include/common.h:611:5: note: expected 'long unsigned int *' but
argument is of type 'size_t * {aka unsigned int *}'
+../include/common.h:611:5: note: expected 'long unsigned int *' but
argument is of type 'size_t *'
+  actual: 434760 bytes
+  excess: 41544 bytes
+  actual: 541312 bytes
+  excess: 17024 bytes
+  actual: 434784 bytes
+  excess: 41568 bytes
+  actual: 541272 bytes
+  excess: 16984 bytes
+  actual: 434800 bytes
+  excess: 41584 bytes
+  actual: 542840 bytes
+  excess: 18552 bytes