[for-4.14.y,0/5] e1000e: Upstream fixes for linux-4.14.y

Message ID 1511787217-10987-1-git-send-email-amit.pundir@linaro.org
Headers show
Series
  • e1000e: Upstream fixes for linux-4.14.y
Related show

Message

Amit Pundir Nov. 27, 2017, 12:53 p.m.
Hi Greg,

Found few e100e upstream fixes from Benjamin Poirier in lede
source tree, https://git.lede-project.org/?p=source.git, and
these fixes seem reasonable enough for 4.14.y too.

Also submitting an e1000e buffer overrun fix by Sasha Neftin.

Cherry-picked and build tested for linux v4.14.2 for ARCH=arm/arm64.

Regards,
Amit Pundir


Benjamin Poirier (4):
  e1000e: Fix error path in link detection
  e1000e: Fix return value test
  e1000e: Separate signaling for link check/link up
  e1000e: Avoid receiver overrun interrupt bursts

Sasha Neftin (1):
  e1000e: fix buffer overrun while the I219 is processing DMA
    transactions

 drivers/net/ethernet/intel/e1000e/defines.h |  1 +
 drivers/net/ethernet/intel/e1000e/mac.c     | 11 +++++--
 drivers/net/ethernet/intel/e1000e/netdev.c  | 45 ++++++++++++++++++++---------
 drivers/net/ethernet/intel/e1000e/phy.c     |  7 +++--
 4 files changed, 45 insertions(+), 19 deletions(-)

-- 
2.7.4

Comments

Amit Pundir Nov. 27, 2017, 1:09 p.m. | #1
+ Jeff and intel-wired-lan (moderated) mailing list.

On 27 November 2017 at 18:29, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Nov 27, 2017 at 06:23:32PM +0530, Amit Pundir wrote:

>> Hi Greg,

>>

>> Found few e100e upstream fixes from Benjamin Poirier in lede

>> source tree, https://git.lede-project.org/?p=source.git, and

>> these fixes seem reasonable enough for 4.14.y too.

>>

>> Also submitting an e1000e buffer overrun fix by Sasha Neftin.

>>

>> Cherry-picked and build tested for linux v4.14.2 for ARCH=arm/arm64.

>

>

> Any reason you did not cc: the maintainers for this driver and their

> mailing list?


No reason at all. Thanks for pointing that out. It didn't occur to me
to do that. I was marking only patch authors in cover letters so far.
I'll start adding respective maintainers and mailing list going
forward.

>

> Also, why is the maintainers of this driver not marking anything for

> stable?  They never do, is that for a reason?

>

> thanks,

>

> greg k-h


Regards,
Amit Pundir
Amit Pundir Nov. 27, 2017, 1:36 p.m. | #2
On 27 November 2017 at 18:23, Amit Pundir <amit.pundir@linaro.org> wrote:
> Hi Greg,

>

> Found few e100e upstream fixes from Benjamin Poirier in lede

> source tree, https://git.lede-project.org/?p=source.git, and

> these fixes seem reasonable enough for 4.14.y too.

>

> Also submitting an e1000e buffer overrun fix by Sasha Neftin.

>

> Cherry-picked and build tested for linux v4.14.2 for ARCH=arm/arm64.

>

> Regards,

> Amit Pundir

>

>

> Benjamin Poirier (4):

>   e1000e: Fix error path in link detection

>   e1000e: Fix return value test

>   e1000e: Separate signaling for link check/link up

>   e1000e: Avoid receiver overrun interrupt bursts


Also all the above fixes from Benjamin Poirier are to be marked for
4.9 and first 3 fixes for 4.4, 3.18 as well. Build tested for
ARCH=arm/arm64.

Regards,
Amit Pundir

>

> Sasha Neftin (1):

>   e1000e: fix buffer overrun while the I219 is processing DMA

>     transactions

>

>  drivers/net/ethernet/intel/e1000e/defines.h |  1 +

>  drivers/net/ethernet/intel/e1000e/mac.c     | 11 +++++--

>  drivers/net/ethernet/intel/e1000e/netdev.c  | 45 ++++++++++++++++++++---------

>  drivers/net/ethernet/intel/e1000e/phy.c     |  7 +++--

>  4 files changed, 45 insertions(+), 19 deletions(-)

>

> --

> 2.7.4

>
Greg Kroah-Hartman Nov. 28, 2017, 9:24 a.m. | #3
On Mon, Nov 27, 2017 at 06:39:47PM +0530, Amit Pundir wrote:
> + Jeff and intel-wired-lan (moderated) mailing list.

> 

> On 27 November 2017 at 18:29, Greg KH <gregkh@linuxfoundation.org> wrote:

> > On Mon, Nov 27, 2017 at 06:23:32PM +0530, Amit Pundir wrote:

> >> Hi Greg,

> >>

> >> Found few e100e upstream fixes from Benjamin Poirier in lede

> >> source tree, https://git.lede-project.org/?p=source.git, and

> >> these fixes seem reasonable enough for 4.14.y too.

> >>

> >> Also submitting an e1000e buffer overrun fix by Sasha Neftin.

> >>

> >> Cherry-picked and build tested for linux v4.14.2 for ARCH=arm/arm64.

> >

> >

> > Any reason you did not cc: the maintainers for this driver and their

> > mailing list?

> 

> No reason at all. Thanks for pointing that out. It didn't occur to me

> to do that. I was marking only patch authors in cover letters so far.

> I'll start adding respective maintainers and mailing list going

> forward.


Thanks, please do that.  All now queued up.

greg k-h
Christian Hesse Dec. 4, 2017, 3:47 p.m. | #4
Amit Pundir <amit.pundir@linaro.org> on Mon, 2017/11/27 18:23:
> Hi Greg,

> 

> Found few e100e upstream fixes from Benjamin Poirier in lede

> source tree, https://git.lede-project.org/?p=source.git, and

> these fixes seem reasonable enough for 4.14.y too.

> 

> Also submitting an e1000e buffer overrun fix by Sasha Neftin.

> 

> Cherry-picked and build tested for linux v4.14.2 for ARCH=arm/arm64.

> 

> Regards,

> Amit Pundir

> 

> 

> Benjamin Poirier (4):

>   e1000e: Fix error path in link detection

>   e1000e: Fix return value test

>   e1000e: Separate signaling for link check/link up

>   e1000e: Avoid receiver overrun interrupt bursts

> 

> Sasha Neftin (1):

>   e1000e: fix buffer overrun while the I219 is processing DMA

>     transactions


Hello everybody,

looks like one of these breaks connectivity on my Thinkpad X250.
Just downgraded to linux 4.14.2 to verify.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
Greg Kroah-Hartman Dec. 4, 2017, 6:37 p.m. | #5
On Mon, Dec 04, 2017 at 04:47:00PM +0100, Christian Hesse wrote:
> Amit Pundir <amit.pundir@linaro.org> on Mon, 2017/11/27 18:23:

> > Hi Greg,

> > 

> > Found few e100e upstream fixes from Benjamin Poirier in lede

> > source tree, https://git.lede-project.org/?p=source.git, and

> > these fixes seem reasonable enough for 4.14.y too.

> > 

> > Also submitting an e1000e buffer overrun fix by Sasha Neftin.

> > 

> > Cherry-picked and build tested for linux v4.14.2 for ARCH=arm/arm64.

> > 

> > Regards,

> > Amit Pundir

> > 

> > 

> > Benjamin Poirier (4):

> >   e1000e: Fix error path in link detection

> >   e1000e: Fix return value test

> >   e1000e: Separate signaling for link check/link up

> >   e1000e: Avoid receiver overrun interrupt bursts

> > 

> > Sasha Neftin (1):

> >   e1000e: fix buffer overrun while the I219 is processing DMA

> >     transactions

> 

> Hello everybody,

> 

> looks like one of these breaks connectivity on my Thinkpad X250.

> Just downgraded to linux 4.14.2 to verify.


Can you try the -rc release I just did?  It has a fix for this series in
it.

thanks,

greg k-h
Christian Hesse Dec. 5, 2017, 7:23 a.m. | #6
Greg KH <gregkh@linuxfoundation.org> on Mon, 2017/12/04 19:37:
> On Mon, Dec 04, 2017 at 04:47:00PM +0100, Christian Hesse wrote:

> > Amit Pundir <amit.pundir@linaro.org> on Mon, 2017/11/27 18:23:  

> > > Hi Greg,

> > > 

> > > Found few e100e upstream fixes from Benjamin Poirier in lede

> > > source tree, https://git.lede-project.org/?p=source.git, and

> > > these fixes seem reasonable enough for 4.14.y too.

> > > 

> > > Also submitting an e1000e buffer overrun fix by Sasha Neftin.

> > > 

> > > Cherry-picked and build tested for linux v4.14.2 for ARCH=arm/arm64.

> > > 

> > > Regards,

> > > Amit Pundir

> > > 

> > > 

> > > Benjamin Poirier (4):

> > >   e1000e: Fix error path in link detection

> > >   e1000e: Fix return value test

> > >   e1000e: Separate signaling for link check/link up

> > >   e1000e: Avoid receiver overrun interrupt bursts

> > > 

> > > Sasha Neftin (1):

> > >   e1000e: fix buffer overrun while the I219 is processing DMA

> > >     transactions  

> > 

> > Hello everybody,

> > 

> > looks like one of these breaks connectivity on my Thinkpad X250.

> > Just downgraded to linux 4.14.2 to verify.  

> 

> Can you try the -rc release I just did?  It has a fix for this series in

> it.


It connects with the notebook's built in ethernet port (did not check with
4.14.3) but still fails to see a link when placed in docking station.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
Greg Kroah-Hartman Dec. 5, 2017, 7:35 a.m. | #7
On Tue, Dec 05, 2017 at 08:23:27AM +0100, Christian Hesse wrote:
> Greg KH <gregkh@linuxfoundation.org> on Mon, 2017/12/04 19:37:

> > On Mon, Dec 04, 2017 at 04:47:00PM +0100, Christian Hesse wrote:

> > > Amit Pundir <amit.pundir@linaro.org> on Mon, 2017/11/27 18:23:  

> > > > Hi Greg,

> > > > 

> > > > Found few e100e upstream fixes from Benjamin Poirier in lede

> > > > source tree, https://git.lede-project.org/?p=source.git, and

> > > > these fixes seem reasonable enough for 4.14.y too.

> > > > 

> > > > Also submitting an e1000e buffer overrun fix by Sasha Neftin.

> > > > 

> > > > Cherry-picked and build tested for linux v4.14.2 for ARCH=arm/arm64.

> > > > 

> > > > Regards,

> > > > Amit Pundir

> > > > 

> > > > 

> > > > Benjamin Poirier (4):

> > > >   e1000e: Fix error path in link detection

> > > >   e1000e: Fix return value test

> > > >   e1000e: Separate signaling for link check/link up

> > > >   e1000e: Avoid receiver overrun interrupt bursts

> > > > 

> > > > Sasha Neftin (1):

> > > >   e1000e: fix buffer overrun while the I219 is processing DMA

> > > >     transactions  

> > > 

> > > Hello everybody,

> > > 

> > > looks like one of these breaks connectivity on my Thinkpad X250.

> > > Just downgraded to linux 4.14.2 to verify.  

> > 

> > Can you try the -rc release I just did?  It has a fix for this series in

> > it.

> 

> It connects with the notebook's built in ethernet port (did not check with

> 4.14.3) but still fails to see a link when placed in docking station.


Do you have the same issues with 4.15-rc2?

thanks,

greg k-h
Christian Hesse Dec. 11, 2017, 9:58 p.m. | #8
Greg KH <gregkh@linuxfoundation.org> on Tue, 2017/12/05 08:35:
> On Tue, Dec 05, 2017 at 08:23:27AM +0100, Christian Hesse wrote:

> > Greg KH <gregkh@linuxfoundation.org> on Mon, 2017/12/04 19:37:  

> > > On Mon, Dec 04, 2017 at 04:47:00PM +0100, Christian Hesse wrote:  

> > > > Amit Pundir <amit.pundir@linaro.org> on Mon, 2017/11/27 18:23:    

> > > > > Hi Greg,

> > > > > 

> > > > > Found few e100e upstream fixes from Benjamin Poirier in lede

> > > > > source tree, https://git.lede-project.org/?p=source.git, and

> > > > > these fixes seem reasonable enough for 4.14.y too.

> > > > > 

> > > > > Also submitting an e1000e buffer overrun fix by Sasha Neftin.

> > > > > 

> > > > > Cherry-picked and build tested for linux v4.14.2 for ARCH=arm/arm64.

> > > > > 

> > > > > Regards,

> > > > > Amit Pundir

> > > > > 

> > > > > 

> > > > > Benjamin Poirier (4):

> > > > >   e1000e: Fix error path in link detection

> > > > >   e1000e: Fix return value test

> > > > >   e1000e: Separate signaling for link check/link up

> > > > >   e1000e: Avoid receiver overrun interrupt bursts

> > > > > 

> > > > > Sasha Neftin (1):

> > > > >   e1000e: fix buffer overrun while the I219 is processing DMA

> > > > >     transactions    

> > > > 

> > > > Hello everybody,

> > > > 

> > > > looks like one of these breaks connectivity on my Thinkpad X250.

> > > > Just downgraded to linux 4.14.2 to verify.    

> > > 

> > > Can you try the -rc release I just did?  It has a fix for this series in

> > > it.  

> > 

> > It connects with the notebook's built in ethernet port (did not check with

> > 4.14.3) but still fails to see a link when placed in docking station.  

> 

> Do you have the same issues with 4.15-rc2?


Just a short heads-up and final result for this thread...
The issue is fixed with Benjamin's patch:

https://patchwork.kernel.org/patch/10104349/
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
Greg Kroah-Hartman Dec. 18, 2017, 11:59 a.m. | #9
On Mon, Dec 11, 2017 at 10:58:10PM +0100, Christian Hesse wrote:
> Greg KH <gregkh@linuxfoundation.org> on Tue, 2017/12/05 08:35:

> > On Tue, Dec 05, 2017 at 08:23:27AM +0100, Christian Hesse wrote:

> > > Greg KH <gregkh@linuxfoundation.org> on Mon, 2017/12/04 19:37:  

> > > > On Mon, Dec 04, 2017 at 04:47:00PM +0100, Christian Hesse wrote:  

> > > > > Amit Pundir <amit.pundir@linaro.org> on Mon, 2017/11/27 18:23:    

> > > > > > Hi Greg,

> > > > > > 

> > > > > > Found few e100e upstream fixes from Benjamin Poirier in lede

> > > > > > source tree, https://git.lede-project.org/?p=source.git, and

> > > > > > these fixes seem reasonable enough for 4.14.y too.

> > > > > > 

> > > > > > Also submitting an e1000e buffer overrun fix by Sasha Neftin.

> > > > > > 

> > > > > > Cherry-picked and build tested for linux v4.14.2 for ARCH=arm/arm64.

> > > > > > 

> > > > > > Regards,

> > > > > > Amit Pundir

> > > > > > 

> > > > > > 

> > > > > > Benjamin Poirier (4):

> > > > > >   e1000e: Fix error path in link detection

> > > > > >   e1000e: Fix return value test

> > > > > >   e1000e: Separate signaling for link check/link up

> > > > > >   e1000e: Avoid receiver overrun interrupt bursts

> > > > > > 

> > > > > > Sasha Neftin (1):

> > > > > >   e1000e: fix buffer overrun while the I219 is processing DMA

> > > > > >     transactions    

> > > > > 

> > > > > Hello everybody,

> > > > > 

> > > > > looks like one of these breaks connectivity on my Thinkpad X250.

> > > > > Just downgraded to linux 4.14.2 to verify.    

> > > > 

> > > > Can you try the -rc release I just did?  It has a fix for this series in

> > > > it.  

> > > 

> > > It connects with the notebook's built in ethernet port (did not check with

> > > 4.14.3) but still fails to see a link when placed in docking station.  

> > 

> > Do you have the same issues with 4.15-rc2?

> 

> Just a short heads-up and final result for this thread...

> The issue is fixed with Benjamin's patch:

> 

> https://patchwork.kernel.org/patch/10104349/


Any word on getting this patch into Linus's tree anytime soon?

thanks,

greg k-h
Benjamin Poirier Dec. 19, 2017, 1:10 a.m. | #10
On 2017/12/18 12:59, Greg KH wrote:
> On Mon, Dec 11, 2017 at 10:58:10PM +0100, Christian Hesse wrote:

> > Greg KH <gregkh@linuxfoundation.org> on Tue, 2017/12/05 08:35:

> > > On Tue, Dec 05, 2017 at 08:23:27AM +0100, Christian Hesse wrote:

> > > > Greg KH <gregkh@linuxfoundation.org> on Mon, 2017/12/04 19:37:  

> > > > > On Mon, Dec 04, 2017 at 04:47:00PM +0100, Christian Hesse wrote:  

> > > > > > Amit Pundir <amit.pundir@linaro.org> on Mon, 2017/11/27 18:23:    

> > > > > > > Hi Greg,

> > > > > > > 

> > > > > > > Found few e100e upstream fixes from Benjamin Poirier in lede

> > > > > > > source tree, https://git.lede-project.org/?p=source.git, and

> > > > > > > these fixes seem reasonable enough for 4.14.y too.

> > > > > > > 

> > > > > > > Also submitting an e1000e buffer overrun fix by Sasha Neftin.

> > > > > > > 

> > > > > > > Cherry-picked and build tested for linux v4.14.2 for ARCH=arm/arm64.

> > > > > > > 

> > > > > > > Regards,

> > > > > > > Amit Pundir

> > > > > > > 

> > > > > > > 

> > > > > > > Benjamin Poirier (4):

> > > > > > >   e1000e: Fix error path in link detection

> > > > > > >   e1000e: Fix return value test

> > > > > > >   e1000e: Separate signaling for link check/link up

> > > > > > >   e1000e: Avoid receiver overrun interrupt bursts

> > > > > > > 

> > > > > > > Sasha Neftin (1):

> > > > > > >   e1000e: fix buffer overrun while the I219 is processing DMA

> > > > > > >     transactions    

> > > > > > 

> > > > > > Hello everybody,

> > > > > > 

> > > > > > looks like one of these breaks connectivity on my Thinkpad X250.

> > > > > > Just downgraded to linux 4.14.2 to verify.    

> > > > > 

> > > > > Can you try the -rc release I just did?  It has a fix for this series in

> > > > > it.  

> > > > 

> > > > It connects with the notebook's built in ethernet port (did not check with

> > > > 4.14.3) but still fails to see a link when placed in docking station.  

> > > 

> > > Do you have the same issues with 4.15-rc2?

> > 

> > Just a short heads-up and final result for this thread...

> > The issue is fixed with Benjamin's patch:

> > 

> > https://patchwork.kernel.org/patch/10104349/

> 

> Any word on getting this patch into Linus's tree anytime soon?


Apparently the intel maintainer was unavailable recently:
https://www.mail-archive.com/netdev@vger.kernel.org/msg206192.html

The patch is now in there:
https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git/log/?h=dev-queue
but that only makes it slated for 4.16 AFAIK.

Jeff, given that this issue breaks networking for many people, wouldn't
it be more appropriate to submit the patch for 4.15?
Jeff Kirsher Dec. 19, 2017, 11:27 p.m. | #11
On Tue, 2017-12-19 at 10:10 +0900, Benjamin Poirier wrote:
> On 2017/12/18 12:59, Greg KH wrote:

> > On Mon, Dec 11, 2017 at 10:58:10PM +0100, Christian Hesse wrote:

> > > Greg KH <gregkh@linuxfoundation.org> on Tue, 2017/12/05 08:35:

> > > > On Tue, Dec 05, 2017 at 08:23:27AM +0100, Christian Hesse wrote:

> > > > > Greg KH <gregkh@linuxfoundation.org> on Mon, 2017/12/04 19:37:  

> > > > > > On Mon, Dec 04, 2017 at 04:47:00PM +0100, Christian Hesse

> > > > > > wrote:  

> > > > > > > Amit Pundir <amit.pundir@linaro.org> on Mon, 2017/11/27

> > > > > > > 18:23:    

> > > > > > > > Hi Greg,

> > > > > > > > 

> > > > > > > > Found few e100e upstream fixes from Benjamin Poirier in

> > > > > > > > lede

> > > > > > > > source tree, https://git.lede-project.org/?p=source.git,

> > > > > > > > and

> > > > > > > > these fixes seem reasonable enough for 4.14.y too.

> > > > > > > > 

> > > > > > > > Also submitting an e1000e buffer overrun fix by Sasha

> > > > > > > > Neftin.

> > > > > > > > 

> > > > > > > > Cherry-picked and build tested for linux v4.14.2 for

> > > > > > > > ARCH=arm/arm64.

> > > > > > > > 

> > > > > > > > Regards,

> > > > > > > > Amit Pundir

> > > > > > > > 

> > > > > > > > 

> > > > > > > > Benjamin Poirier (4):

> > > > > > > >   e1000e: Fix error path in link detection

> > > > > > > >   e1000e: Fix return value test

> > > > > > > >   e1000e: Separate signaling for link check/link up

> > > > > > > >   e1000e: Avoid receiver overrun interrupt bursts

> > > > > > > > 

> > > > > > > > Sasha Neftin (1):

> > > > > > > >   e1000e: fix buffer overrun while the I219 is processing

> > > > > > > > DMA

> > > > > > > >     transactions    

> > > > > > > 

> > > > > > > Hello everybody,

> > > > > > > 

> > > > > > > looks like one of these breaks connectivity on my Thinkpad

> > > > > > > X250.

> > > > > > > Just downgraded to linux 4.14.2 to verify.    

> > > > > > 

> > > > > > Can you try the -rc release I just did?  It has a fix for this

> > > > > > series in

> > > > > > it.  

> > > > > 

> > > > > It connects with the notebook's built in ethernet port (did not

> > > > > check with

> > > > > 4.14.3) but still fails to see a link when placed in docking

> > > > > station.  

> > > > 

> > > > Do you have the same issues with 4.15-rc2?

> > > 

> > > Just a short heads-up and final result for this thread...

> > > The issue is fixed with Benjamin's patch:

> > > 

> > > https://patchwork.kernel.org/patch/10104349/

> > 

> > Any word on getting this patch into Linus's tree anytime soon?

> 

> Apparently the intel maintainer was unavailable recently:

> https://www.mail-archive.com/netdev@vger.kernel.org/msg206192.html

> 

> The patch is now in there:

> https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git/l

> og/?h=dev-queue

> but that only makes it slated for 4.16 AFAIK.

> 

> Jeff, given that this issue breaks networking for many people, wouldn't

> it be more appropriate to submit the patch for 4.15?


Yeah, I will send to Dave's net tree (4.15) for inclusion.
Benjamin Poirier Jan. 1, 2018, 3:53 a.m. | #12
On 2017/12/19 15:27, Jeff Kirsher wrote:
> On Tue, 2017-12-19 at 10:10 +0900, Benjamin Poirier wrote:

> > On 2017/12/18 12:59, Greg KH wrote:

> > > On Mon, Dec 11, 2017 at 10:58:10PM +0100, Christian Hesse wrote:

> > > > Greg KH <gregkh@linuxfoundation.org> on Tue, 2017/12/05 08:35:

> > > > > On Tue, Dec 05, 2017 at 08:23:27AM +0100, Christian Hesse wrote:

> > > > > > Greg KH <gregkh@linuxfoundation.org> on Mon, 2017/12/04 19:37:  

> > > > > > > On Mon, Dec 04, 2017 at 04:47:00PM +0100, Christian Hesse

> > > > > > > wrote:  

> > > > > > > > Amit Pundir <amit.pundir@linaro.org> on Mon, 2017/11/27

> > > > > > > > 18:23:    

> > > > > > > > > Hi Greg,

> > > > > > > > > 

> > > > > > > > > Found few e100e upstream fixes from Benjamin Poirier in

> > > > > > > > > lede

> > > > > > > > > source tree, https://git.lede-project.org/?p=source.git,

> > > > > > > > > and

> > > > > > > > > these fixes seem reasonable enough for 4.14.y too.

> > > > > > > > > 

> > > > > > > > > Also submitting an e1000e buffer overrun fix by Sasha

> > > > > > > > > Neftin.

> > > > > > > > > 

> > > > > > > > > Cherry-picked and build tested for linux v4.14.2 for

> > > > > > > > > ARCH=arm/arm64.

> > > > > > > > > 

> > > > > > > > > Regards,

> > > > > > > > > Amit Pundir

> > > > > > > > > 

> > > > > > > > > 

> > > > > > > > > Benjamin Poirier (4):

> > > > > > > > >   e1000e: Fix error path in link detection

> > > > > > > > >   e1000e: Fix return value test

> > > > > > > > >   e1000e: Separate signaling for link check/link up

> > > > > > > > >   e1000e: Avoid receiver overrun interrupt bursts

> > > > > > > > > 

> > > > > > > > > Sasha Neftin (1):

> > > > > > > > >   e1000e: fix buffer overrun while the I219 is processing

> > > > > > > > > DMA

> > > > > > > > >     transactions    

> > > > > > > > 

> > > > > > > > Hello everybody,

> > > > > > > > 

> > > > > > > > looks like one of these breaks connectivity on my Thinkpad

> > > > > > > > X250.

> > > > > > > > Just downgraded to linux 4.14.2 to verify.    

> > > > > > > 

> > > > > > > Can you try the -rc release I just did?  It has a fix for this

> > > > > > > series in

> > > > > > > it.  

> > > > > > 

> > > > > > It connects with the notebook's built in ethernet port (did not

> > > > > > check with

> > > > > > 4.14.3) but still fails to see a link when placed in docking

> > > > > > station.  

> > > > > 

> > > > > Do you have the same issues with 4.15-rc2?

> > > > 

> > > > Just a short heads-up and final result for this thread...

> > > > The issue is fixed with Benjamin's patch:

> > > > 

> > > > https://patchwork.kernel.org/patch/10104349/

> > > 

> > > Any word on getting this patch into Linus's tree anytime soon?

> > 

> > Apparently the intel maintainer was unavailable recently:

> > https://www.mail-archive.com/netdev@vger.kernel.org/msg206192.html

> > 

> > The patch is now in there:

> > https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git/l

> > og/?h=dev-queue

> > but that only makes it slated for 4.16 AFAIK.

> > 

> > Jeff, given that this issue breaks networking for many people, wouldn't

> > it be more appropriate to submit the patch for 4.15?

> 

> Yeah, I will send to Dave's net tree (4.15) for inclusion.


Jeff, I see that the patch is still in your "next-queue". Meanwhile
another 4.15 rc has been released and I've gotten more user reports that
e1000e is broken.