mbox series

[0/4] media: ov2680: follow up from initial version

Message ID 20180507155655.1555-1-rui.silva@linaro.org
Headers show
Series media: ov2680: follow up from initial version | expand

Message

Rui Miguel Silva May 7, 2018, 3:56 p.m. UTC
Sorry I have Out-of-Office some part of last week, I had v6 of the original
series ready but since I have received the notification from patchwork that the
v5 was accepted, I am sending this as a follow up tha address Fabio comments.

- this adds the power supplies to this sensor
- fix gpio polarity and naming.

Cheers,
   Rui


Rui Miguel Silva (4):
  media: ov2680: dt: add voltage supplies as required
  media: ov2680: dt: rename gpio to reset and fix polarity
  media: ov2680: rename powerdown gpio and fix polarity
  media: ov2680: add regulators to supply control

 .../devicetree/bindings/media/i2c/ov2680.txt  | 18 ++++--
 drivers/media/i2c/ov2680.c                    | 55 +++++++++++++++----
 2 files changed, 57 insertions(+), 16 deletions(-)

-- 
2.17.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Fabio Estevam May 8, 2018, 1:29 p.m. UTC | #1
Hi Rui,

On Mon, May 7, 2018 at 12:56 PM, Rui Miguel Silva <rui.silva@linaro.org> wrote:
> Sorry I have Out-of-Office some part of last week, I had v6 of the original

> series ready but since I have received the notification from patchwork that the

> v5 was accepted, I am sending this as a follow up tha address Fabio comments.

>

> - this adds the power supplies to this sensor

> - fix gpio polarity and naming.

>

> Cheers,

>    Rui

>

>

> Rui Miguel Silva (4):

>   media: ov2680: dt: add voltage supplies as required

>   media: ov2680: dt: rename gpio to reset and fix polarity

>   media: ov2680: rename powerdown gpio and fix polarity

>   media: ov2680: add regulators to supply control


As the initial ov2680 series has not been applied, I think it would be
better if you send a new version with all these fixes.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rui Miguel Silva May 8, 2018, 1:52 p.m. UTC | #2
Ola Fabio,
On Tue 08 May 2018 at 13:29, Fabio Estevam wrote:
> Hi Rui,

>

> On Mon, May 7, 2018 at 12:56 PM, Rui Miguel Silva 

> <rui.silva@linaro.org> wrote:

>> Sorry I have Out-of-Office some part of last week, I had v6 of 

>> the original

>> series ready but since I have received the notification from 

>> patchwork that the

>> v5 was accepted, I am sending this as a follow up tha address 

>> Fabio comments.

>>

>> - this adds the power supplies to this sensor

>> - fix gpio polarity and naming.

>>

>> Cheers,

>>    Rui

>>

>>

>> Rui Miguel Silva (4):

>>   media: ov2680: dt: add voltage supplies as required

>>   media: ov2680: dt: rename gpio to reset and fix polarity

>>   media: ov2680: rename powerdown gpio and fix polarity

>>   media: ov2680: add regulators to supply control

>

> As the initial ov2680 series has not been applied, I think it 

> would be

> better if you send a new version with all these fixes.


What I've got was this from patchwork:
Hello,

The following patches (submitted by you) have been updated in 
patchwork:

 * linux-media: [v5,1/2] media: ov2680: dt: Add bindings for 
 OV2680
     - http://patchwork.linuxtv.org/patch/48819/
     - for: Linux Media kernel patches
    was: New
    now: Accepted

 * linux-media: [v4,1/2] media: ov2680: dt: Add bindings for 
 OV2680
     - http://patchwork.linuxtv.org/patch/48357/
     - for: Linux Media kernel patches
    was: New
    now: Accepted

This email is a notification only - you do not need to respond.

-

Patches submitted to linux-media@vger.kernel.org have the 
following
possible states:

<snip>

Accepted: when some driver maintainer says that the patch will be 
applied
	  via his tree, or when everything is ok and it got 
	  applied
	  either at the main tree or via some other tree (fixes 
	  tree;
	  some other maintainer's tree - when it belongs to other 
	  subsystems,
	  etc);

So, my understand is that the patches will be applied or are 
already
applied to someone tree (strange patchwork does not send who or 
which
tree), but since I do not want to break someone workflow I will 
wait for
some maintainer word on this... If it is better to send the 
original series
or the follow up patches.

Thanks for your feedback.
---
Cheers,
	Rui

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Fabio Estevam May 8, 2018, 1:55 p.m. UTC | #3
Hi Rui,

On Tue, May 8, 2018 at 10:52 AM, Rui Miguel Silva <rui.silva@linaro.org> wrote:

> So, my understand is that the patches will be applied or are already

> applied to someone tree (strange patchwork does not send who or which

> tree), but since I do not want to break someone workflow I will wait for

> some maintainer word on this... If it is better to send the original series

> or the follow up patches.


Ah, didn't know it has been applied. It seems it will soon appear in
linux-next then.

In this case, the follow up series makes sense.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sakari Ailus May 8, 2018, 8:03 p.m. UTC | #4
Hi,

On Mon, May 07, 2018 at 04:56:51PM +0100, Rui Miguel Silva wrote:
> Sorry I have Out-of-Office some part of last week, I had v6 of the original

> series ready but since I have received the notification from patchwork that the

> v5 was accepted, I am sending this as a follow up tha address Fabio comments.


I think I somehow managed to get the patchwork state wrong; the original
ov2680 set hasn't been applied yet. The latest patches I have applied are
here:

<URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=for-4.18-3>

Could you merge this to the original set and resend, please?

-- 
Kind regards,

Sakari Ailus
sakari.ailus@linux.intel.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html