| Message ID | cover.1525787469.git.crobinso@redhat.com |
|---|---|
| Headers | show |
| Series | spec: drop deprecated el5 bits | expand |
On Tue, May 08, 2018 at 09:53:22AM -0400, Cole Robinson wrote: > 2 patches from a Fedora contributor, 1 from me, dropping spec bits > that aren't required on el6 and later builds > > Cole Robinson (1): > spec: Remove Group: tags > > Igor Gnatenko (2): > spec: Remove BuildRoot definition > spec: Remove %clean section > > libvirt.spec.in | 45 --------------------------------------------- > 1 file changed, 45 deletions(-) For all threee Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel
On Tue, 2018-05-08 at 09:53 -0400, Cole Robinson wrote: > 2 patches from a Fedora contributor, 1 from me, dropping spec bits > that aren't required on el6 and later builds Note that we no longer support building on CentOS 6 either, so maybe there are more cleanup opportunities there... -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 05/09/2018 05:01 AM, Andrea Bolognani wrote: > On Tue, 2018-05-08 at 09:53 -0400, Cole Robinson wrote: >> 2 patches from a Fedora contributor, 1 from me, dropping spec bits >> that aren't required on el6 and later builds > > Note that we no longer support building on CentOS 6 either, so > maybe there are more cleanup opportunities there... > On a quick glance I don't see any of this type of RPM boiler plate that can be dropped, much of that was tied to RHEL5 compat. But there's definitely a lot of 0%{?rhel} >= 7 conditionals which are redundant now, which leads to dropping non-systemd and non-systemd-macros stuff which is quite nice - Cole -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list