mbox series

[v3,0/4] kconfig: refactor package checks for GUI frontends

Message ID 1526973741-664-1-git-send-email-yamada.masahiro@socionext.com
Headers show
Series kconfig: refactor package checks for GUI frontends | expand

Message

Masahiro Yamada May 22, 2018, 7:22 a.m. UTC
Kconfig supports 4 GUI frontends.
Each of them needs some support packages, but checks them differently:

  qconf, gconf: check packages in Makefile (pkg-config is required)
  mconf: lxdialog/check-lxdialog.sh
  nconf: needs ncurses, but its presence is not checked

This series refactor the package checks so that all of them work
in the same way.

The package check scripts have been moved to scripts/kconfig/*conf-cfg.sh

The motivation of this clean-up is Randy's following patch:
https://patchwork.kernel.org/patch/10277723/

I want to clean up existing code before adding more checks.


Masahiro Yamada (4):
  kbuild: do not display CHK for filechk
  kconfig: refactor Qt package checks for building qconf
  kconfig: refactor GTK+ package checks for building gconf
  kconfig: refactor ncurses package checks for building mconf and nconf

 scripts/Kbuild.include                     |   1 -
 scripts/kconfig/Makefile                   | 168 ++++++++++-------------------
 scripts/kconfig/gconf-cfg.sh               |  23 ++++
 scripts/kconfig/lxdialog/check-lxdialog.sh |  93 ----------------
 scripts/kconfig/lxdialog/dialog.h          |   2 +-
 scripts/kconfig/mconf-cfg.sh               |  44 ++++++++
 scripts/kconfig/nconf-cfg.sh               |  43 ++++++++
 scripts/kconfig/qconf-cfg.sh               |  25 +++++
 8 files changed, 195 insertions(+), 204 deletions(-)
 create mode 100755 scripts/kconfig/gconf-cfg.sh
 delete mode 100755 scripts/kconfig/lxdialog/check-lxdialog.sh
 create mode 100755 scripts/kconfig/mconf-cfg.sh
 create mode 100644 scripts/kconfig/nconf-cfg.sh
 create mode 100755 scripts/kconfig/qconf-cfg.sh

-- 
2.7.4

Comments

Sam Ravnborg May 22, 2018, 3:53 p.m. UTC | #1
Hi Masahiro.

On Tue, May 22, 2018 at 04:22:17PM +0900, Masahiro Yamada wrote:
> 

> Kconfig supports 4 GUI frontends.

> Each of them needs some support packages, but checks them differently:

> 

>   qconf, gconf: check packages in Makefile (pkg-config is required)

>   mconf: lxdialog/check-lxdialog.sh

>   nconf: needs ncurses, but its presence is not checked

> 

> This series refactor the package checks so that all of them work

> in the same way.

> 

> The package check scripts have been moved to scripts/kconfig/*conf-cfg.sh

> 

> The motivation of this clean-up is Randy's following patch:

> https://patchwork.kernel.org/patch/10277723/

> 

> I want to clean up existing code before adding more checks.


All patches in the series reviewed - fine.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>


	Sam
Masahiro Yamada May 24, 2018, 2:10 p.m. UTC | #2
2018-05-22 16:22 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
>

> Kconfig supports 4 GUI frontends.

> Each of them needs some support packages, but checks them differently:

>

>   qconf, gconf: check packages in Makefile (pkg-config is required)

>   mconf: lxdialog/check-lxdialog.sh

>   nconf: needs ncurses, but its presence is not checked

>

> This series refactor the package checks so that all of them work

> in the same way.

>

> The package check scripts have been moved to scripts/kconfig/*conf-cfg.sh

>

> The motivation of this clean-up is Randy's following patch:

> https://patchwork.kernel.org/patch/10277723/

>

> I want to clean up existing code before adding more checks.

>

>

> Masahiro Yamada (4):

>   kbuild: do not display CHK for filechk

>   kconfig: refactor Qt package checks for building qconf

>   kconfig: refactor GTK+ package checks for building gconf

>   kconfig: refactor ncurses package checks for building mconf and nconf



Applied to linux-kbuild/kconfig.




>  scripts/Kbuild.include                     |   1 -

>  scripts/kconfig/Makefile                   | 168 ++++++++++-------------------

>  scripts/kconfig/gconf-cfg.sh               |  23 ++++

>  scripts/kconfig/lxdialog/check-lxdialog.sh |  93 ----------------

>  scripts/kconfig/lxdialog/dialog.h          |   2 +-

>  scripts/kconfig/mconf-cfg.sh               |  44 ++++++++

>  scripts/kconfig/nconf-cfg.sh               |  43 ++++++++

>  scripts/kconfig/qconf-cfg.sh               |  25 +++++

>  8 files changed, 195 insertions(+), 204 deletions(-)

>  create mode 100755 scripts/kconfig/gconf-cfg.sh

>  delete mode 100755 scripts/kconfig/lxdialog/check-lxdialog.sh

>  create mode 100755 scripts/kconfig/mconf-cfg.sh

>  create mode 100644 scripts/kconfig/nconf-cfg.sh

>  create mode 100755 scripts/kconfig/qconf-cfg.sh

>

> --

> 2.7.4

>

> --

> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in

> the body of a message to majordomo@vger.kernel.org

> More majordomo info at  http://vger.kernel.org/majordomo-info.html




-- 
Best Regards
Masahiro Yamada