From patchwork Fri Jun 8 17:12:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 138063 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp1122870lji; Fri, 8 Jun 2018 10:13:07 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIW48pR9tklL+PRf95CxQKE9Mv5sf5WTj1CsMLZLZJxRycFmfS1mTg8a5K//JQb5zZ6qux/ X-Received: by 2002:a65:498e:: with SMTP id r14-v6mr5869864pgs.78.1528477987486; Fri, 08 Jun 2018 10:13:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528477987; cv=none; d=google.com; s=arc-20160816; b=MT1cSIsOZCoZkkmqySu1qUIx/U+hQ/VXmanD/CXNuHAMSiU4sK4vMK0pVbIAsvvJIf lB3DfHdeePjgpmL9vJhUgI27LKtLszD1cLW+4OBDWKhcrNuabJ+yNpuEeRtl/aaH3Ag4 sbQ44Mceb4pv08EzWn3vVRmhK0LJmiMknnGyRZWk5e7s3ZqX/YvOKNfIbhdxBeKUpu5o 0HsNlAWiOmxKyhS2al0gMbh/CXh9RfWRmNMeiCBGp7sbRqvxWtY7/O82iiN1eFrSxmhy wpZDUCc+pbadE2xiIOr8YYSvmwEfsyNOfZqtYqDkF/BjkliFdODXrhkc61PEH3aXV/Td UVbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter:arc-authentication-results; bh=8V68o2aoXYaRMPIgzw9KVaMEFZ0hcDpbz1gesv8uClA=; b=C3L4+C6/VMSG0Vm9Usaal0FjrcRNiydUdX5Lsp0tbeNtUwxBYFK1q1QTIzoggmMpnF vaNOvv2OTS9ISN4PY+GpVA4iuWNNv9U+EZD1z1OzOg57Hd9CL+iHQqVRFoziXtCLIswk jENgsEWT7jdsMOCf7lWb/Q+TMI5qSyNAiEMf3bmZe7e5yD/+QZA3oj8GwsuJLrGxs3zs 9AcHCYbe/kcvWT7gT21AfO4F6YSzgc8FoAd8oZqpUlprJ1tGOchrwEcfwG4J7Oa97wm0 2cJO9XJONXDn7bjWZglhByA+1l8p2EWzhVt2eXr/qy9xtdrss5XOG07B1P5dDV6uxaZQ J8RA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=urCv+zs0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t1-v6si8010822plo.241.2018.06.08.10.13.07; Fri, 08 Jun 2018 10:13:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=urCv+zs0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752896AbeFHRNE (ORCPT + 30 others); Fri, 8 Jun 2018 13:13:04 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:19846 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752253AbeFHRNB (ORCPT ); Fri, 8 Jun 2018 13:13:01 -0400 Received: from grover.sesame (FL1-125-199-20-195.osk.mesh.ad.jp [125.199.20.195]) (authenticated) by conuserg-10.nifty.com with ESMTP id w58HCbWC008555; Sat, 9 Jun 2018 02:12:37 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com w58HCbWC008555 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1528477958; bh=8V68o2aoXYaRMPIgzw9KVaMEFZ0hcDpbz1gesv8uClA=; h=From:To:Cc:Subject:Date:From; b=urCv+zs0MQDhAi/GnOifExwMv9iPDPkqxDtFlWdO0m0YeDyUGulgovrCCZpCI3Jjv 65EF5sx2xo3Yj9obJhdbpOZ8ShjEozHPxHvhHg1Evz86wRk1jE2KktZgOn7xZ6NZYo IBdOh5AgqULOA91csu/vQpfJflYAo+94yarp+DBzPl8xfIpunZ7omPA2mhw1B0Oncr MQPp3WmQSiOdpDpG02GzdFVTlTZGUNmw+RrI0eSUEDRT2bT1xvHHJ4j3uFx9bqm/O4 qqU8LdbKuOTT2X+2DqY6X8nOi9BCN+OTZ5jXTqCRYUc7qnqKfNE/jqCBXgoWTxU5zj mFdSKPpWD3dgA== X-Nifty-SrcIP: [125.199.20.195] From: Masahiro Yamada To: netdev@vger.kernel.org, Alexei Starovoitov , "David S . Miller" Cc: Arnd Bergmann , Geert Uytterhoeven , linux-kernel@vger.kernel.org, Masahiro Yamada , YueHaibing Subject: [PATCH 0/3] net: bpfilter: clean-up build rules Date: Sat, 9 Jun 2018 02:12:07 +0900 Message-Id: <1528477930-7342-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I am unhappy with ugly hacks in this Makefile. (I could understand what is the hand-crafted .bpfilter_umh.o.cmd used for.) Moreover, CONFIG_OUTPUT_FORMAT is causing build errors because it is defined only for x86. As far as I understood, what is happening here is to embed the 'bpfilter_umh' as a blob. Instead, we can use '.incbin' to include it into a *.S file. Also, let's stop (ab)using host-program rules. Only build test is done. Masahiro Yamada (3): bpfilter: add bpfilter_umh to .gitignore bpfilter: include bpfilter_umh in assembly instead of using objcopy bpfilter: do not (ab)use host-program build rule net/bpfilter/.gitignore | 1 + net/bpfilter/Makefile | 30 ++++++++++++------------------ net/bpfilter/bpfilter_kern.c | 11 +++++------ net/bpfilter/{main.c => bpfilter_umh.c} | 0 net/bpfilter/bpfilter_umh_blob.S | 7 +++++++ 5 files changed, 25 insertions(+), 24 deletions(-) create mode 100644 net/bpfilter/.gitignore rename net/bpfilter/{main.c => bpfilter_umh.c} (100%) create mode 100644 net/bpfilter/bpfilter_umh_blob.S -- 2.7.4