mbox series

[v2,0/2] test: Implement virConnectListAllNodeDevices

Message ID cover.1531259066.git.crobinso@redhat.com
Headers show
Series test: Implement virConnectListAllNodeDevices | expand

Message

Cole Robinson July 10, 2018, 9:46 p.m. UTC 
v1: https://www.redhat.com/archives/libvir-list/2018-February/msg01135.html

virnodedeviceobj.c generic ListAll infrastructure is not stateless
and will try to refresh nodedev scsi/pci/etc. config. Understandable
this doesn't play well with the test driver. Trying to untangle it
is a bit tough though.

This series adds a way to skip touching the host so we can implement
ListAllDevices in the test driver, which we want for virt-manager and
libvirt-dbus test suites

Cole Robinson (2):
  conf: nodedev: Don't refresh host caps in testdriver
  test: Implement virConnectListAllNodeDevices

 src/conf/virnodedeviceobj.c | 13 ++++++++++++-
 src/conf/virnodedeviceobj.h |  4 ++++
 src/test/test_driver.c      | 15 +++++++++++++++
 3 files changed, 31 insertions(+), 1 deletion(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Comments

Erik Skultety July 13, 2018, 10:47 a.m. UTC | #1 
On Tue, Jul 10, 2018 at 05:46:00PM -0400, Cole Robinson wrote:
> v1: https://www.redhat.com/archives/libvir-list/2018-February/msg01135.html

>

> virnodedeviceobj.c generic ListAll infrastructure is not stateless

> and will try to refresh nodedev scsi/pci/etc. config. Understandable

> this doesn't play well with the test driver. Trying to untangle it

> is a bit tough though.

>

> This series adds a way to skip touching the host so we can implement

> ListAllDevices in the test driver, which we want for virt-manager and

> libvirt-dbus test suites

>

> Cole Robinson (2):

>   conf: nodedev: Don't refresh host caps in testdriver

>   test: Implement virConnectListAllNodeDevices

>

>  src/conf/virnodedeviceobj.c | 13 ++++++++++++-

>  src/conf/virnodedeviceobj.h |  4 ++++

>  src/test/test_driver.c      | 15 +++++++++++++++

>  3 files changed, 31 insertions(+), 1 deletion(-)


Reviewed-by: Erik Skultety <eskultet@redhat.com>


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list