[v2,for-4.4.y,0/5] net/sched: init failure fixes

Message ID 1535007116-31801-1-git-send-email-amit.pundir@linaro.org
Headers show
  • net/sched: init failure fixes
Related show


Amit Pundir Aug. 23, 2018, 6:51 a.m.
Hi Greg,

Kindly consider/review following net/sched fixes for stable 4.4.y.

This patchset is a follow-up of upstream fix
87b60cfacf9f ("net_sched: fix error recovery at qdisc creation")
cherry-picked on stable 4.4.y.

It fix null pointer dereferences due to uninitialized timer
(qdisc watchdog) or double frees due to ->destroy cleaning up a
second time. Here is the original submission

Cherry-picked and build tested on Linux 4.4.151 for ARCH=x86_64.

Amit Pundir

Change since v1:
Rebased "sch_multiq: fix double free on init failure" patch
and fixed "unused variable" build warning.

Nikolay Aleksandrov (5):
  sch_htb: fix crash on init failure
  sch_multiq: fix double free on init failure
  sch_hhf: fix null pointer dereference on init failure
  sch_netem: avoid null pointer deref on init failure
  sch_tbf: fix two null pointer dereferences on init failure

 net/sched/sch_hhf.c    | 3 +++
 net/sched/sch_htb.c    | 5 +++--
 net/sched/sch_multiq.c | 9 ++-------
 net/sched/sch_netem.c  | 4 ++--
 net/sched/sch_tbf.c    | 5 +++--
 5 files changed, 13 insertions(+), 13 deletions(-)