[0/7] General fixes and refactor for BZ#12683

Message ID 20180904204553.6971-1-adhemerval.zanella@linaro.org
Headers show
Series
  • General fixes and refactor for BZ#12683
Related show

Message

Adhemerval Zanella Sept. 4, 2018, 8:45 p.m.
These patches are refactoring and fixes required for my proposal to
BZ#12683 [1].  They can be applied independently of the cancellation
refactor fix and the idea is to simplify the patch submission with
changes only direct related to the issue.

[1] https://sourceware.org/ml/libc-alpha/2018-02/msg00782.html

Adhemerval Zanella (7):
  powerpc: Add CFI information on indirect syscall
  nptl: Remove tst-cancel-wrappers test and related macros
  nptl: Fix testcases for new pthread cancellation mechanism
  x86: Remove wrong THREAD_ATOMIC_* macros
  i386: Remove bogus THREAD_ATOMIC_* macros
  nptl: Cleanup cancellation macros
  support: Add support_create_temp_fifo

 ChangeLog                                     | 70 ++++++++++++++
 debug/tst-backtrace5.c                        | 19 ++--
 io/creat.c                                    |  3 -
 io/ppoll.c                                    |  2 -
 misc/pselect.c                                |  2 -
 nptl/Makefile                                 | 18 +---
 nptl/pthreadP.h                               | 10 --
 nptl/pthread_join_common.c                    |  9 +-
 nptl/sem_wait.c                               |  8 +-
 nptl/tst-cancel-wrappers.sh                   | 92 -------------------
 nptl/tst-cancel4.c                            |  8 ++
 support/temp_file.c                           | 23 +++++
 support/temp_file.h                           |  6 ++
 sysdeps/generic/sysdep-cancel.h               |  1 -
 sysdeps/i386/nptl/tls.h                       | 37 --------
 sysdeps/mach/hurd/sysdep-cancel.h             |  1 -
 sysdeps/nptl/aio_misc.h                       | 15 ++-
 sysdeps/nptl/gai_misc.h                       | 15 ++-
 sysdeps/nptl/lowlevellock.h                   | 40 ++++----
 sysdeps/posix/open64.c                        | 12 +--
 sysdeps/posix/pause.c                         |  2 -
 sysdeps/posix/sigpause.c                      |  3 -
 sysdeps/posix/sigwait.c                       | 12 +--
 sysdeps/posix/waitid.c                        | 12 +--
 sysdeps/unix/sysv/linux/clock_nanosleep.c     | 23 ++---
 sysdeps/unix/sysv/linux/creat.c               |  2 -
 sysdeps/unix/sysv/linux/creat64.c             |  2 -
 sysdeps/unix/sysv/linux/futex-internal.h      |  4 +-
 sysdeps/unix/sysv/linux/i386/lowlevellock.h   | 42 ++++-----
 sysdeps/unix/sysv/linux/lowlevellock-futex.h  | 11 +++
 sysdeps/unix/sysv/linux/powerpc/syscall.S     |  1 +
 sysdeps/unix/sysv/linux/sigwait.c             |  3 -
 sysdeps/unix/sysv/linux/sigwaitinfo.c         |  3 -
 sysdeps/unix/sysv/linux/sparc/lowlevellock.h  | 39 ++++----
 sysdeps/unix/sysv/linux/x86_64/lowlevellock.h | 40 ++++----
 sysdeps/x86_64/nptl/tls.h                     | 37 --------
 36 files changed, 237 insertions(+), 390 deletions(-)
 delete mode 100644 nptl/tst-cancel-wrappers.sh

-- 
2.17.1

Comments

Adhemerval Zanella Sept. 25, 2018, 9:13 p.m. | #1
Ping.

On 04/09/2018 17:45, Adhemerval Zanella wrote:
> These patches are refactoring and fixes required for my proposal to

> BZ#12683 [1].  They can be applied independently of the cancellation

> refactor fix and the idea is to simplify the patch submission with

> changes only direct related to the issue.

> 

> [1] https://sourceware.org/ml/libc-alpha/2018-02/msg00782.html

> 

> Adhemerval Zanella (7):

>   powerpc: Add CFI information on indirect syscall

>   nptl: Remove tst-cancel-wrappers test and related macros

>   nptl: Fix testcases for new pthread cancellation mechanism

>   x86: Remove wrong THREAD_ATOMIC_* macros

>   i386: Remove bogus THREAD_ATOMIC_* macros

>   nptl: Cleanup cancellation macros

>   support: Add support_create_temp_fifo

> 

>  ChangeLog                                     | 70 ++++++++++++++

>  debug/tst-backtrace5.c                        | 19 ++--

>  io/creat.c                                    |  3 -

>  io/ppoll.c                                    |  2 -

>  misc/pselect.c                                |  2 -

>  nptl/Makefile                                 | 18 +---

>  nptl/pthreadP.h                               | 10 --

>  nptl/pthread_join_common.c                    |  9 +-

>  nptl/sem_wait.c                               |  8 +-

>  nptl/tst-cancel-wrappers.sh                   | 92 -------------------

>  nptl/tst-cancel4.c                            |  8 ++

>  support/temp_file.c                           | 23 +++++

>  support/temp_file.h                           |  6 ++

>  sysdeps/generic/sysdep-cancel.h               |  1 -

>  sysdeps/i386/nptl/tls.h                       | 37 --------

>  sysdeps/mach/hurd/sysdep-cancel.h             |  1 -

>  sysdeps/nptl/aio_misc.h                       | 15 ++-

>  sysdeps/nptl/gai_misc.h                       | 15 ++-

>  sysdeps/nptl/lowlevellock.h                   | 40 ++++----

>  sysdeps/posix/open64.c                        | 12 +--

>  sysdeps/posix/pause.c                         |  2 -

>  sysdeps/posix/sigpause.c                      |  3 -

>  sysdeps/posix/sigwait.c                       | 12 +--

>  sysdeps/posix/waitid.c                        | 12 +--

>  sysdeps/unix/sysv/linux/clock_nanosleep.c     | 23 ++---

>  sysdeps/unix/sysv/linux/creat.c               |  2 -

>  sysdeps/unix/sysv/linux/creat64.c             |  2 -

>  sysdeps/unix/sysv/linux/futex-internal.h      |  4 +-

>  sysdeps/unix/sysv/linux/i386/lowlevellock.h   | 42 ++++-----

>  sysdeps/unix/sysv/linux/lowlevellock-futex.h  | 11 +++

>  sysdeps/unix/sysv/linux/powerpc/syscall.S     |  1 +

>  sysdeps/unix/sysv/linux/sigwait.c             |  3 -

>  sysdeps/unix/sysv/linux/sigwaitinfo.c         |  3 -

>  sysdeps/unix/sysv/linux/sparc/lowlevellock.h  | 39 ++++----

>  sysdeps/unix/sysv/linux/x86_64/lowlevellock.h | 40 ++++----

>  sysdeps/x86_64/nptl/tls.h                     | 37 --------

>  36 files changed, 237 insertions(+), 390 deletions(-)

>  delete mode 100644 nptl/tst-cancel-wrappers.sh

>
Adhemerval Zanella Nov. 28, 2018, 2:10 p.m. | #2
I really want to move forward on this, since it is essentially some refactor
for the BZ#12683 (which I would like also to get in shape at least for next
version).

Does anyone have any concerns about this patchset (minus the
"powerpc: Add CFI information on indirect syscall" which from review seems
not required)? 

On 25/09/2018 18:13, Adhemerval Zanella wrote:
> Ping.

> 

> On 04/09/2018 17:45, Adhemerval Zanella wrote:

>> These patches are refactoring and fixes required for my proposal to

>> BZ#12683 [1].  They can be applied independently of the cancellation

>> refactor fix and the idea is to simplify the patch submission with

>> changes only direct related to the issue.

>>

>> [1] https://sourceware.org/ml/libc-alpha/2018-02/msg00782.html

>>

>> Adhemerval Zanella (7):

>>   powerpc: Add CFI information on indirect syscall

>>   nptl: Remove tst-cancel-wrappers test and related macros

>>   nptl: Fix testcases for new pthread cancellation mechanism

>>   x86: Remove wrong THREAD_ATOMIC_* macros

>>   i386: Remove bogus THREAD_ATOMIC_* macros

>>   nptl: Cleanup cancellation macros

>>   support: Add support_create_temp_fifo

>>

>>  ChangeLog                                     | 70 ++++++++++++++

>>  debug/tst-backtrace5.c                        | 19 ++--

>>  io/creat.c                                    |  3 -

>>  io/ppoll.c                                    |  2 -

>>  misc/pselect.c                                |  2 -

>>  nptl/Makefile                                 | 18 +---

>>  nptl/pthreadP.h                               | 10 --

>>  nptl/pthread_join_common.c                    |  9 +-

>>  nptl/sem_wait.c                               |  8 +-

>>  nptl/tst-cancel-wrappers.sh                   | 92 -------------------

>>  nptl/tst-cancel4.c                            |  8 ++

>>  support/temp_file.c                           | 23 +++++

>>  support/temp_file.h                           |  6 ++

>>  sysdeps/generic/sysdep-cancel.h               |  1 -

>>  sysdeps/i386/nptl/tls.h                       | 37 --------

>>  sysdeps/mach/hurd/sysdep-cancel.h             |  1 -

>>  sysdeps/nptl/aio_misc.h                       | 15 ++-

>>  sysdeps/nptl/gai_misc.h                       | 15 ++-

>>  sysdeps/nptl/lowlevellock.h                   | 40 ++++----

>>  sysdeps/posix/open64.c                        | 12 +--

>>  sysdeps/posix/pause.c                         |  2 -

>>  sysdeps/posix/sigpause.c                      |  3 -

>>  sysdeps/posix/sigwait.c                       | 12 +--

>>  sysdeps/posix/waitid.c                        | 12 +--

>>  sysdeps/unix/sysv/linux/clock_nanosleep.c     | 23 ++---

>>  sysdeps/unix/sysv/linux/creat.c               |  2 -

>>  sysdeps/unix/sysv/linux/creat64.c             |  2 -

>>  sysdeps/unix/sysv/linux/futex-internal.h      |  4 +-

>>  sysdeps/unix/sysv/linux/i386/lowlevellock.h   | 42 ++++-----

>>  sysdeps/unix/sysv/linux/lowlevellock-futex.h  | 11 +++

>>  sysdeps/unix/sysv/linux/powerpc/syscall.S     |  1 +

>>  sysdeps/unix/sysv/linux/sigwait.c             |  3 -

>>  sysdeps/unix/sysv/linux/sigwaitinfo.c         |  3 -

>>  sysdeps/unix/sysv/linux/sparc/lowlevellock.h  | 39 ++++----

>>  sysdeps/unix/sysv/linux/x86_64/lowlevellock.h | 40 ++++----

>>  sysdeps/x86_64/nptl/tls.h                     | 37 --------

>>  36 files changed, 237 insertions(+), 390 deletions(-)

>>  delete mode 100644 nptl/tst-cancel-wrappers.sh

>>
Adhemerval Zanella Dec. 19, 2018, 10:14 p.m. | #3
Ping.

On 28/11/2018 12:10, Adhemerval Zanella wrote:
> I really want to move forward on this, since it is essentially some refactor

> for the BZ#12683 (which I would like also to get in shape at least for next

> version).

> 

> Does anyone have any concerns about this patchset (minus the

> "powerpc: Add CFI information on indirect syscall" which from review seems

> not required)? 

> 

> On 25/09/2018 18:13, Adhemerval Zanella wrote:

>> Ping.

>>

>> On 04/09/2018 17:45, Adhemerval Zanella wrote:

>>> These patches are refactoring and fixes required for my proposal to

>>> BZ#12683 [1].  They can be applied independently of the cancellation

>>> refactor fix and the idea is to simplify the patch submission with

>>> changes only direct related to the issue.

>>>

>>> [1] https://sourceware.org/ml/libc-alpha/2018-02/msg00782.html

>>>

>>> Adhemerval Zanella (7):

>>>   powerpc: Add CFI information on indirect syscall

>>>   nptl: Remove tst-cancel-wrappers test and related macros

>>>   nptl: Fix testcases for new pthread cancellation mechanism

>>>   x86: Remove wrong THREAD_ATOMIC_* macros

>>>   i386: Remove bogus THREAD_ATOMIC_* macros

>>>   nptl: Cleanup cancellation macros

>>>   support: Add support_create_temp_fifo

>>>

>>>  ChangeLog                                     | 70 ++++++++++++++

>>>  debug/tst-backtrace5.c                        | 19 ++--

>>>  io/creat.c                                    |  3 -

>>>  io/ppoll.c                                    |  2 -

>>>  misc/pselect.c                                |  2 -

>>>  nptl/Makefile                                 | 18 +---

>>>  nptl/pthreadP.h                               | 10 --

>>>  nptl/pthread_join_common.c                    |  9 +-

>>>  nptl/sem_wait.c                               |  8 +-

>>>  nptl/tst-cancel-wrappers.sh                   | 92 -------------------

>>>  nptl/tst-cancel4.c                            |  8 ++

>>>  support/temp_file.c                           | 23 +++++

>>>  support/temp_file.h                           |  6 ++

>>>  sysdeps/generic/sysdep-cancel.h               |  1 -

>>>  sysdeps/i386/nptl/tls.h                       | 37 --------

>>>  sysdeps/mach/hurd/sysdep-cancel.h             |  1 -

>>>  sysdeps/nptl/aio_misc.h                       | 15 ++-

>>>  sysdeps/nptl/gai_misc.h                       | 15 ++-

>>>  sysdeps/nptl/lowlevellock.h                   | 40 ++++----

>>>  sysdeps/posix/open64.c                        | 12 +--

>>>  sysdeps/posix/pause.c                         |  2 -

>>>  sysdeps/posix/sigpause.c                      |  3 -

>>>  sysdeps/posix/sigwait.c                       | 12 +--

>>>  sysdeps/posix/waitid.c                        | 12 +--

>>>  sysdeps/unix/sysv/linux/clock_nanosleep.c     | 23 ++---

>>>  sysdeps/unix/sysv/linux/creat.c               |  2 -

>>>  sysdeps/unix/sysv/linux/creat64.c             |  2 -

>>>  sysdeps/unix/sysv/linux/futex-internal.h      |  4 +-

>>>  sysdeps/unix/sysv/linux/i386/lowlevellock.h   | 42 ++++-----

>>>  sysdeps/unix/sysv/linux/lowlevellock-futex.h  | 11 +++

>>>  sysdeps/unix/sysv/linux/powerpc/syscall.S     |  1 +

>>>  sysdeps/unix/sysv/linux/sigwait.c             |  3 -

>>>  sysdeps/unix/sysv/linux/sigwaitinfo.c         |  3 -

>>>  sysdeps/unix/sysv/linux/sparc/lowlevellock.h  | 39 ++++----

>>>  sysdeps/unix/sysv/linux/x86_64/lowlevellock.h | 40 ++++----

>>>  sysdeps/x86_64/nptl/tls.h                     | 37 --------

>>>  36 files changed, 237 insertions(+), 390 deletions(-)

>>>  delete mode 100644 nptl/tst-cancel-wrappers.sh

>>>