| Message ID | 20180927190301.9642-1-manivannan.sadhasivam@linaro.org |
|---|---|
| Headers | show |
| Series | Add Rock960 and Ficus 96Board support | expand |
On 27/09/2018 21:02, Manivannan Sadhasivam wrote: > This patchset adds support for Rock960 and Ficus 96Boards from Vamrs. > Since both boards share most of the configurations, a common Rock960 > family support is added with common support and the actual boards are > based on this. > > The previous version of the patchseries were adding Rock960 [1] and > Ficus [2] board support individually, but this series fuses them > together based on the common board support as per Linux kernel. > > [1] https://patchwork.ozlabs.org/cover/963239/ > [2] https://lists.denx.de/pipermail/u-boot/2018-August/339059.html > > This patchseries has been tested on Rock960 v1.2 board and expecting > Ezequiel to do the testing for Ficus. > > PS: I have explicitly removed the previous Ack's for the Ficus board > since there has been a heavy modification done on these patches. With this series I was able to boot the rock960 board (4GB/32GB) and tftp load a kernel following the instructions given in the documentation. Tested-by: Daniel Lezcano <daniel.lezcano@linaro.org> > Manivannan Sadhasivam (4): > arm: dts: rockchip: add some common pin-settings to rk3399 > rockchip: rk3399: Add common Rock960 family from Vamrs > rockchip: rk3399: Add Rock960 CE board support > rockchip: rk3399: Add Ficus EE board support > > arch/arm/dts/Makefile | 2 + > arch/arm/dts/rk3399-ficus.dts | 78 + > arch/arm/dts/rk3399-rock960.dts | 45 + > arch/arm/dts/rk3399-rock960.dtsi | 506 ++++++ > .../arm/dts/rk3399-sdram-lpddr3-2GB-1600.dtsi | 1536 +++++++++++++++++ > arch/arm/dts/rk3399.dtsi | 55 +- > arch/arm/mach-rockchip/rk3399/Kconfig | 26 + > board/vamrs/rock960_rk3399/Kconfig | 15 + > board/vamrs/rock960_rk3399/MAINTAINERS | 6 + > board/vamrs/rock960_rk3399/Makefile | 6 + > board/vamrs/rock960_rk3399/README | 152 ++ > board/vamrs/rock960_rk3399/rock960-rk3399.c | 50 + > configs/ficus-rk3399_defconfig | 71 + > configs/rock960-rk3399_defconfig | 69 + > include/configs/rock960_rk3399.h | 15 + > 15 files changed, 2626 insertions(+), 6 deletions(-) > create mode 100644 arch/arm/dts/rk3399-ficus.dts > create mode 100644 arch/arm/dts/rk3399-rock960.dts > create mode 100644 arch/arm/dts/rk3399-rock960.dtsi > create mode 100644 arch/arm/dts/rk3399-sdram-lpddr3-2GB-1600.dtsi > create mode 100644 board/vamrs/rock960_rk3399/Kconfig > create mode 100644 board/vamrs/rock960_rk3399/MAINTAINERS > create mode 100644 board/vamrs/rock960_rk3399/Makefile > create mode 100644 board/vamrs/rock960_rk3399/README > create mode 100644 board/vamrs/rock960_rk3399/rock960-rk3399.c > create mode 100644 configs/ficus-rk3399_defconfig > create mode 100644 configs/rock960-rk3399_defconfig > create mode 100644 include/configs/rock960_rk3399.h >
On Fri, Sep 28, 2018 at 12:32:57AM +0530, Manivannan Sadhasivam wrote: > This patchset adds support for Rock960 and Ficus 96Boards from Vamrs. > Since both boards share most of the configurations, a common Rock960 > family support is added with common support and the actual boards are > based on this. > > The previous version of the patchseries were adding Rock960 [1] and > Ficus [2] board support individually, but this series fuses them > together based on the common board support as per Linux kernel. > > [1] https://patchwork.ozlabs.org/cover/963239/ > [2] https://lists.denx.de/pipermail/u-boot/2018-August/339059.html > > This patchseries has been tested on Rock960 v1.2 board and expecting > Ezequiel to do the testing for Ficus. > > PS: I have explicitly removed the previous Ack's for the Ficus board > since there has been a heavy modification done on these patches. > > Thanks, > Mani > Hi, Is there any update on this patchset? AFAIK everyone is happy to get this merged! Thanks, Mani > Manivannan Sadhasivam (4): > arm: dts: rockchip: add some common pin-settings to rk3399 > rockchip: rk3399: Add common Rock960 family from Vamrs > rockchip: rk3399: Add Rock960 CE board support > rockchip: rk3399: Add Ficus EE board support > > arch/arm/dts/Makefile | 2 + > arch/arm/dts/rk3399-ficus.dts | 78 + > arch/arm/dts/rk3399-rock960.dts | 45 + > arch/arm/dts/rk3399-rock960.dtsi | 506 ++++++ > .../arm/dts/rk3399-sdram-lpddr3-2GB-1600.dtsi | 1536 +++++++++++++++++ > arch/arm/dts/rk3399.dtsi | 55 +- > arch/arm/mach-rockchip/rk3399/Kconfig | 26 + > board/vamrs/rock960_rk3399/Kconfig | 15 + > board/vamrs/rock960_rk3399/MAINTAINERS | 6 + > board/vamrs/rock960_rk3399/Makefile | 6 + > board/vamrs/rock960_rk3399/README | 152 ++ > board/vamrs/rock960_rk3399/rock960-rk3399.c | 50 + > configs/ficus-rk3399_defconfig | 71 + > configs/rock960-rk3399_defconfig | 69 + > include/configs/rock960_rk3399.h | 15 + > 15 files changed, 2626 insertions(+), 6 deletions(-) > create mode 100644 arch/arm/dts/rk3399-ficus.dts > create mode 100644 arch/arm/dts/rk3399-rock960.dts > create mode 100644 arch/arm/dts/rk3399-rock960.dtsi > create mode 100644 arch/arm/dts/rk3399-sdram-lpddr3-2GB-1600.dtsi > create mode 100644 board/vamrs/rock960_rk3399/Kconfig > create mode 100644 board/vamrs/rock960_rk3399/MAINTAINERS > create mode 100644 board/vamrs/rock960_rk3399/Makefile > create mode 100644 board/vamrs/rock960_rk3399/README > create mode 100644 board/vamrs/rock960_rk3399/rock960-rk3399.c > create mode 100644 configs/ficus-rk3399_defconfig > create mode 100644 configs/rock960-rk3399_defconfig > create mode 100644 include/configs/rock960_rk3399.h > > -- > 2.17.1 >
> On 26.10.2018, at 19:17, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > > On Fri, Sep 28, 2018 at 12:32:57AM +0530, Manivannan Sadhasivam wrote: >> This patchset adds support for Rock960 and Ficus 96Boards from Vamrs. >> Since both boards share most of the configurations, a common Rock960 >> family support is added with common support and the actual boards are >> based on this. >> >> The previous version of the patchseries were adding Rock960 [1] and >> Ficus [2] board support individually, but this series fuses them >> together based on the common board support as per Linux kernel. >> >> [1] https://patchwork.ozlabs.org/cover/963239/ >> [2] https://lists.denx.de/pipermail/u-boot/2018-August/339059.html >> >> This patchseries has been tested on Rock960 v1.2 board and expecting >> Ezequiel to do the testing for Ficus. >> >> PS: I have explicitly removed the previous Ack's for the Ficus board >> since there has been a heavy modification done on these patches. >> >> Thanks, >> Mani >> > > Hi, > > Is there any update on this patchset? AFAIK everyone is happy to get > this merged! It’s on pretty high up my list for the next merge window, but I didn’t get it into the current version. Thanks, Philipp. > > Thanks, > Mani > >> Manivannan Sadhasivam (4): >> arm: dts: rockchip: add some common pin-settings to rk3399 >> rockchip: rk3399: Add common Rock960 family from Vamrs >> rockchip: rk3399: Add Rock960 CE board support >> rockchip: rk3399: Add Ficus EE board support >> >> arch/arm/dts/Makefile | 2 + >> arch/arm/dts/rk3399-ficus.dts | 78 + >> arch/arm/dts/rk3399-rock960.dts | 45 + >> arch/arm/dts/rk3399-rock960.dtsi | 506 ++++++ >> .../arm/dts/rk3399-sdram-lpddr3-2GB-1600.dtsi | 1536 +++++++++++++++++ >> arch/arm/dts/rk3399.dtsi | 55 +- >> arch/arm/mach-rockchip/rk3399/Kconfig | 26 + >> board/vamrs/rock960_rk3399/Kconfig | 15 + >> board/vamrs/rock960_rk3399/MAINTAINERS | 6 + >> board/vamrs/rock960_rk3399/Makefile | 6 + >> board/vamrs/rock960_rk3399/README | 152 ++ >> board/vamrs/rock960_rk3399/rock960-rk3399.c | 50 + >> configs/ficus-rk3399_defconfig | 71 + >> configs/rock960-rk3399_defconfig | 69 + >> include/configs/rock960_rk3399.h | 15 + >> 15 files changed, 2626 insertions(+), 6 deletions(-) >> create mode 100644 arch/arm/dts/rk3399-ficus.dts >> create mode 100644 arch/arm/dts/rk3399-rock960.dts >> create mode 100644 arch/arm/dts/rk3399-rock960.dtsi >> create mode 100644 arch/arm/dts/rk3399-sdram-lpddr3-2GB-1600.dtsi >> create mode 100644 board/vamrs/rock960_rk3399/Kconfig >> create mode 100644 board/vamrs/rock960_rk3399/MAINTAINERS >> create mode 100644 board/vamrs/rock960_rk3399/Makefile >> create mode 100644 board/vamrs/rock960_rk3399/README >> create mode 100644 board/vamrs/rock960_rk3399/rock960-rk3399.c >> create mode 100644 configs/ficus-rk3399_defconfig >> create mode 100644 configs/rock960-rk3399_defconfig >> create mode 100644 include/configs/rock960_rk3399.h >> >> -- >> 2.17.1
On 26.10.18 20:00, Philipp Tomsich wrote: > > >> On 26.10.2018, at 19:17, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: >> >> On Fri, Sep 28, 2018 at 12:32:57AM +0530, Manivannan Sadhasivam wrote: >>> This patchset adds support for Rock960 and Ficus 96Boards from Vamrs. >>> Since both boards share most of the configurations, a common Rock960 >>> family support is added with common support and the actual boards are >>> based on this. >>> >>> The previous version of the patchseries were adding Rock960 [1] and >>> Ficus [2] board support individually, but this series fuses them >>> together based on the common board support as per Linux kernel. >>> >>> [1] https://patchwork.ozlabs.org/cover/963239/ >>> [2] https://lists.denx.de/pipermail/u-boot/2018-August/339059.html >>> >>> This patchseries has been tested on Rock960 v1.2 board and expecting >>> Ezequiel to do the testing for Ficus. >>> >>> PS: I have explicitly removed the previous Ack's for the Ficus board >>> since there has been a heavy modification done on these patches. >>> >>> Thanks, >>> Mani >>> >> >> Hi, >> >> Is there any update on this patchset? AFAIK everyone is happy to get >> this merged! > > It’s on pretty high up my list for the next merge window, but I didn’t get it into > the current version. So there goes another merge window. Any progress here? Alex
> On 06.12.2018, at 08:53, Alexander Graf <agraf@suse.de> wrote: > > > > On 26.10.18 20:00, Philipp Tomsich wrote: >> >> >>> On 26.10.2018, at 19:17, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: >>> >>> On Fri, Sep 28, 2018 at 12:32:57AM +0530, Manivannan Sadhasivam wrote: >>>> This patchset adds support for Rock960 and Ficus 96Boards from Vamrs. >>>> Since both boards share most of the configurations, a common Rock960 >>>> family support is added with common support and the actual boards are >>>> based on this. >>>> >>>> The previous version of the patchseries were adding Rock960 [1] and >>>> Ficus [2] board support individually, but this series fuses them >>>> together based on the common board support as per Linux kernel. >>>> >>>> [1] https://patchwork.ozlabs.org/cover/963239/ >>>> [2] https://lists.denx.de/pipermail/u-boot/2018-August/339059.html >>>> >>>> This patchseries has been tested on Rock960 v1.2 board and expecting >>>> Ezequiel to do the testing for Ficus. >>>> >>>> PS: I have explicitly removed the previous Ack's for the Ficus board >>>> since there has been a heavy modification done on these patches. >>>> >>>> Thanks, >>>> Mani >>>> >>> >>> Hi, >>> >>> Is there any update on this patchset? AFAIK everyone is happy to get >>> this merged! >> >> It’s on pretty high up my list for the next merge window, but I didn’t get it into >> the current version. > > So there goes another merge window. Any progress here? It’s on u-boot-rockchip/master, but waiting for a USB change to be merged for the PR. Surprisingly it failed in Travis-CI for the Rock960 board… Thanks, Philipp.
> On 06.12.2018, at 15:57, Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote: > > > >> On 06.12.2018, at 08:53, Alexander Graf <agraf@suse.de <mailto:agraf@suse.de>> wrote: >> >> >> >> On 26.10.18 20:00, Philipp Tomsich wrote: >>> >>> >>>> On 26.10.2018, at 19:17, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org <mailto:manivannan.sadhasivam@linaro.org>> wrote: >>>> >>>> On Fri, Sep 28, 2018 at 12:32:57AM +0530, Manivannan Sadhasivam wrote: >>>>> This patchset adds support for Rock960 and Ficus 96Boards from Vamrs. >>>>> Since both boards share most of the configurations, a common Rock960 >>>>> family support is added with common support and the actual boards are >>>>> based on this. >>>>> >>>>> The previous version of the patchseries were adding Rock960 [1] and >>>>> Ficus [2] board support individually, but this series fuses them >>>>> together based on the common board support as per Linux kernel. >>>>> >>>>> [1] https://patchwork.ozlabs.org/cover/963239/ <https://patchwork.ozlabs.org/cover/963239/> >>>>> [2] https://lists.denx.de/pipermail/u-boot/2018-August/339059.html <https://lists.denx.de/pipermail/u-boot/2018-August/339059.html> >>>>> >>>>> This patchseries has been tested on Rock960 v1.2 board and expecting >>>>> Ezequiel to do the testing for Ficus. >>>>> >>>>> PS: I have explicitly removed the previous Ack's for the Ficus board >>>>> since there has been a heavy modification done on these patches. >>>>> >>>>> Thanks, >>>>> Mani >>>>> >>>> >>>> Hi, >>>> >>>> Is there any update on this patchset? AFAIK everyone is happy to get >>>> this merged! >>> >>> It’s on pretty high up my list for the next merge window, but I didn’t get it into >>> the current version. >> >> So there goes another merge window. Any progress here? > > It’s on u-boot-rockchip/master, but waiting for a USB change to be merged for the PR. > Surprisingly it failed in Travis-CI for the Rock960 board… And I just saw Marek’s mail in my backlog from last night, so I can indeed send out the PR now.
On Thu, Dec 06, 2018 at 08:53:33AM +0100, Alexander Graf wrote: > > > On 26.10.18 20:00, Philipp Tomsich wrote: > > > > > >> On 26.10.2018, at 19:17, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > >> > >> On Fri, Sep 28, 2018 at 12:32:57AM +0530, Manivannan Sadhasivam wrote: > >>> This patchset adds support for Rock960 and Ficus 96Boards from Vamrs. > >>> Since both boards share most of the configurations, a common Rock960 > >>> family support is added with common support and the actual boards are > >>> based on this. > >>> > >>> The previous version of the patchseries were adding Rock960 [1] and > >>> Ficus [2] board support individually, but this series fuses them > >>> together based on the common board support as per Linux kernel. > >>> > >>> [1] https://patchwork.ozlabs.org/cover/963239/ > >>> [2] https://lists.denx.de/pipermail/u-boot/2018-August/339059.html > >>> > >>> This patchseries has been tested on Rock960 v1.2 board and expecting > >>> Ezequiel to do the testing for Ficus. > >>> > >>> PS: I have explicitly removed the previous Ack's for the Ficus board > >>> since there has been a heavy modification done on these patches. > >>> > >>> Thanks, > >>> Mani > >>> > >> > >> Hi, > >> > >> Is there any update on this patchset? AFAIK everyone is happy to get > >> this merged! > > > > It’s on pretty high up my list for the next merge window, but I didn’t get it into > > the current version. > > So there goes another merge window. Any progress here? So, I'm going to call out here that this new board is entirely missing a MAINTAINERS file. Causing ./tools/genboardscfg.py to complain about new defconfigs without a MAINTAINER. I'm gonna fix it now, but, grumble. I know checkpatch.pl does complain "Hey, new file, do you need to update MAINTAINERS" from Linux. -- Tom
On Thu, Dec 06, 2018 at 10:20:30AM -0500, Tom Rini wrote: > On Thu, Dec 06, 2018 at 08:53:33AM +0100, Alexander Graf wrote: > > > > > > On 26.10.18 20:00, Philipp Tomsich wrote: > > > > > > > > >> On 26.10.2018, at 19:17, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > > >> > > >> On Fri, Sep 28, 2018 at 12:32:57AM +0530, Manivannan Sadhasivam wrote: > > >>> This patchset adds support for Rock960 and Ficus 96Boards from Vamrs. > > >>> Since both boards share most of the configurations, a common Rock960 > > >>> family support is added with common support and the actual boards are > > >>> based on this. > > >>> > > >>> The previous version of the patchseries were adding Rock960 [1] and > > >>> Ficus [2] board support individually, but this series fuses them > > >>> together based on the common board support as per Linux kernel. > > >>> > > >>> [1] https://patchwork.ozlabs.org/cover/963239/ > > >>> [2] https://lists.denx.de/pipermail/u-boot/2018-August/339059.html > > >>> > > >>> This patchseries has been tested on Rock960 v1.2 board and expecting > > >>> Ezequiel to do the testing for Ficus. > > >>> > > >>> PS: I have explicitly removed the previous Ack's for the Ficus board > > >>> since there has been a heavy modification done on these patches. > > >>> > > >>> Thanks, > > >>> Mani > > >>> > > >> > > >> Hi, > > >> > > >> Is there any update on this patchset? AFAIK everyone is happy to get > > >> this merged! > > > > > > It’s on pretty high up my list for the next merge window, but I didn’t get it into > > > the current version. > > > > So there goes another merge window. Any progress here? > > So, I'm going to call out here that this new board is entirely missing a > MAINTAINERS file. Causing ./tools/genboardscfg.py to complain about new > defconfigs without a MAINTAINER. I'm gonna fix it now, but, grumble. I > know checkpatch.pl does complain "Hey, new file, do you need to update > MAINTAINERS" from Linux. > Hi Tom, Sorry for that! It was my bad to left MAINTAINERS entry for Ficus board. Since there are two boards (Rock960 and Ficus) sharing common board support, I forgot to update the later one. Regards, Mani > -- > Tom
On Thu, Dec 06, 2018 at 09:07:39PM +0530, Manivannan Sadhasivam wrote: > On Thu, Dec 06, 2018 at 10:20:30AM -0500, Tom Rini wrote: > > On Thu, Dec 06, 2018 at 08:53:33AM +0100, Alexander Graf wrote: > > > > > > > > > On 26.10.18 20:00, Philipp Tomsich wrote: > > > > > > > > > > > >> On 26.10.2018, at 19:17, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > > > >> > > > >> On Fri, Sep 28, 2018 at 12:32:57AM +0530, Manivannan Sadhasivam wrote: > > > >>> This patchset adds support for Rock960 and Ficus 96Boards from Vamrs. > > > >>> Since both boards share most of the configurations, a common Rock960 > > > >>> family support is added with common support and the actual boards are > > > >>> based on this. > > > >>> > > > >>> The previous version of the patchseries were adding Rock960 [1] and > > > >>> Ficus [2] board support individually, but this series fuses them > > > >>> together based on the common board support as per Linux kernel. > > > >>> > > > >>> [1] https://patchwork.ozlabs.org/cover/963239/ > > > >>> [2] https://lists.denx.de/pipermail/u-boot/2018-August/339059.html > > > >>> > > > >>> This patchseries has been tested on Rock960 v1.2 board and expecting > > > >>> Ezequiel to do the testing for Ficus. > > > >>> > > > >>> PS: I have explicitly removed the previous Ack's for the Ficus board > > > >>> since there has been a heavy modification done on these patches. > > > >>> > > > >>> Thanks, > > > >>> Mani > > > >>> > > > >> > > > >> Hi, > > > >> > > > >> Is there any update on this patchset? AFAIK everyone is happy to get > > > >> this merged! > > > > > > > > It’s on pretty high up my list for the next merge window, but I didn’t get it into > > > > the current version. > > > > > > So there goes another merge window. Any progress here? > > > > So, I'm going to call out here that this new board is entirely missing a > > MAINTAINERS file. Causing ./tools/genboardscfg.py to complain about new > > defconfigs without a MAINTAINER. I'm gonna fix it now, but, grumble. I > > know checkpatch.pl does complain "Hey, new file, do you need to update > > MAINTAINERS" from Linux. > > > > Hi Tom, > > Sorry for that! It was my bad to left MAINTAINERS entry for Ficus board. > Since there are two boards (Rock960 and Ficus) sharing common board > support, I forgot to update the later one. Not a huge problem, really. I've now become motivated enough to write a .travis.yml test for this problem and thus pushing the problem visibly up the chain like I should have months ago :) -- Tom