[edk2,edk2-platforms,00/11] final set of Styx cleanups

Message ID 20181211183514.20948-1-ard.biesheuvel@linaro.org
Headers show
Series
  • final set of Styx cleanups
Related show

Message

Ard Biesheuvel Dec. 11, 2018, 6:35 p.m.
I promise :-)

This gets rid of the last build config options passed via the command
line into the preprocessor, and replaces them with PCD references.

Ard Biesheuvel (11):
  Silicon/AMD/Styx/Iort: drop conditionally included XGBE nodes
  Platform/SoftIron/Overdrive1000Board: remove dead XGBE references
  Silicon/AMD/Styx/AcpiPlatformDxe: replace XGBE CPP conditional with
    PCD
  Silicon/AMD/Styx/PlatInitPei: replace XGBE CPP conditional with PCD
  Silicon/AMD/Styx/StyxDtbLoaderLib: replace XGBE CPP conditional with
    PCD
  Platform/AMD/OverdriveBoard: drop DO_XGBE C preprocessor defines
  Silicon/AMD/Styx: introduce boolean PCD for KCS/IPMI support
  Silicon/AMD/Styx/AcpiPlatformDxe: move IPMI/KCS device into separate
    SSDT
  Silicon/AMD/Styx/StyxDtbLoaderLib: replace DO_KCS macro reference with
    PCD
  Platform/Styx: get rid of DO_KCS preprocessor macro
  Silicon/AMD/Styx/AcpiPlatformDxe: disable KCS on pre-B1 silicon

 Silicon/AMD/Styx/AmdStyx.dec                  |  1 +
 .../AMD/OverdriveBoard/OverdriveBoard.dsc     | 15 +-----
 Platform/LeMaker/CelloBoard/CelloBoard.dsc    |  8 ---
 .../Overdrive1000Board/Overdrive1000Board.dsc | 10 +---
 .../AMD/OverdriveBoard/OverdriveBoard.fdf     |  2 -
 .../Overdrive1000Board/Overdrive1000Board.fdf |  8 ---
 .../AcpiPlatformDxe/AcpiPlatformDxe.inf       |  3 ++
 .../Styx/Drivers/PlatInitPei/PlatInitPei.inf  |  1 +
 .../StyxDtbLoaderLib/StyxDtbLoaderLib.inf     |  2 +
 .../Drivers/AcpiPlatformDxe/AcpiPlatform.c    | 19 +++----
 .../Styx/Drivers/PlatInitPei/PlatInitPei.c    | 41 ++++++++-------
 .../StyxDtbLoaderLib/StyxDtbLoaderLib.c       | 50 ++++++++-----------
 .../AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl | 25 ----------
 .../Styx/Drivers/AcpiPlatformDxe/Iort.aslc    |  8 ---
 .../Styx/Drivers/AcpiPlatformDxe/SsdtKcs.asl  | 47 +++++++++++++++++
 15 files changed, 108 insertions(+), 132 deletions(-)
 create mode 100644 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/SsdtKcs.asl

-- 
2.19.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Dec. 12, 2018, 10:23 p.m. | #1
On Tue, Dec 11, 2018 at 07:35:03PM +0100, Ard Biesheuvel wrote:
> I promise :-)


Yeah, right :)

> This gets rid of the last build config options passed via the command

> line into the preprocessor, and replaces them with PCD references.

> 

> Ard Biesheuvel (11):

>   Silicon/AMD/Styx/Iort: drop conditionally included XGBE nodes

>   Platform/SoftIron/Overdrive1000Board: remove dead XGBE references

>   Silicon/AMD/Styx/AcpiPlatformDxe: replace XGBE CPP conditional with

>     PCD

>   Silicon/AMD/Styx/PlatInitPei: replace XGBE CPP conditional with PCD

>   Silicon/AMD/Styx/StyxDtbLoaderLib: replace XGBE CPP conditional with

>     PCD

>   Platform/AMD/OverdriveBoard: drop DO_XGBE C preprocessor defines

>   Silicon/AMD/Styx: introduce boolean PCD for KCS/IPMI support

>   Silicon/AMD/Styx/AcpiPlatformDxe: move IPMI/KCS device into separate

>     SSDT

>   Silicon/AMD/Styx/StyxDtbLoaderLib: replace DO_KCS macro reference with

>     PCD

>   Platform/Styx: get rid of DO_KCS preprocessor macro

>   Silicon/AMD/Styx/AcpiPlatformDxe: disable KCS on pre-B1 silicon


Nice bit of cleanup.
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


>  Silicon/AMD/Styx/AmdStyx.dec                  |  1 +

>  .../AMD/OverdriveBoard/OverdriveBoard.dsc     | 15 +-----

>  Platform/LeMaker/CelloBoard/CelloBoard.dsc    |  8 ---

>  .../Overdrive1000Board/Overdrive1000Board.dsc | 10 +---

>  .../AMD/OverdriveBoard/OverdriveBoard.fdf     |  2 -

>  .../Overdrive1000Board/Overdrive1000Board.fdf |  8 ---

>  .../AcpiPlatformDxe/AcpiPlatformDxe.inf       |  3 ++

>  .../Styx/Drivers/PlatInitPei/PlatInitPei.inf  |  1 +

>  .../StyxDtbLoaderLib/StyxDtbLoaderLib.inf     |  2 +

>  .../Drivers/AcpiPlatformDxe/AcpiPlatform.c    | 19 +++----

>  .../Styx/Drivers/PlatInitPei/PlatInitPei.c    | 41 ++++++++-------

>  .../StyxDtbLoaderLib/StyxDtbLoaderLib.c       | 50 ++++++++-----------

>  .../AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl | 25 ----------

>  .../Styx/Drivers/AcpiPlatformDxe/Iort.aslc    |  8 ---

>  .../Styx/Drivers/AcpiPlatformDxe/SsdtKcs.asl  | 47 +++++++++++++++++

>  15 files changed, 108 insertions(+), 132 deletions(-)

>  create mode 100644 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/SsdtKcs.asl

> 

> -- 

> 2.19.2

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Dec. 13, 2018, 11:09 a.m. | #2
On Wed, 12 Dec 2018 at 23:23, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>

> On Tue, Dec 11, 2018 at 07:35:03PM +0100, Ard Biesheuvel wrote:

> > I promise :-)

>

> Yeah, right :)

>

> > This gets rid of the last build config options passed via the command

> > line into the preprocessor, and replaces them with PCD references.

> >

> > Ard Biesheuvel (11):

> >   Silicon/AMD/Styx/Iort: drop conditionally included XGBE nodes

> >   Platform/SoftIron/Overdrive1000Board: remove dead XGBE references

> >   Silicon/AMD/Styx/AcpiPlatformDxe: replace XGBE CPP conditional with

> >     PCD

> >   Silicon/AMD/Styx/PlatInitPei: replace XGBE CPP conditional with PCD

> >   Silicon/AMD/Styx/StyxDtbLoaderLib: replace XGBE CPP conditional with

> >     PCD

> >   Platform/AMD/OverdriveBoard: drop DO_XGBE C preprocessor defines

> >   Silicon/AMD/Styx: introduce boolean PCD for KCS/IPMI support

> >   Silicon/AMD/Styx/AcpiPlatformDxe: move IPMI/KCS device into separate

> >     SSDT

> >   Silicon/AMD/Styx/StyxDtbLoaderLib: replace DO_KCS macro reference with

> >     PCD

> >   Platform/Styx: get rid of DO_KCS preprocessor macro

> >   Silicon/AMD/Styx/AcpiPlatformDxe: disable KCS on pre-B1 silicon

>

> Nice bit of cleanup.

> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>



Thanks

Pushed as  572a554e1db4..80dfc2ce18c6
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel