mbox series

[edk2,0/4] ArmPkg: use console for minimal 'exception occurred' message

Message ID 20181220173104.11481-1-ard.biesheuvel@linaro.org
Headers show
Series ArmPkg: use console for minimal 'exception occurred' message | expand

Message

Ard Biesheuvel Dec. 20, 2018, 5:31 p.m. UTC
When running with a graphical console, no message whatsoever is printed
when the systems hits an unexpected exception and hangs, because even
the minimal 'exception occurred' message is only sent to the serial port.

So let's fix that, by updating DefaultExceptionHandlerLib to take the
availability of a console into account. (#4)

This requires some preparatory decruftication so that we can safely refer
to the system table and console (#1 .. #3).

Ard Biesheuvel (4):
  ArmPkg/DebugAgentSymbolsBaseLib: remove exception handling
  ArmPkg/DefaultExceptionHandlerLib: declare the permitted usage context
  ArmPkg/DefaultExceptionHandlerLib: drop BASE variant
  ArmPkg/DefaultExceptionHandlerLib: use console if available

 ArmPkg/ArmPkg.dsc                             |   1 -
 .../AArch64/DebugAgentException.S             |  96 ------
 .../Arm/DebugAgentException.S                 | 277 ------------------
 .../Arm/DebugAgentException.asm               | 273 -----------------
 .../DebugAgentSymbolsBaseLib.c                |   7 -
 .../DebugAgentSymbolsBaseLib.inf              |   9 -
 .../AArch64/DefaultExceptionHandler.c         |  16 +-
 .../Arm/DefaultExceptionHandler.c             |   7 +-
 .../DefaultExceptionHandlerBase.c             |  35 ---
 .../DefaultExceptionHandlerLib.inf            |   5 +-
 .../DefaultExceptionHandlerLibBase.inf        |  45 ---
 ArmVirtPkg/ArmVirt.dsc.inc                    |   1 -
 12 files changed, 22 insertions(+), 750 deletions(-)
 delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/AArch64/DebugAgentException.S
 delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.S
 delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.asm
 delete mode 100644 ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerBase.c
 delete mode 100644 ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf

-- 
2.19.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Jan. 11, 2019, 5:49 p.m. UTC | #1
On Thu, Dec 20, 2018 at 06:31:00PM +0100, Ard Biesheuvel wrote:
> When running with a graphical console, no message whatsoever is printed

> when the systems hits an unexpected exception and hangs, because even

> the minimal 'exception occurred' message is only sent to the serial port.

> 

> So let's fix that, by updating DefaultExceptionHandlerLib to take the

> availability of a console into account. (#4)

> 

> This requires some preparatory decruftication so that we can safely refer

> to the system table and console (#1 .. #3).

> 

> Ard Biesheuvel (4):

>   ArmPkg/DebugAgentSymbolsBaseLib: remove exception handling

>   ArmPkg/DefaultExceptionHandlerLib: declare the permitted usage context

>   ArmPkg/DefaultExceptionHandlerLib: drop BASE variant

>   ArmPkg/DefaultExceptionHandlerLib: use console if available


For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


>  ArmPkg/ArmPkg.dsc                             |   1 -

>  .../AArch64/DebugAgentException.S             |  96 ------

>  .../Arm/DebugAgentException.S                 | 277 ------------------

>  .../Arm/DebugAgentException.asm               | 273 -----------------

>  .../DebugAgentSymbolsBaseLib.c                |   7 -

>  .../DebugAgentSymbolsBaseLib.inf              |   9 -

>  .../AArch64/DefaultExceptionHandler.c         |  16 +-

>  .../Arm/DefaultExceptionHandler.c             |   7 +-

>  .../DefaultExceptionHandlerBase.c             |  35 ---

>  .../DefaultExceptionHandlerLib.inf            |   5 +-

>  .../DefaultExceptionHandlerLibBase.inf        |  45 ---

>  ArmVirtPkg/ArmVirt.dsc.inc                    |   1 -

>  12 files changed, 22 insertions(+), 750 deletions(-)

>  delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/AArch64/DebugAgentException.S

>  delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.S

>  delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.asm

>  delete mode 100644 ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerBase.c

>  delete mode 100644 ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf

> 

> -- 

> 2.19.2

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel