mbox series

[RFC,0/2] allow optee to be exposed on ACPI systems

Message ID 20181227190122.23149-1-ard.biesheuvel@linaro.org
Headers show
Series allow optee to be exposed on ACPI systems | expand

Message

Ard Biesheuvel Dec. 27, 2018, 7:01 p.m. UTC 
Similar to how OP-TEE is exposed as a pseudo device under /firmware/optee
on DT systems, permit OP-TEE presence to be exposed via a device object
in the ACPI namespace. This makes it possible to model the OP-TEE interface
as a platform device gets instantiated automatically both on DT and ACPI
systems, and implement the driver as a platform driver that is able to
use the generic device properties API to access the 'method' attribute
as well as potential future extensions to the binding that introduce
new attributes.

What remains to be discussed is how to expose OP-TEE pseudo devices,
e.g., Sumit's RNG implementation on SynQuacer which we would like to
bind a Linux driver to.

Cc: Jens Wiklander <jens.wiklander@linaro.org>
Cc: Sumit Garg <sumit.garg@linaro.org>
Cc: Graeme Gregory <graeme.gregory@linaro.org>
Cc: Jerome Forissier <jerome.forissier@linaro.org>

Ard Biesheuvel (2):
  optee: model OP-TEE as a platform device/driver
  optee: add ACPI support

 drivers/tee/optee/core.c | 94 +++++++++-----------
 1 file changed, 41 insertions(+), 53 deletions(-)

-- 
2.19.2

Comments

Sumit Garg Jan. 2, 2019, 5:04 a.m. UTC | #1 
On Fri, 28 Dec 2018 at 00:31, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>

> Similar to how OP-TEE is exposed as a pseudo device under /firmware/optee

> on DT systems, permit OP-TEE presence to be exposed via a device object

> in the ACPI namespace. This makes it possible to model the OP-TEE interface

> as a platform device gets instantiated automatically both on DT and ACPI

> systems, and implement the driver as a platform driver that is able to

> use the generic device properties API to access the 'method' attribute

> as well as potential future extensions to the binding that introduce

> new attributes.

>

> What remains to be discussed is how to expose OP-TEE pseudo devices,

> e.g., Sumit's RNG implementation on SynQuacer which we would like to

> bind a Linux driver to.

>

> Cc: Jens Wiklander <jens.wiklander@linaro.org>

> Cc: Sumit Garg <sumit.garg@linaro.org>

> Cc: Graeme Gregory <graeme.gregory@linaro.org>

> Cc: Jerome Forissier <jerome.forissier@linaro.org>

>

> Ard Biesheuvel (2):

>   optee: model OP-TEE as a platform device/driver

>   optee: add ACPI support

>

>  drivers/tee/optee/core.c | 94 +++++++++-----------

>  1 file changed, 41 insertions(+), 53 deletions(-)

>


Looks good to me.

Acked-by: Sumit Garg <sumit.garg@linaro.org>



> --

> 2.19.2

>