[PATCHv2,0/2] locking/atomics: fix and improvement

Message ID 20190211132213.15249-1-mark.rutland@arm.com
Headers show
  • locking/atomics: fix and improvement
Related show


Mark Rutland Feb. 11, 2019, 1:22 p.m.
Hi Ingo,

[Apologies for the duplicate send of this, I typo'd LKML in my initial attempt]

I hope that these atomic scripting patches address your concerns with
the atomics scripting infrastructure. These are based on the tip master
branch, leaving the headers checked-in.

Since v1 [1]:
* rebase (and retest) atop of tip:master
* fold in acks

The primary improvement is using a hash to detect when the headers have
been erroneously modified, meaning check-atomics.sh takes ~0.15s, which
I believe should be palatable.

It also turns out that some people are building without coreutils, so
I've picked up Anders' fix for this. Since sha1sum is part of coreutils,
the checks are skipped when this isn't present, on the assumption that
anyone actually sending patches will have a working coreutils.

Are you happy to pick these up?


[1] https://lore.kernel.org/lkml/20181210175035.45096-1-mark.rutland@arm.com/T/#m39ee97e01a02b5d054cca4d028445bb3a9818e91

Anders Roxell (1):
  locking/atomics: Change 'fold' to 'grep'

Mark Rutland (1):
  locking/atomics: Check atomic headers with sha1sum

 include/asm-generic/atomic-instrumented.h |  1 +
 include/asm-generic/atomic-long.h         |  1 +
 include/linux/atomic-fallback.h           |  1 +
 scripts/atomic/atomic-tbl.sh              |  2 +-
 scripts/atomic/check-atomics.sh           | 26 ++++++++++++++++++++------
 scripts/atomic/gen-atomics.sh             | 20 ++++++++++++++++++++
 6 files changed, 44 insertions(+), 7 deletions(-)
 create mode 100755 scripts/atomic/gen-atomics.sh