mbox series

[V3,0/8] genirq/timings: Fixes and selftests

Message ID 20190527205521.12091-1-daniel.lezcano@linaro.org
Headers show
Series genirq/timings: Fixes and selftests | expand

Message

Daniel Lezcano May 27, 2019, 8:55 p.m. UTC 
This series provides a couple of fixes, an optimization and the code
to do the selftests.

While writing the selftests, a couple of issues were spotted with
the circular buffer handling and the routine searching for the pattern
multiple times.

In addition, a small optimization has been found while investigating the
bugs above.

In order to write the selftest, the routine needed by the core code and
the tests are wrapped into function which are always inline so the current
code is not impacted by a new function call. There is no functional
changes in this part.

Finally, the selftest uses samples to insert values in the arrays and
use them to predict the next event. These tests cover the most difficult
part of the code.

Changelog:

V3:
  - Removed patch using the min macro
  - Fixed comment typos in patch 1/8
V2:
  - Removed defaulting to 'n' as it is already the case


*** BLURB HERE ***

Daniel Lezcano (8):
  genirq/timings: Fix next event index function
  genirq/timings: Fix timings buffer inspection
  genirq/timings: Optimize the period detection speed
  genirq/timings: Encapsulate timings push
  genirq/timings: Encapsulate storing function
  genirq/timings: Add selftest for circular array
  genirq/timings: Add selftest for irqs circular buffer
  genirq/timings: Add selftest for next event computation

 kernel/irq/Makefile    |   3 +
 kernel/irq/internals.h |  21 +-
 kernel/irq/timings.c   | 453 +++++++++++++++++++++++++++++++++++++----
 lib/Kconfig.debug      |   8 +
 4 files changed, 442 insertions(+), 43 deletions(-)

-- 
2.17.1

Comments

Daniel Lezcano June 4, 2019, 6:15 a.m. UTC | #1 
Hi,

is it possible to consider this series for merging?

Thanks in advance

  -- Daniel


On 27/05/2019 22:55, Daniel Lezcano wrote:
> This series provides a couple of fixes, an optimization and the code

> to do the selftests.

> 

> While writing the selftests, a couple of issues were spotted with

> the circular buffer handling and the routine searching for the pattern

> multiple times.

> 

> In addition, a small optimization has been found while investigating the

> bugs above.

> 

> In order to write the selftest, the routine needed by the core code and

> the tests are wrapped into function which are always inline so the current

> code is not impacted by a new function call. There is no functional

> changes in this part.

> 

> Finally, the selftest uses samples to insert values in the arrays and

> use them to predict the next event. These tests cover the most difficult

> part of the code.

> 

> Changelog:

> 

> V3:

>   - Removed patch using the min macro

>   - Fixed comment typos in patch 1/8

> V2:

>   - Removed defaulting to 'n' as it is already the case

> 

> 

> *** BLURB HERE ***

> 

> Daniel Lezcano (8):

>   genirq/timings: Fix next event index function

>   genirq/timings: Fix timings buffer inspection

>   genirq/timings: Optimize the period detection speed

>   genirq/timings: Encapsulate timings push

>   genirq/timings: Encapsulate storing function

>   genirq/timings: Add selftest for circular array

>   genirq/timings: Add selftest for irqs circular buffer

>   genirq/timings: Add selftest for next event computation

> 

>  kernel/irq/Makefile    |   3 +

>  kernel/irq/internals.h |  21 +-

>  kernel/irq/timings.c   | 453 +++++++++++++++++++++++++++++++++++++----

>  lib/Kconfig.debug      |   8 +

>  4 files changed, 442 insertions(+), 43 deletions(-)

> 



-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog