[v6,0/5] LM36274 Introduction

Message ID 20190605125634.7042-1-dmurphy@ti.com
Headers show
Series
  • LM36274 Introduction
Related show

Message

Dan Murphy June 5, 2019, 12:56 p.m.
Hello

The v5 patchset missed adding in the new validation code.
Patch 1 of the v5 series was squashed into patch 4 of the v5 series.
So this will reduce the patchset by 1.

Sorry for the extra noise on the patchsets.  The change was lost when I converted
the patches from the mainline branch to the LED branch.

This change was made on top of the branch

repo: https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git
branch: ti-lmu-led-drivers


Dan Murphy (5):
  dt-bindings: mfd: Add lm36274 bindings to ti-lmu
  mfd: ti-lmu: Add LM36274 support to the ti-lmu
  regulator: lm363x: Add support for LM36274
  dt-bindings: leds: Add LED bindings for the LM36274
  leds: lm36274: Introduce the TI LM36274 LED driver

 .../devicetree/bindings/leds/leds-lm36274.txt |  82 +++++++++
 .../devicetree/bindings/mfd/ti-lmu.txt        |  54 ++++++
 drivers/leds/Kconfig                          |   8 +
 drivers/leds/Makefile                         |   1 +
 drivers/leds/leds-lm36274.c                   | 174 ++++++++++++++++++
 drivers/mfd/Kconfig                           |   5 +-
 drivers/mfd/ti-lmu.c                          |  14 ++
 drivers/regulator/Kconfig                     |   2 +-
 drivers/regulator/lm363x-regulator.c          |  78 +++++++-
 include/linux/mfd/ti-lmu-register.h           |  23 +++
 include/linux/mfd/ti-lmu.h                    |   4 +
 11 files changed, 437 insertions(+), 8 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lm36274.txt
 create mode 100644 drivers/leds/leds-lm36274.c

-- 
2.21.0.5.gaeb582a983

Comments

Mark Brown June 5, 2019, 6:17 p.m. | #1
On Wed, Jun 05, 2019 at 07:56:32AM -0500, Dan Murphy wrote:
> Adding regulator support for the LM36274 backlight driver.

> This device can leverage this existing code as the functionality

> and registers are common enough between the LM36274 and the LM363x

> series of devices.


Acked-by: Mark Brown <broonie@kernel.org>
Jacek Anaszewski June 5, 2019, 7:31 p.m. | #2
Hi Dan,

Thank you for the v6.

Patches 4/5 and 5/5 don't contain amendments I made to
the respective patches on the ib-leds-mfd-regulator branch
(that address issues raised by Pavel), so I just kept those
unchanged. Besides that I updated the remaining ones.

Please check the ib-leds-mfd-regulator branch. I'll create a pull
request once I get a confirmation from you saying that everything
is as expected.

Best regards,
Jacek Anaszewski

On 6/5/19 2:56 PM, Dan Murphy wrote:
> Hello

> 

> The v5 patchset missed adding in the new validation code.

> Patch 1 of the v5 series was squashed into patch 4 of the v5 series.

> So this will reduce the patchset by 1.

> 

> Sorry for the extra noise on the patchsets.  The change was lost when I converted

> the patches from the mainline branch to the LED branch.

> 

> This change was made on top of the branch

> 

> repo: https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git

> branch: ti-lmu-led-drivers

> 

> 

> Dan Murphy (5):

>    dt-bindings: mfd: Add lm36274 bindings to ti-lmu

>    mfd: ti-lmu: Add LM36274 support to the ti-lmu

>    regulator: lm363x: Add support for LM36274

>    dt-bindings: leds: Add LED bindings for the LM36274

>    leds: lm36274: Introduce the TI LM36274 LED driver

> 

>   .../devicetree/bindings/leds/leds-lm36274.txt |  82 +++++++++

>   .../devicetree/bindings/mfd/ti-lmu.txt        |  54 ++++++

>   drivers/leds/Kconfig                          |   8 +

>   drivers/leds/Makefile                         |   1 +

>   drivers/leds/leds-lm36274.c                   | 174 ++++++++++++++++++

>   drivers/mfd/Kconfig                           |   5 +-

>   drivers/mfd/ti-lmu.c                          |  14 ++

>   drivers/regulator/Kconfig                     |   2 +-

>   drivers/regulator/lm363x-regulator.c          |  78 +++++++-

>   include/linux/mfd/ti-lmu-register.h           |  23 +++

>   include/linux/mfd/ti-lmu.h                    |   4 +

>   11 files changed, 437 insertions(+), 8 deletions(-)

>   create mode 100644 Documentation/devicetree/bindings/leds/leds-lm36274.txt

>   create mode 100644 drivers/leds/leds-lm36274.c

>
Pavel Machek June 6, 2019, 9:53 a.m. | #3
On Wed 2019-06-05 07:56:32, Dan Murphy wrote:
> Adding regulator support for the LM36274 backlight driver.

> This device can leverage this existing code as the functionality

> and registers are common enough between the LM36274 and the LM363x

> series of devices.

> 

> Signed-off-by: Dan Murphy <dmurphy@ti.com>

> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>


Acked-by: Pavel Machek <pavel@ucw.cz>


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Pavel Machek June 6, 2019, 10:01 a.m. | #4
Hi!

>  .../devicetree/bindings/leds/leds-lm36274.txt | 82 +++++++++++++++++++

>  1 file changed, 82 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/leds/leds-lm36274.txt

> 

> diff --git a/Documentation/devicetree/bindings/leds/leds-lm36274.txt b/Documentation/devicetree/bindings/leds/leds-lm36274.txt

> new file mode 100644

> index 000000000000..329393700191

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/leds/leds-lm36274.txt

> @@ -0,0 +1,82 @@

> +* Texas Instruments LM36274 4-Channel LCD Backlight Driver w/Integrated Bias

> +

> +The LM36274 is an integrated four-channel WLED driver and LCD bias supply.

> +The backlight boost provides the power to bias four parallel LED strings with

> +up to 29V total output voltage. The 11-bit LED current is programmable via

> +the I2C bus and/or controlled via a logic level PWM input from 60 μA to 30 mA.

> +

> +Parent device properties are documented in ../mfd/ti_lmu.txt

> +Regulator properties are documented in ../regulator/lm363x-regulator.txt


Should these paths follow the same format as below
(Documentation/devicetree/bindings)

?

Otherwise looks good.

Acked-by: Pavel Machek <pavel@ucw.cz>

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Dan Murphy June 11, 2019, 12:17 p.m. | #5
Jacek

Reviewed and tested the updated branch.  Looks good to me.

Dan

On 6/5/19 2:31 PM, Jacek Anaszewski wrote:
> Hi Dan,

>

> Thank you for the v6.

>

> Patches 4/5 and 5/5 don't contain amendments I made to

> the respective patches on the ib-leds-mfd-regulator branch

> (that address issues raised by Pavel), so I just kept those

> unchanged. Besides that I updated the remaining ones.

>

> Please check the ib-leds-mfd-regulator branch. I'll create a pull

> request once I get a confirmation from you saying that everything

> is as expected.

>

> Best regards,

> Jacek Anaszewski

>

> On 6/5/19 2:56 PM, Dan Murphy wrote:

>> Hello

>>

>> The v5 patchset missed adding in the new validation code.

>> Patch 1 of the v5 series was squashed into patch 4 of the v5 series.

>> So this will reduce the patchset by 1.

>>

>> Sorry for the extra noise on the patchsets.  The change was lost when 

>> I converted

>> the patches from the mainline branch to the LED branch.

>>

>> This change was made on top of the branch

>>

>> repo: 

>> https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git

>> branch: ti-lmu-led-drivers

>>

>>

>> Dan Murphy (5):

>>    dt-bindings: mfd: Add lm36274 bindings to ti-lmu

>>    mfd: ti-lmu: Add LM36274 support to the ti-lmu

>>    regulator: lm363x: Add support for LM36274

>>    dt-bindings: leds: Add LED bindings for the LM36274

>>    leds: lm36274: Introduce the TI LM36274 LED driver

>>

>>   .../devicetree/bindings/leds/leds-lm36274.txt |  82 +++++++++

>>   .../devicetree/bindings/mfd/ti-lmu.txt        |  54 ++++++

>>   drivers/leds/Kconfig                          |   8 +

>>   drivers/leds/Makefile                         |   1 +

>>   drivers/leds/leds-lm36274.c                   | 174 ++++++++++++++++++

>>   drivers/mfd/Kconfig                           |   5 +-

>>   drivers/mfd/ti-lmu.c                          |  14 ++

>>   drivers/regulator/Kconfig                     |   2 +-

>>   drivers/regulator/lm363x-regulator.c          |  78 +++++++-

>>   include/linux/mfd/ti-lmu-register.h           |  23 +++

>>   include/linux/mfd/ti-lmu.h                    |   4 +

>>   11 files changed, 437 insertions(+), 8 deletions(-)

>>   create mode 100644 

>> Documentation/devicetree/bindings/leds/leds-lm36274.txt

>>   create mode 100644 drivers/leds/leds-lm36274.c

>>

>
Lee Jones June 24, 2019, 2:42 p.m. | #6
On Wed, 05 Jun 2019, Dan Murphy wrote:

> Hello

> 

> The v5 patchset missed adding in the new validation code.

> Patch 1 of the v5 series was squashed into patch 4 of the v5 series.

> So this will reduce the patchset by 1.

> 

> Sorry for the extra noise on the patchsets.  The change was lost when I converted

> the patches from the mainline branch to the LED branch.

> 

> This change was made on top of the branch

> 

> repo: https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git

> branch: ti-lmu-led-drivers

> 

> 

> Dan Murphy (5):

>   dt-bindings: mfd: Add lm36274 bindings to ti-lmu

>   mfd: ti-lmu: Add LM36274 support to the ti-lmu

>   regulator: lm363x: Add support for LM36274

>   dt-bindings: leds: Add LED bindings for the LM36274

>   leds: lm36274: Introduce the TI LM36274 LED driver

> 

>  .../devicetree/bindings/leds/leds-lm36274.txt |  82 +++++++++

>  .../devicetree/bindings/mfd/ti-lmu.txt        |  54 ++++++

>  drivers/leds/Kconfig                          |   8 +

>  drivers/leds/Makefile                         |   1 +

>  drivers/leds/leds-lm36274.c                   | 174 ++++++++++++++++++

>  drivers/mfd/Kconfig                           |   5 +-

>  drivers/mfd/ti-lmu.c                          |  14 ++

>  drivers/regulator/Kconfig                     |   2 +-

>  drivers/regulator/lm363x-regulator.c          |  78 +++++++-

>  include/linux/mfd/ti-lmu-register.h           |  23 +++

>  include/linux/mfd/ti-lmu.h                    |   4 +

>  11 files changed, 437 insertions(+), 8 deletions(-)

>  create mode 100644 Documentation/devicetree/bindings/leds/leds-lm36274.txt

>  create mode 100644 drivers/leds/leds-lm36274.c


Can you finish of satisfying everyone's comments and re-send with all
the Acks you've collected so far?  If you turn this around quickly,
you might still get into v5.3.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Dan Murphy June 24, 2019, 5:20 p.m. | #7
Lee

On 6/24/19 9:42 AM, Lee Jones wrote:
> On Wed, 05 Jun 2019, Dan Murphy wrote:

>

>> Hello

>>

>> The v5 patchset missed adding in the new validation code.

>> Patch 1 of the v5 series was squashed into patch 4 of the v5 series.

>> So this will reduce the patchset by 1.

>>

>> Sorry for the extra noise on the patchsets.  The change was lost when I converted

>> the patches from the mainline branch to the LED branch.

>>

>> This change was made on top of the branch

>>

>> repo: https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git

>> branch: ti-lmu-led-drivers

>>

>>

>> Dan Murphy (5):

>>    dt-bindings: mfd: Add lm36274 bindings to ti-lmu

>>    mfd: ti-lmu: Add LM36274 support to the ti-lmu

>>    regulator: lm363x: Add support for LM36274

>>    dt-bindings: leds: Add LED bindings for the LM36274

>>    leds: lm36274: Introduce the TI LM36274 LED driver

>>

>>   .../devicetree/bindings/leds/leds-lm36274.txt |  82 +++++++++

>>   .../devicetree/bindings/mfd/ti-lmu.txt        |  54 ++++++

>>   drivers/leds/Kconfig                          |   8 +

>>   drivers/leds/Makefile                         |   1 +

>>   drivers/leds/leds-lm36274.c                   | 174 ++++++++++++++++++

>>   drivers/mfd/Kconfig                           |   5 +-

>>   drivers/mfd/ti-lmu.c                          |  14 ++

>>   drivers/regulator/Kconfig                     |   2 +-

>>   drivers/regulator/lm363x-regulator.c          |  78 +++++++-

>>   include/linux/mfd/ti-lmu-register.h           |  23 +++

>>   include/linux/mfd/ti-lmu.h                    |   4 +

>>   11 files changed, 437 insertions(+), 8 deletions(-)

>>   create mode 100644 Documentation/devicetree/bindings/leds/leds-lm36274.txt

>>   create mode 100644 drivers/leds/leds-lm36274.c

> Can you finish of satisfying everyone's comments and re-send with all

> the Acks you've collected so far?  If you turn this around quickly,

> you might still get into v5.3.

>


The changes were made by Jacek and I reviewed and tested them

https://lkml.org/lkml/2019/6/11/455
Lee Jones June 25, 2019, 6:30 a.m. | #8
On Mon, 24 Jun 2019, Dan Murphy wrote:

> Lee

> 

> On 6/24/19 9:42 AM, Lee Jones wrote:

> > On Wed, 05 Jun 2019, Dan Murphy wrote:

> > 

> > > Hello

> > > 

> > > The v5 patchset missed adding in the new validation code.

> > > Patch 1 of the v5 series was squashed into patch 4 of the v5 series.

> > > So this will reduce the patchset by 1.

> > > 

> > > Sorry for the extra noise on the patchsets.  The change was lost when I converted

> > > the patches from the mainline branch to the LED branch.

> > > 

> > > This change was made on top of the branch

> > > 

> > > repo: https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git

> > > branch: ti-lmu-led-drivers

> > > 

> > > 

> > > Dan Murphy (5):

> > >    dt-bindings: mfd: Add lm36274 bindings to ti-lmu

> > >    mfd: ti-lmu: Add LM36274 support to the ti-lmu

> > >    regulator: lm363x: Add support for LM36274

> > >    dt-bindings: leds: Add LED bindings for the LM36274

> > >    leds: lm36274: Introduce the TI LM36274 LED driver

> > > 

> > >   .../devicetree/bindings/leds/leds-lm36274.txt |  82 +++++++++

> > >   .../devicetree/bindings/mfd/ti-lmu.txt        |  54 ++++++

> > >   drivers/leds/Kconfig                          |   8 +

> > >   drivers/leds/Makefile                         |   1 +

> > >   drivers/leds/leds-lm36274.c                   | 174 ++++++++++++++++++

> > >   drivers/mfd/Kconfig                           |   5 +-

> > >   drivers/mfd/ti-lmu.c                          |  14 ++

> > >   drivers/regulator/Kconfig                     |   2 +-

> > >   drivers/regulator/lm363x-regulator.c          |  78 +++++++-

> > >   include/linux/mfd/ti-lmu-register.h           |  23 +++

> > >   include/linux/mfd/ti-lmu.h                    |   4 +

> > >   11 files changed, 437 insertions(+), 8 deletions(-)

> > >   create mode 100644 Documentation/devicetree/bindings/leds/leds-lm36274.txt

> > >   create mode 100644 drivers/leds/leds-lm36274.c

> > Can you finish of satisfying everyone's comments and re-send with all

> > the Acks you've collected so far?  If you turn this around quickly,

> > you might still get into v5.3.

> > 

> 

> The changes were made by Jacek and I reviewed and tested them

> 

> https://lkml.org/lkml/2019/6/11/455


Ah, this was related to the recent GIT PULL craziness.

Thanks for letting me know.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog