mbox series

[PULL,v2,00/12] tcg patch queue

Message ID 20191028145937.10914-1-richard.henderson@linaro.org
Headers show
Series tcg patch queue | expand

Message

Richard Henderson Oct. 28, 2019, 2:59 p.m. UTC
V2 fixes a build problem that affected win32.


r~


The following changes since commit 187f35512106501fe9a11057f4d8705431e0026d:

  Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-next-251019-3' into staging (2019-10-26 10:13:48 +0100)

are available in the Git repository at:

  https://github.com/rth7680/qemu.git tags/pull-tcg-20191028

for you to fetch changes up to fe9b676fb3160496b4b2bf0c57d33be724bf04c3:

  translate-all: Remove tb_alloc (2019-10-28 10:35:23 +0100)

----------------------------------------------------------------
Improvements for TARGET_PAGE_BITS_VARY
Fix for TCI ld16u_i64.
Fix for segv on icount execute from i/o memory.
Two misc cleanups.

----------------------------------------------------------------
Alex Bennée (1):
      cputlb: ensure _cmmu helper functions follow the naming standard

Clement Deschamps (1):
      translate-all: fix uninitialized tb->orig_tb

Richard Henderson (8):
      exec: Split out variable page size support to exec-vary.c
      configure: Detect compiler support for __attribute__((alias))
      exec: Use const alias for TARGET_PAGE_BITS_VARY
      exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG
      exec: Promote TARGET_PAGE_MASK to target_long
      exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY
      cputlb: Fix tlb_vaddr_to_host
      translate-all: Remove tb_alloc

Stefan Weil (1):
      tci: Add implementation for INDEX_op_ld16u_i64

Wei Yang (1):
      cpu: use ROUND_UP() to define xxx_PAGE_ALIGN

 Makefile.target                  |   2 +-
 include/exec/cpu-all.h           |  33 ++++++++----
 include/exec/cpu_ldst_template.h |   4 +-
 include/qemu-common.h            |   6 +++
 tcg/tcg.h                        |  20 +++++---
 accel/tcg/cputlb.c               |  26 ++++++++--
 accel/tcg/translate-all.c        |  21 ++------
 exec-vary.c                      | 108 +++++++++++++++++++++++++++++++++++++++
 exec.c                           |  34 ------------
 target/cris/translate_v10.inc.c  |   3 +-
 tcg/tci.c                        |  15 ++++++
 configure                        |  19 +++++++
 12 files changed, 214 insertions(+), 77 deletions(-)
 create mode 100644 exec-vary.c

Comments

no-reply@patchew.org Oct. 28, 2019, 5:20 p.m. UTC | #1
Patchew URL: https://patchew.org/QEMU/20191028145937.10914-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL v2 00/12] tcg patch queue
Type: series
Message-id: 20191028145937.10914-1-richard.henderson@linaro.org

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
dddd2c9 translate-all: Remove tb_alloc
ce663b2 translate-all: fix uninitialized tb->orig_tb
90c3eba cputlb: Fix tlb_vaddr_to_host
d2b8cbd exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY
4ce23d0 exec: Promote TARGET_PAGE_MASK to target_long
7d2699f exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG
b5f712d exec: Use const alias for TARGET_PAGE_BITS_VARY
8d1e9d0 configure: Detect compiler support for __attribute__((alias))
cad9025 exec: Split out variable page size support to exec-vary.c
b290db4 cpu: use ROUND_UP() to define xxx_PAGE_ALIGN
60dbf14 cputlb: ensure _cmmu helper functions follow the naming standard
cdaeeaf tci: Add implementation for INDEX_op_ld16u_i64

=== OUTPUT BEGIN ===
1/12 Checking commit cdaeeaf401d2 (tci: Add implementation for INDEX_op_ld16u_i64)
2/12 Checking commit 60dbf140a9ab (cputlb: ensure _cmmu helper functions follow the naming standard)
3/12 Checking commit b290db446298 (cpu: use ROUND_UP() to define xxx_PAGE_ALIGN)
4/12 Checking commit cad9025d89cb (exec: Split out variable page size support to exec-vary.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

total: 0 errors, 1 warnings, 125 lines checked

Patch 4/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/12 Checking commit 8d1e9d07c296 (configure: Detect compiler support for __attribute__((alias)))
6/12 Checking commit b5f712d02e4f (exec: Use const alias for TARGET_PAGE_BITS_VARY)
ERROR: externs should be avoided in .c files
#66: FILE: exec-vary.c:57:
+extern const TargetPageBits target_page

total: 1 errors, 0 warnings, 109 lines checked

Patch 6/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/12 Checking commit 7d2699f55dd2 (exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG)
8/12 Checking commit 4ce23d02a238 (exec: Promote TARGET_PAGE_MASK to target_long)
9/12 Checking commit d2b8cbd91572 (exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY)
10/12 Checking commit 90c3eba34f5f (cputlb: Fix tlb_vaddr_to_host)
11/12 Checking commit ce663b281c78 (translate-all: fix uninitialized tb->orig_tb)
12/12 Checking commit dddd2c942dd5 (translate-all: Remove tb_alloc)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20191028145937.10914-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Peter Maydell Oct. 29, 2019, 3:32 p.m. UTC | #2
On Mon, 28 Oct 2019 at 14:59, Richard Henderson
<richard.henderson@linaro.org> wrote:
>

> V2 fixes a build problem that affected win32.

>

>

> r~

>

>

> The following changes since commit 187f35512106501fe9a11057f4d8705431e0026d:

>

>   Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-next-251019-3' into staging (2019-10-26 10:13:48 +0100)

>

> are available in the Git repository at:

>

>   https://github.com/rth7680/qemu.git tags/pull-tcg-20191028

>

> for you to fetch changes up to fe9b676fb3160496b4b2bf0c57d33be724bf04c3:

>

>   translate-all: Remove tb_alloc (2019-10-28 10:35:23 +0100)

>

> ----------------------------------------------------------------

> Improvements for TARGET_PAGE_BITS_VARY

> Fix for TCI ld16u_i64.

> Fix for segv on icount execute from i/o memory.

> Two misc cleanups.

>

> ----------------------------------------------------------------


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
for any user-visible changes.

-- PMM